Skip to content

Commit 017dfde

Browse files
authored
fixing span name for create_and_process (#42875)
* fixing span name for create_and_process * remove trailing white space * updating changelog
1 parent 5bbadba commit 017dfde

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

sdk/ai/azure-ai-agents/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
- Fix issue with tracing an Agent message, when the message has "in progress" status (related to [GitHub Issue 42645](https://github.com/Azure/azure-sdk-for-python/issues/42645)).
1717
- Fix issue with tracing `RunStepOpenAPIToolCall` (GitHub issues [42645](https://github.com/Azure/azure-sdk-for-python/issues/42645) and [42864](https://github.com/Azure/azure-sdk-for-python/issues/42864)).
1818
- Fix issue when `.threads.create(messages=[ThreadMessageOptions(...])` is called on the `AgentsClient`, when tracing is enabled ([GitHub issue 42805](https://github.com/Azure/azure-sdk-for-python/issues/42805))
19+
- Fix an issue in the code where, when tracing is enabled and the function AgentsClient.runs.create_and_process is used, the span "start_thread_run" appears twice in trace, once as a parent and once as a child span. The parent span name has been changed to "process_thread_run". Note that the semantic conventions used in the traces (including spans and attributes) are still subject to change.
1920

2021
### Sample updates
2122

sdk/ai/azure-ai-agents/azure/ai/agents/telemetry/_ai_agents_instrumentor.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1554,15 +1554,15 @@ def inner(*args, **kwargs): # pylint: disable=R0911
15541554
if class_function_name.startswith("MessagesOperations.create"):
15551555
kwargs.setdefault("merge_span", True)
15561556
return self.trace_create_message(function, *args, **kwargs)
1557+
if class_function_name.startswith("RunsOperations.create_and_process"):
1558+
kwargs.setdefault("merge_span", True)
1559+
return self.trace_create_run(OperationName.PROCESS_THREAD_RUN, function, *args, **kwargs)
15571560
if class_function_name.startswith("RunsOperations.create"):
15581561
kwargs.setdefault("merge_span", True)
15591562
return self.trace_create_run(OperationName.START_THREAD_RUN, function, *args, **kwargs)
15601563
if class_function_name.startswith("RunsOperations.get"):
15611564
kwargs.setdefault("merge_span", True)
15621565
return self.trace_get_run(OperationName.GET_THREAD_RUN, function, *args, **kwargs)
1563-
if class_function_name.startswith("RunsOperations.create_and_process"):
1564-
kwargs.setdefault("merge_span", True)
1565-
return self.trace_create_run(OperationName.PROCESS_THREAD_RUN, function, *args, **kwargs)
15661566
if class_function_name.startswith("AgentsClient.create_thread_and_run"):
15671567
kwargs.setdefault("merge_span", True)
15681568
return self.trace_create_run(OperationName.PROCESS_THREAD_RUN, function, *args, **kwargs)
@@ -1630,15 +1630,15 @@ async def inner(*args, **kwargs): # pylint: disable=R0911
16301630
if class_function_name.startswith("MessagesOperations.create"):
16311631
kwargs.setdefault("merge_span", True)
16321632
return await self.trace_create_message_async(function, *args, **kwargs)
1633+
if class_function_name.startswith("RunsOperations.create_and_process"):
1634+
kwargs.setdefault("merge_span", True)
1635+
return await self.trace_create_run_async(OperationName.PROCESS_THREAD_RUN, function, *args, **kwargs)
16331636
if class_function_name.startswith("RunsOperations.create"):
16341637
kwargs.setdefault("merge_span", True)
16351638
return await self.trace_create_run_async(OperationName.START_THREAD_RUN, function, *args, **kwargs)
16361639
if class_function_name.startswith("RunsOperations.get"):
16371640
kwargs.setdefault("merge_span", True)
16381641
return await self.trace_get_run_async(OperationName.GET_THREAD_RUN, function, *args, **kwargs)
1639-
if class_function_name.startswith("RunsOperations.create_and_process"):
1640-
kwargs.setdefault("merge_span", True)
1641-
return await self.trace_create_run_async(OperationName.PROCESS_THREAD_RUN, function, *args, **kwargs)
16421642
if class_function_name.startswith("AgentsClient.create_thread_and_run"):
16431643
kwargs.setdefault("merge_span", True)
16441644
return await self.trace_create_run_async(OperationName.PROCESS_THREAD_RUN, function, *args, **kwargs)

0 commit comments

Comments
 (0)