move tools/azure-sdk-tools under eng/tools

Author: scbedd

.github/workflows/azure-sdk-tools.yml

@@ -5,7 +5,7 @@ on:
   pull_request:
     branches: [ main ]
     paths:
-      - "tools/azure-sdk-tools/**"
+      - "eng/tools/azure-sdk-tools/**"
 
 jobs:
   build-and-test:
@@ -20,12 +20,12 @@ jobs:
 
       - name: Install azure-sdk-tools
         run: |
-          python -m pip install -e tools/azure-sdk-tools[build,ghtools,conda]
+          python -m pip install -e eng/tools/azure-sdk-tools[build,ghtools,conda]
           python -m pip freeze
         shell: bash
 
       - name: Run tests
         run: |
           pytest ./tests
         shell: bash
-        working-directory: tools/azure-sdk-tools
+        working-directory: eng/tools/azure-sdk-tools

doc/dev/code_snippets.md

@@ -43,7 +43,7 @@ If you have a file in `samples\text_example_async.py` with a snippet named `asyn
 ## Run python_snippet_updater tool
 
 ```powershell
-python <azure-sdk-for-python>/tools/azure-sdk-tools/ci_tools/snippet_update/python_snippet_updater.py <path_to_the_service>
+python <azure-sdk-for-python>/eng/tools/azure-sdk-tools/ci_tools/snippet_update/python_snippet_updater.py <path_to_the_service>
 ```
 
 The script scans the snippets in samples folder and populates snippet references in README with the snippet definitions from samples folder.

doc/dev/conda-builds.md

@@ -22,7 +22,7 @@ Follow the instructions [here](https://docs.conda.io/projects/conda-build/en/lat
 
 ```bash
 # cd <repo root>
-pip install "tools/azure-sdk-tools[build,conda]"
+pip install "eng/tools/azure-sdk-tools[build,conda]"
 ```
 
 ### Get the configuration blob

doc/dev/credscan_process.md

@@ -73,5 +73,5 @@ strings in that file will still trigger warnings if present in another unsuppres
 [ci_scan_output]: https://dev.azure.com/azure-sdk/public/_build/results?buildId=1426258&view=logs&jobId=b70e5e73-bbb6-5567-0939-8415943fadb9&j=bc67675d-56bf-581f-e0a2-208848ba68ca&t=7eee3a58-6120-518b-7fcb-7e943712aa81
 [credscan_doc]: https://aka.ms/credscan
 [devops_doc]: https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/413/Credential-Scan-Step-in-Pipeline
-[fake_credentials]: https://github.com/Azure/azure-sdk-for-python/blob/main/tools/azure-sdk-tools/devtools_testutils/fake_credentials.py
+[fake_credentials]: https://github.com/Azure/azure-sdk-for-python/blob/main/eng/tools/azure-sdk-tools/devtools_testutils/fake_credentials.py
 [suppression_file]: https://github.com/Azure/azure-sdk-for-python/blob/main/eng/CredScanSuppression.json

doc/dev/mgmt/mgmt_release.md

@@ -21,7 +21,7 @@ IMPORTANT NOTE: All the commands in this page assumes you have loaded the [dev_s
 ## Manual generation
 
 If the automation is not doing its job to create an auto PR, Python has a SwaggerToSdk CLI that can be used to generate a specific Readme. You need
-a virtual environment loaded with at least `tools/azure-sdk-tools` installed.
+a virtual environment loaded with at least `eng/tools/azure-sdk-tools` installed.
 
 ```shell
 # Using default configuration (this can be a Github raw link)

doc/dev/mgmt/tests.md

@@ -81,7 +81,7 @@ credentials = ClientSecretCredential(
     tenant = os.environ['AZURE_TENANT_ID']
 )
 ```
-Or you can use `DefaultAzureCredential`, which we prefer. 
+Or you can use `DefaultAzureCredential`, which we prefer.
 You can test with this code:
 ```python
 import os
@@ -92,7 +92,7 @@ credentials = DefaultAzureCredential()
 
 ## Providing credentials to the tests
 
-When you run tests in playback mode, they use a fake credentials file, located at [`tools/azure-sdk-tools/devtools_testutils/mgmt_settings_fake.py`][mgmt_settings_fake], to simulate authenticating with Azure. In most scenarios you will not have to adjust this file, you will have to make edits to this file if your service uses values that are not already included in the `mgmt_settings_fake.py` file.
+When you run tests in playback mode, they use a fake credentials file, located at [`eng/tools/azure-sdk-tools/devtools_testutils/mgmt_settings_fake.py`][mgmt_settings_fake], to simulate authenticating with Azure. In most scenarios you will not have to adjust this file, you will have to make edits to this file if your service uses values that are not already included in the `mgmt_settings_fake.py` file.
 
 In live mode, you need to use real credentials like those you obtained in the previous section. To enable the tests to use them, make a copy of the `mgmt_settings_fake.py` file in the same location, and rename it `mgmt_settings_real.py`.
 Then make the following changes:
@@ -123,7 +123,7 @@ These two methods are used by the authentication methods within `AzureTestCase`
 
 To configure the tests to run in live mode, you have two options:
 * Set the environment variable `AZURE_TEST_RUN_LIVE` to "true" or "yes".
-* Create the `tools/azure-sdk-tools/devtools_testutils/testsettings_local.cfg` file and copy and paste the following line:
+* Create the `eng/tools/azure-sdk-tools/devtools_testutils/testsettings_local.cfg` file and copy and paste the following line:
     ```
     live-mode: true
     ```
@@ -134,7 +134,7 @@ Now you can run tests using the same method described in [Running the tests](#ru
 ## Running tests in playback mode
 Now that the tests have been run against live resources and generated the HTTP recordings, you can run your tests in playback mode. There are two options for changing from live mode to playback mode:
 * Set the environment variable `AZURE_TEST_RUN_LIVE` to "false" or "no".
-* Change the `tools/azure-sdk-tools/devtools_testutils/testsettings_local.cfg` file to:
+* Change the `eng/tools/azure-sdk-tools/devtools_testutils/testsettings_local.cfg` file to:
     ```
     live-mode: false
     ```
@@ -158,7 +158,7 @@ For more information about legacy tests, see [Legacy tests](https://github.com/A
 
 Management plane SDKs are those that are formatted `azure-mgmt-xxxx`, otherwise the SDK is data plane. Management plane SDKs work against the [Azure Resource Manager APIs][arm_apis], while the data plane SDKs will work against service APIs. This section will demonstrate writing tests using `devtools_testutils` with a few increasingly sophisticated examples to show how to use some of the features of the underlying test frameworks.
 
-### Tips: 
+### Tips:
 After the migration of the test proxy, `conftests.py` needs to be configured under the tests folder.<br/>
 * For a sample about `conftest.py`, see [conftest.py](https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/advisor/azure-mgmt-advisor/tests/conftest.py). <br/>
 * For more information about test proxy, see [TestProxy][testproxy].
@@ -174,7 +174,7 @@ AZURE_LOCATION = 'eastus'
 class TestExampleResourceGroup(AzureMgmtRecordedTestCase):
     def setup_method(self, method):
         self.client = self.create_mgmt_client(ResourceManagementClient)
-    
+
     @recorded_by_proxy
     def test_create_resource_group(self):
         test_group_name = self.get_resource_name('testgroup')
@@ -351,11 +351,11 @@ class TestMgmtSearch(AzureMgmtRecordedTestCase):
 
 <!-- LINKS -->
 [arm_apis]: https://docs.microsoft.com/rest/api/resources/
-[azure_sdk_tools]: https://github.com/Azure/azure-sdk-for-python/tree/main/tools/azure-sdk-tools
+[azure_sdk_tools]: https://github.com/Azure/azure-sdk-for-python/tree/main/eng/tools/azure-sdk-tools
 [azure_portal]: https://portal.azure.com/
 [decorators]: https://www.python.org/dev/peps/pep-0318/
 [dev_setup]: https://github.com/Azure/azure-sdk-for-python/blob/main/doc/dev/dev_setup.md
-[devtools_testutils]: https://github.com/Azure/azure-sdk-for-python/tree/main/tools/azure-sdk-tools/devtools_testutils
-[mgmt_settings_fake]: https://github.com/Azure/azure-sdk-for-python/blob/main/tools/azure-sdk-tools/devtools_testutils/mgmt_settings_fake.py
+[devtools_testutils]: https://github.com/Azure/azure-sdk-for-python/tree/main/eng/tools/azure-sdk-tools/devtools_testutils
+[mgmt_settings_fake]: https://github.com/Azure/azure-sdk-for-python/blob/main/eng/tools/azure-sdk-tools/devtools_testutils/mgmt_settings_fake.py
 [testproxy]: https://github.com/Azure/azure-sdk-for-python/blob/main/doc/dev/tests.md#write-or-run-tests
 [pytest]: https://docs.pytest.org/en/latest/

doc/dev/perfstress_tests.md

@@ -19,12 +19,12 @@
 # The perfstress framework
 
 The perfstress framework has been added to the `devtools_testutils` package. The code can be found
-[here](https://github.com/Azure/azure-sdk-for-python/tree/main/tools/azure-sdk-tools/devtools_testutils/perfstress_tests).
+[here](https://github.com/Azure/azure-sdk-for-python/tree/main/eng/tools/azure-sdk-tools/devtools_testutils/perfstress_tests).
 The framework provides a baseclass to inherit from when writing tests, as well as some tools and utilities to
 facilitate running the tests. To start using the framework, make sure that `azure-sdk-tools` (which contains
 `devtools_testutils`) is included in the `dev_requirements.txt` for the SDK:
 ```
--e ../../../tools/azure-sdk-tools
+-e ../../../eng/tools/azure-sdk-tools
 ```
 The perfstress framework offers the following:
 - The `perfstress` commandline tool.

doc/dev/test_proxy_troubleshooting.md

@@ -105,7 +105,7 @@ client to the test.
 
 Test suites that haven't fully migrated to using a `test-resources.json` file for test resource deployment might use
 resource preparers, such as
-[ResourceGroupPreparer](https://github.com/Azure/azure-sdk-for-python/blob/main/tools/azure-sdk-tools/devtools_testutils/resource_testcase.py).
+[ResourceGroupPreparer](https://github.com/Azure/azure-sdk-for-python/blob/main/eng/tools/azure-sdk-tools/devtools_testutils/resource_testcase.py).
 Resource preparers need a management client to function, so test classes that use them will need to inherit from
 [AzureMgmtRecordedTestCase][mgmt_recorded_test_case] instead of AzureRecordedTestCase.
 
@@ -369,20 +369,20 @@ Alternatively, you can delete the installed tool and re-run your tests to automa
 
 <!-- Links -->
 
-[custom_default_matcher]: https://github.com/Azure/azure-sdk-for-python/blob/497f5f3435162c4f2086d1429fc1bba4f31a4354/tools/azure-sdk-tools/devtools_testutils/sanitizers.py#L85
+[custom_default_matcher]: https://github.com/Azure/azure-sdk-for-python/blob/497f5f3435162c4f2086d1429fc1bba4f31a4354/eng/tools/azure-sdk-tools/devtools_testutils/sanitizers.py#L85
 [detailed_docs]: https://github.com/Azure/azure-sdk-tools/tree/main/tools/test-proxy/Azure.Sdk.Tools.TestProxy/README.md
-[env_var_loader]: https://github.com/Azure/azure-sdk-for-python/blob/main/tools/azure-sdk-tools/devtools_testutils/envvariable_loader.py
+[env_var_loader]: https://github.com/Azure/azure-sdk-for-python/blob/main/eng/tools/azure-sdk-tools/devtools_testutils/envvariable_loader.py
 [gitattributes]: https://git-scm.com/docs/gitattributes
-[mgmt_recorded_test_case]: https://github.com/Azure/azure-sdk-for-python/blob/main/tools/azure-sdk-tools/devtools_testutils/mgmt_recorded_testcase.py
+[mgmt_recorded_test_case]: https://github.com/Azure/azure-sdk-for-python/blob/main/eng/tools/azure-sdk-tools/devtools_testutils/mgmt_recorded_testcase.py
 [parametrize]: https://docs.pytest.org/latest/example/parametrize.html
 [parametrize_class]: https://github.com/Azure/azure-sdk-for-python/blob/aa607b3b8c3e646928375ebcc6339d68e4e90a49/sdk/keyvault/azure-keyvault-keys/tests/_test_case.py#L61
 [parametrize_example]: https://github.com/Azure/azure-sdk-for-python/blob/aa607b3b8c3e646928375ebcc6339d68e4e90a49/sdk/keyvault/azure-keyvault-keys/tests/test_key_client.py#L190
 [pipelines_ci]: https://github.com/Azure/azure-sdk-for-python/blob/5ba894966ed6b0e1ee8d854871f8c2da36a73d79/sdk/eventgrid/ci.yml#L30
 [pipelines_live]: https://github.com/Azure/azure-sdk-for-python/blob/e2b5852deaef04752c1323d2ab0958f83b98858f/sdk/textanalytics/tests.yml#L26-L27
-[playback_request_failure]: https://github.com/Azure/azure-sdk-for-python/blob/e23d9a6b1edcc1127ded40b9993029495b4ad08c/tools/azure-sdk-tools/devtools_testutils/proxy_testcase.py#L108
-[py_sanitizers]: https://github.com/Azure/azure-sdk-for-python/blob/main/tools/azure-sdk-tools/devtools_testutils/sanitizers.py
+[playback_request_failure]: https://github.com/Azure/azure-sdk-for-python/blob/e23d9a6b1edcc1127ded40b9993029495b4ad08c/eng/tools/azure-sdk-tools/devtools_testutils/proxy_testcase.py#L108
+[py_sanitizers]: https://github.com/Azure/azure-sdk-for-python/blob/main/eng/tools/azure-sdk-tools/devtools_testutils/sanitizers.py
 [pytest_collection]: https://docs.pytest.org/latest/goodpractices.html#test-discovery
 [pytest_commands]: https://docs.pytest.org/latest/usage.html
-[record_request_failure]: https://github.com/Azure/azure-sdk-for-python/blob/e23d9a6b1edcc1127ded40b9993029495b4ad08c/tools/azure-sdk-tools/devtools_testutils/proxy_testcase.py#L97
+[record_request_failure]: https://github.com/Azure/azure-sdk-for-python/blob/e23d9a6b1edcc1127ded40b9993029495b4ad08c/eng/tools/azure-sdk-tools/devtools_testutils/proxy_testcase.py#L97
 [test_proxy_sanitizers]: https://github.com/Azure/azure-sdk-tools/blob/57382d5dc00b10a2f9cfd597293eeee0c2dbd8fd/tools/test-proxy/Azure.Sdk.Tools.TestProxy/Common/SanitizerDictionary.cs#L65
 [wrong_exception]: https://github.com/Azure/azure-sdk-tools/issues/2907

doc/dev/tests.md

@@ -160,7 +160,7 @@ resources, and sanitizing credentials in recordings.
 
 The `devtools_testutils` package also has other classes and functions to provide test utility, which are documented in
 the
-[package README](https://github.com/Azure/azure-sdk-for-python/blob/main/tools/azure-sdk-tools/devtools_testutils/README.md).
+[package README](https://github.com/Azure/azure-sdk-for-python/blob/main/eng/tools/azure-sdk-tools/devtools_testutils/README.md).
 
 ## Write or run tests
 
@@ -578,19 +578,19 @@ For information about more advanced testing scenarios, refer to the [advanced te
 [advanced_tests_notes]: https://github.com/Azure/azure-sdk-for-python/blob/main/doc/dev/tests-advanced.md
 [azure_cli_service_principal]: https://docs.microsoft.com/cli/azure/ad/sp?view=azure-cli-latest#az-ad-sp-create-for-rbac
 [azure_portal]: https://portal.azure.com/
-[azure_recorded_test_case]: https://github.com/Azure/azure-sdk-for-python/blob/7e66e3877519a15c1d4304eb69abf0a2281773/tools/azure-sdk-tools/devtools_testutils/azure_recorded_testcase.py#L44
+[azure_recorded_test_case]: https://github.com/Azure/azure-sdk-for-python/blob/7e66e3877519a15c1d4304eb69abf0a2281773/eng/tools/azure-sdk-tools/devtools_testutils/azure_recorded_testcase.py#L44
 [central_conftest]: https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/conftest.py
-[env_var_docs]: https://github.com/Azure/azure-sdk-for-python/tree/main/tools/azure-sdk-tools/devtools_testutils#use-the-environmentvariableloader
-[env_var_loader]: https://github.com/Azure/azure-sdk-for-python/blob/main/tools/azure-sdk-tools/devtools_testutils/envvariable_loader.py
-[get_credential]: https://github.com/Azure/azure-sdk-for-python/blob/20cf5b0bd9b87f90bd5ad4fd36358d3b257f95c5/tools/azure-sdk-tools/devtools_testutils/azure_recorded_testcase.py#L96
+[env_var_docs]: https://github.com/Azure/azure-sdk-for-python/tree/main/eng/tools/azure-sdk-tools/devtools_testutils#use-the-environmentvariableloader
+[env_var_loader]: https://github.com/Azure/azure-sdk-for-python/blob/main/eng/tools/azure-sdk-tools/devtools_testutils/envvariable_loader.py
+[get_credential]: https://github.com/Azure/azure-sdk-for-python/blob/20cf5b0bd9b87f90bd5ad4fd36358d3b257f95c5/eng/tools/azure-sdk-tools/devtools_testutils/azure_recorded_testcase.py#L96
 [git_setup]: https://git-scm.com/book/en/v2/Getting-Started-First-Time-Git-Setup
 [kv_test_resources]: https://github.com/Azure/azure-sdk-for-python/blob/fbdb860630bcc13c1e355828231161849a9bd5a4/sdk/keyvault/test-resources.json
 [kv_test_resources_outputs]: https://github.com/Azure/azure-sdk-for-python/blob/fbdb860630bcc13c1e355828231161849a9bd5a4/sdk/keyvault/test-resources.json#L255
 [kv_test_resources_resources]: https://github.com/Azure/azure-sdk-for-python/blob/fbdb860630bcc13c1e355828231161849a9bd5a4/sdk/keyvault/test-resources.json#L116
 [manage_recordings]: https://github.com/Azure/azure-sdk-for-python/blob/main/scripts/manage_recordings.py
 [packaging]: https://github.com/Azure/azure-sdk-for-python/blob/main/doc/dev/packaging.md
 [proxy_general_docs]: https://github.com/Azure/azure-sdk-tools/blob/main/tools/test-proxy/Azure.Sdk.Tools.TestProxy/README.md
-[py_sanitizers]: https://github.com/Azure/azure-sdk-for-python/blob/main/tools/azure-sdk-tools/devtools_testutils/sanitizers.py
+[py_sanitizers]: https://github.com/Azure/azure-sdk-for-python/blob/main/eng/tools/azure-sdk-tools/devtools_testutils/sanitizers.py
 [pytest_invocation]: https://pytest.org/latest/how-to/usage.html
 [pytest_logging]: https://docs.pytest.org/en/stable/logging.html
 [python-dotenv_readme]: https://github.com/theskumar/python-dotenv

eng/CredScanSuppression.json

@@ -48,8 +48,8 @@
                 "sdk/identity/azure-identity/tests/ec-certificate.pem",
                 "sdk/core/azure-servicemanagement-legacy/tests/legacy_mgmt_settings_fake.py",
                 "sdk/storage/azure-storage-blob/tests/fake_credentials.py",
-                "tools/azure-sdk-tools/devtools_testutils/fake_credentials.py",
-                "tools/azure-sdk-tools/devtools_testutils/mgmt_settings_fake.py"
+                "eng/tools/azure-sdk-tools/devtools_testutils/fake_credentials.py",
+                "eng/tools/azure-sdk-tools/devtools_testutils/mgmt_settings_fake.py"
             ],
             "_justification": "File contains private key used by test code."
         },