Rewrite Ruff Check Without Tox (#43011)

* initial ruff script

* fix logger.error syntax error

* fix import

Author: JennyPng

eng/tools/azure-sdk-tools/azpysdk/black.py

@@ -50,7 +50,7 @@ def run(self, args: argparse.Namespace) -> int:
             try:
                 install_into_venv(executable, [f"black=={BLACK_VERSION}"], package_dir)
             except CalledProcessError as e:
-                logger.error("Failed to install black:", e)
+                logger.error(f"Failed to install black: {e}")
                 return e.returncode
 
             logger.info(f"Running black against {package_name}")

eng/tools/azure-sdk-tools/azpysdk/main.py

@@ -18,6 +18,7 @@
 from .pylint import pylint
 from .sphinx import sphinx
 from .black import black
+from .ruff import ruff
 
 from ci_tools.logging import configure_logging, logger
 
@@ -78,6 +79,7 @@ def build_parser() -> argparse.ArgumentParser:
     pylint().register(subparsers, [common])
     sphinx().register(subparsers, [common])
     black().register(subparsers, [common])
+    ruff().register(subparsers, [common])
 
     return parser
 

eng/tools/azure-sdk-tools/azpysdk/mypy.py

@@ -68,7 +68,7 @@ def run(self, args: argparse.Namespace) -> int:
                 else:
                     install_into_venv(executable, [f"mypy=={MYPY_VERSION}"] + additional_requirements, package_dir)
             except CalledProcessError as e:
-                logger.error("Failed to install mypy:", e)
+                logger.error(f"Failed to install mypy: {e}")
                 return e.returncode
 
             logger.info(f"Running mypy against {package_name}")

eng/tools/azure-sdk-tools/azpysdk/pylint.py

@@ -51,7 +51,7 @@ def run(self, args: argparse.Namespace) -> int:
             try:
                 install_into_venv(executable, ["azure-pylint-guidelines-checker==0.5.6", "--index-url=https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-python/pypi/simple/"], package_dir)
             except CalledProcessError as e:
-                logger.error("Failed to install dependencies:", e)
+                logger.error(f"Failed to install dependencies: {e}")
                 return e.returncode
 
             # install pylint
@@ -62,7 +62,7 @@ def run(self, args: argparse.Namespace) -> int:
                 else:
                     install_into_venv(executable, [f"pylint=={PYLINT_VERSION}"], package_dir)
             except CalledProcessError as e:
-                logger.error("Failed to install pylint:", e)
+                logger.error(f"Failed to install pylint: {e}")
                 return e.returncode
 
             top_level_module = parsed.namespace.split(".")[0]

eng/tools/azure-sdk-tools/azpysdk/ruff.py

@@ -0,0 +1,61 @@
+import argparse
+import os
+import sys
+import subprocess
+from typing import Optional, List
+
+from .Check import Check
+from ci_tools.functions import install_into_venv
+from ci_tools.variables import set_envvar_defaults
+from ci_tools.logging import logger
+
+class ruff(Check):
+    def __init__(self) -> None:
+        super().__init__()
+
+    def register(self, subparsers: "argparse._SubParsersAction", parent_parsers: Optional[List[argparse.ArgumentParser]] = None) -> None:
+        """Register the ruff check. The ruff check installs ruff and runs ruff against the target package.
+        """
+        parents = parent_parsers or []
+        p = subparsers.add_parser("ruff", parents=parents, help="Run the ruff check")
+        p.set_defaults(func=self.run)
+
+    def run(self, args: argparse.Namespace) -> int:
+        """Run the ruff check command."""
+        logger.info("Running ruff check...")
+
+        set_envvar_defaults()
+        targeted = self.get_targeted_directories(args)
+
+        results: List[int] = []
+
+        for parsed in targeted:
+            package_dir = parsed.folder
+            package_name = parsed.name
+            executable, staging_directory = self.get_executable(args.isolate, args.command, sys.executable, package_dir)
+            logger.info(f"Processing {package_name} for ruff check")
+
+            self.install_dev_reqs(executable, args, package_dir)
+
+            try:
+                install_into_venv(executable, ["ruff"], package_dir)
+            except subprocess.CalledProcessError as e:
+                logger.error(f"Failed to install ruff: {e}")
+                return e.returncode
+
+            top_level_module = parsed.namespace.split(".")[0]
+
+            try:
+                subprocess.check_call(
+                [
+                    executable,
+                    "-m",
+                    "ruff",
+                    "check",
+                    os.path.join(package_dir, top_level_module),
+                ]) 
+            except subprocess.CalledProcessError as e:
+                logger.error(f"ruff check failed for {package_name}: {e}")
+                results.append(e.returncode)
+
+        return max(results) if results else 0

eng/tools/azure-sdk-tools/azpysdk/sphinx.py

@@ -294,7 +294,7 @@ def run(self, args: argparse.Namespace) -> int:
                         package_dir
                     )
             except CalledProcessError as e:
-                logger.error("Failed to install sphinx:", e)
+                logger.error(f"Failed to install sphinx: {e}")
                 return e.returncode
 
             logger.info(f"Running sphinx against {package_name}")