Unexclude _telemetry folder (#34012)

* unexclude _telemetry folder

* fix activity.py

* fix activity.py - 2

Author: CoderKevinZhang

sdk/ml/azure-ai-ml/azure/ai/ml/_telemetry/_customtraceback.py

@@ -10,7 +10,7 @@
 import sys
 import traceback
 import types
-from typing import Iterable, List, Optional, Type
+from typing import Any, Generator, List, Optional, Type
 
 
 class _CustomStackSummary(traceback.StackSummary):
@@ -86,7 +86,7 @@ def __init__(
         self.exc_type = exc_type
         # Capture now to permit freeing resources: only complication is in the
         # unofficial API _format_final_exc_line
-        self._str = traceback._some_str(exc_value)
+        self._str = traceback._some_str(exc_value)  # pylint: disable=no-member
         if exc_type and issubclass(exc_type, SyntaxError):
             # Handle SyntaxError's specially
             self.filename = exc_value.filename
@@ -97,7 +97,7 @@ def __init__(
         if lookup_lines:
             self._load_lines()
 
-    def format_exception_only(self) -> Iterable[str]:
+    def format_exception_only(self) -> Generator:
         """Format the exception part of the traceback.
 
         :return: An iterable of strings, each ending in a newline. Normally, the generator emits a single
@@ -116,7 +116,7 @@ def format_exception_only(self) -> Iterable[str]:
             stype = smod + "." + stype
 
         if not issubclass(self.exc_type, SyntaxError):
-            yield traceback._format_final_exc_line(stype, self._str)
+            yield traceback._format_final_exc_line(stype, self._str)  # type: ignore[attr-defined]
             return
 
         # It was a syntax error; show exactly where the problem was found.
@@ -129,7 +129,7 @@ def format_exception_only(self) -> Iterable[str]:
         if badline is not None:
             yield "    {}\n".format(badline.strip())
             if offset is not None:
-                caretspace = badline.rstrip("\n")
+                caretspace: Any = badline.rstrip("\n")
                 offset = min(len(caretspace), offset) - 1
                 caretspace = caretspace[:offset].lstrip()
                 # non-space whitespace (likes tabs) must be kept for alignment
@@ -149,7 +149,7 @@ def format_exc(limit: Optional[int] = None, chain: bool = True) -> str:
     :return: The formatted exception string
     :rtype: str
     """
-    return "".join(format_exception(*sys.exc_info(), limit=limit, chain=chain))
+    return "".join(format_exception(*sys.exc_info(), limit=limit, chain=chain))  # type: ignore[misc]
 
 
 def format_exception(  # pylint: disable=unused-argument

sdk/ml/azure-ai-ml/azure/ai/ml/_telemetry/activity.py

@@ -18,7 +18,7 @@
 import os
 import uuid
 from datetime import datetime
-from typing import Dict, Iterable, Tuple
+from typing import Any, Dict, Tuple
 from uuid import uuid4
 
 from marshmallow import ValidationError
@@ -68,7 +68,7 @@ def __init__(self, logger: logging.Logger, activity_info: str):
         :type activity_info: str
         """
         self._activity_info = activity_info
-        super(ActivityLoggerAdapter, self).__init__(logger, None)
+        super(ActivityLoggerAdapter, self).__init__(logger, None)  # type: ignore[arg-type]
 
     @property
     def activity_info(self) -> str:
@@ -79,7 +79,7 @@ def activity_info(self) -> str:
         """
         return self._activity_info
 
-    def process(self, msg: str, kwargs: Dict) -> Tuple[str, Dict]:
+    def process(self, msg: str, kwargs: Dict) -> Tuple[str, Dict]:  # type: ignore[override]
         """Process the log message.
 
         :param msg: The log message.
@@ -158,7 +158,7 @@ def log_activity(
     activity_name,
     activity_type=ActivityType.INTERNALCALL,
     custom_dimensions=None,
-) -> Iterable[ActivityLoggerAdapter]:
+) -> Any:
     """Log an activity.
 
     An activity is a logical block of code that consumers want to monitor.
@@ -190,7 +190,7 @@ def log_activity(
     completion_status = ActivityCompletionStatus.SUCCESS
 
     message = "ActivityStarted, {}".format(activity_name)
-    activityLogger = ActivityLoggerAdapter(logger, activity_info)
+    activityLogger = ActivityLoggerAdapter(logger, activity_info)  # type: ignore[arg-type]
     activityLogger.info(message)
     exception = None
 
@@ -207,7 +207,8 @@ def log_activity(
                 in [ErrorCategory.SYSTEM_ERROR, ErrorCategory.UNKNOWN]
             ) or (
                 "errorCategory" in activityLogger.activity_info
-                and activityLogger.activity_info["errorCategory"] in [ErrorCategory.SYSTEM_ERROR, ErrorCategory.UNKNOWN]
+                and activityLogger.activity_info["errorCategory"]  # type: ignore[index]
+                in [ErrorCategory.SYSTEM_ERROR, ErrorCategory.UNKNOWN]
             ):
                 raise Exception("Got InternalSDKError", e) from e
             raise
@@ -217,25 +218,28 @@ def log_activity(
             end_time = datetime.utcnow()
             duration_ms = round((end_time - start_time).total_seconds() * 1000, 2)
 
-            activityLogger.activity_info["completionStatus"] = completion_status
-            activityLogger.activity_info["durationMs"] = duration_ms
+            activityLogger.activity_info["completionStatus"] = completion_status  # type: ignore[index]
+            activityLogger.activity_info["durationMs"] = duration_ms  # type: ignore[index]
             message = "ActivityCompleted: Activity={}, HowEnded={}, Duration={} [ms]".format(
                 activity_name, completion_status, duration_ms
             )
             if exception:
                 message += ", Exception={}".format(type(exception).__name__)
-                activityLogger.activity_info["exception"] = type(exception).__name__
+                activityLogger.activity_info["exception"] = type(exception).__name__  # type: ignore[index]
                 if isinstance(exception, MlException):
-                    activityLogger.activity_info[
+                    activityLogger.activity_info[  # type: ignore[index]
                         "errorMessage"
                     ] = exception.no_personal_data_message  # pylint: disable=no-member
-                    activityLogger.activity_info["errorTarget"] = exception.target  # pylint: disable=no-member
-                    activityLogger.activity_info[
+                    # pylint: disable=no-member
+                    activityLogger.activity_info["errorTarget"] = exception.target  # type: ignore[index]
+                    activityLogger.activity_info[  # type: ignore[index]
                         "errorCategory"
                     ] = exception.error_category  # pylint: disable=no-member
                     if exception.inner_exception:  # pylint: disable=no-member
                         # pylint: disable=no-member
-                        activityLogger.activity_info["innerException"] = type(exception.inner_exception).__name__
+                        activityLogger.activity_info["innerException"] = type(  # type: ignore[index]
+                            exception.inner_exception
+                        ).__name__
                 activityLogger.error(message)
             else:
                 activityLogger.info(message)

sdk/ml/azure-ai-ml/azure/ai/ml/_telemetry/logging_handler.py

@@ -41,7 +41,7 @@ class CustomDimensionsFilter(logging.Filter):
     def __init__(self, custom_dimensions=None):  # pylint: disable=super-init-not-called
         self.custom_dimensions = custom_dimensions or {}
 
-    def filter(self, record: dict) -> bool:
+    def filter(self, record: dict) -> bool:  # type: ignore[override]
         """Adds the default custom_dimensions into the current log record. Does not
         otherwise filter any records
 
@@ -53,7 +53,7 @@ def filter(self, record: dict) -> bool:
 
         custom_dimensions = self.custom_dimensions.copy()
         custom_dimensions.update(getattr(record, "custom_dimensions", {}))
-        record.custom_dimensions = custom_dimensions
+        record.custom_dimensions = custom_dimensions  # type: ignore[attr-defined]
 
         return True
 

sdk/ml/azure-ai-ml/pyproject.toml

@@ -33,7 +33,6 @@ exclude = [
   "azure/ai/ml/_file_utils/",
   "azure/ai/ml/_local_endpoints/",
   "azure/ai/ml/_logging/",
-  "azure/ai/ml/_telemetry/",
   "azure/ai/ml/_utils",
   "azure/ai/ml/data_transfer/",
   "azure/ai/ml/parallel/",