[Storage] Adjust default connection_data_block_size for all Storage packages (#44332)

Author: jalauzon-msft

sdk/storage/azure-storage-blob/azure/storage/blob/_shared/base_client.py

@@ -35,7 +35,14 @@
 )
 
 from .authentication import SharedKeyCredentialPolicy
-from .constants import CONNECTION_TIMEOUT, DEFAULT_OAUTH_SCOPE, READ_TIMEOUT, SERVICE_HOST_BASE, STORAGE_OAUTH_SCOPE
+from .constants import (
+    CONNECTION_TIMEOUT,
+    DATA_BLOCK_SIZE,
+    DEFAULT_OAUTH_SCOPE,
+    READ_TIMEOUT,
+    SERVICE_HOST_BASE,
+    STORAGE_OAUTH_SCOPE,
+)
 from .models import LocationMode, StorageConfiguration
 from .parser import DEVSTORE_ACCOUNT_KEY, _get_development_storage_endpoint
 from .policies import (
@@ -268,6 +275,7 @@ def _create_pipeline(
         transport = kwargs.get("transport")
         kwargs.setdefault("connection_timeout", CONNECTION_TIMEOUT)
         kwargs.setdefault("read_timeout", READ_TIMEOUT)
+        kwargs.setdefault("connection_data_block_size", DATA_BLOCK_SIZE)
         if not transport:
             transport = RequestsTransport(**kwargs)
         policies = [

sdk/storage/azure-storage-blob/azure/storage/blob/_shared/base_client_async.py

@@ -24,7 +24,14 @@
 
 from .authentication import SharedKeyCredentialPolicy
 from .base_client import create_configuration
-from .constants import CONNECTION_TIMEOUT, DEFAULT_OAUTH_SCOPE, READ_TIMEOUT, SERVICE_HOST_BASE, STORAGE_OAUTH_SCOPE
+from .constants import (
+    CONNECTION_TIMEOUT,
+    DATA_BLOCK_SIZE,
+    DEFAULT_OAUTH_SCOPE,
+    READ_TIMEOUT,
+    SERVICE_HOST_BASE,
+    STORAGE_OAUTH_SCOPE,
+)
 from .models import StorageConfiguration
 from .parser import DEVSTORE_ACCOUNT_KEY, _get_development_storage_endpoint
 from .policies import (
@@ -109,6 +116,7 @@ def _create_pipeline(
         transport = kwargs.get("transport")
         kwargs.setdefault("connection_timeout", CONNECTION_TIMEOUT)
         kwargs.setdefault("read_timeout", READ_TIMEOUT)
+        kwargs.setdefault("connection_data_block_size", DATA_BLOCK_SIZE)
         if not transport:
             try:
                 from azure.core.pipeline.transport import (  # pylint: disable=non-abstract-transport-import

sdk/storage/azure-storage-blob/azure/storage/blob/_shared/constants.py

@@ -9,9 +9,10 @@
 
 X_MS_VERSION = _SUPPORTED_API_VERSIONS[-1]
 
-# Default socket timeouts, in seconds
+# Connection defaults
 CONNECTION_TIMEOUT = 20
 READ_TIMEOUT = 60
+DATA_BLOCK_SIZE = 256 * 1024
 
 DEFAULT_OAUTH_SCOPE = "/.default"
 STORAGE_OAUTH_SCOPE = "https://storage.azure.com/.default"

sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_shared/base_client.py

@@ -35,7 +35,14 @@
 )
 
 from .authentication import SharedKeyCredentialPolicy
-from .constants import CONNECTION_TIMEOUT, DEFAULT_OAUTH_SCOPE, READ_TIMEOUT, SERVICE_HOST_BASE, STORAGE_OAUTH_SCOPE
+from .constants import (
+    CONNECTION_TIMEOUT,
+    DATA_BLOCK_SIZE,
+    DEFAULT_OAUTH_SCOPE,
+    READ_TIMEOUT,
+    SERVICE_HOST_BASE,
+    STORAGE_OAUTH_SCOPE,
+)
 from .models import LocationMode, StorageConfiguration
 from .parser import DEVSTORE_ACCOUNT_KEY, _get_development_storage_endpoint
 from .policies import (
@@ -268,6 +275,7 @@ def _create_pipeline(
         transport = kwargs.get("transport")
         kwargs.setdefault("connection_timeout", CONNECTION_TIMEOUT)
         kwargs.setdefault("read_timeout", READ_TIMEOUT)
+        kwargs.setdefault("connection_data_block_size", DATA_BLOCK_SIZE)
         if not transport:
             transport = RequestsTransport(**kwargs)
         policies = [

sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_shared/base_client_async.py

@@ -24,7 +24,14 @@
 
 from .authentication import SharedKeyCredentialPolicy
 from .base_client import create_configuration
-from .constants import CONNECTION_TIMEOUT, DEFAULT_OAUTH_SCOPE, READ_TIMEOUT, SERVICE_HOST_BASE, STORAGE_OAUTH_SCOPE
+from .constants import (
+    CONNECTION_TIMEOUT,
+    DATA_BLOCK_SIZE,
+    DEFAULT_OAUTH_SCOPE,
+    READ_TIMEOUT,
+    SERVICE_HOST_BASE,
+    STORAGE_OAUTH_SCOPE,
+)
 from .models import StorageConfiguration
 from .parser import DEVSTORE_ACCOUNT_KEY, _get_development_storage_endpoint
 from .policies import (
@@ -109,6 +116,7 @@ def _create_pipeline(
         transport = kwargs.get("transport")
         kwargs.setdefault("connection_timeout", CONNECTION_TIMEOUT)
         kwargs.setdefault("read_timeout", READ_TIMEOUT)
+        kwargs.setdefault("connection_data_block_size", DATA_BLOCK_SIZE)
         if not transport:
             try:
                 from azure.core.pipeline.transport import (  # pylint: disable=non-abstract-transport-import

sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_shared/constants.py

@@ -9,9 +9,10 @@
 
 X_MS_VERSION = _SUPPORTED_API_VERSIONS[-1]
 
-# Default socket timeouts, in seconds
+# Connection defaults
 CONNECTION_TIMEOUT = 20
 READ_TIMEOUT = 60
+DATA_BLOCK_SIZE = 256 * 1024
 
 DEFAULT_OAUTH_SCOPE = "/.default"
 STORAGE_OAUTH_SCOPE = "https://storage.azure.com/.default"

sdk/storage/azure-storage-file-share/azure/storage/fileshare/_shared/base_client.py

@@ -35,7 +35,14 @@
 )
 
 from .authentication import SharedKeyCredentialPolicy
-from .constants import CONNECTION_TIMEOUT, DEFAULT_OAUTH_SCOPE, READ_TIMEOUT, SERVICE_HOST_BASE, STORAGE_OAUTH_SCOPE
+from .constants import (
+    CONNECTION_TIMEOUT,
+    DATA_BLOCK_SIZE,
+    DEFAULT_OAUTH_SCOPE,
+    READ_TIMEOUT,
+    SERVICE_HOST_BASE,
+    STORAGE_OAUTH_SCOPE,
+)
 from .models import LocationMode, StorageConfiguration
 from .parser import DEVSTORE_ACCOUNT_KEY, _get_development_storage_endpoint
 from .policies import (
@@ -268,6 +275,7 @@ def _create_pipeline(
         transport = kwargs.get("transport")
         kwargs.setdefault("connection_timeout", CONNECTION_TIMEOUT)
         kwargs.setdefault("read_timeout", READ_TIMEOUT)
+        kwargs.setdefault("connection_data_block_size", DATA_BLOCK_SIZE)
         if not transport:
             transport = RequestsTransport(**kwargs)
         policies = [

sdk/storage/azure-storage-file-share/azure/storage/fileshare/_shared/base_client_async.py

@@ -24,7 +24,14 @@
 
 from .authentication import SharedKeyCredentialPolicy
 from .base_client import create_configuration
-from .constants import CONNECTION_TIMEOUT, DEFAULT_OAUTH_SCOPE, READ_TIMEOUT, SERVICE_HOST_BASE, STORAGE_OAUTH_SCOPE
+from .constants import (
+    CONNECTION_TIMEOUT,
+    DATA_BLOCK_SIZE,
+    DEFAULT_OAUTH_SCOPE,
+    READ_TIMEOUT,
+    SERVICE_HOST_BASE,
+    STORAGE_OAUTH_SCOPE,
+)
 from .models import StorageConfiguration
 from .parser import DEVSTORE_ACCOUNT_KEY, _get_development_storage_endpoint
 from .policies import (
@@ -109,6 +116,7 @@ def _create_pipeline(
         transport = kwargs.get("transport")
         kwargs.setdefault("connection_timeout", CONNECTION_TIMEOUT)
         kwargs.setdefault("read_timeout", READ_TIMEOUT)
+        kwargs.setdefault("connection_data_block_size", DATA_BLOCK_SIZE)
         if not transport:
             try:
                 from azure.core.pipeline.transport import (  # pylint: disable=non-abstract-transport-import

sdk/storage/azure-storage-file-share/azure/storage/fileshare/_shared/constants.py

@@ -9,9 +9,10 @@
 
 X_MS_VERSION = _SUPPORTED_API_VERSIONS[-1]
 
-# Default socket timeouts, in seconds
+# Connection defaults
 CONNECTION_TIMEOUT = 20
 READ_TIMEOUT = 60
+DATA_BLOCK_SIZE = 256 * 1024
 
 DEFAULT_OAUTH_SCOPE = "/.default"
 STORAGE_OAUTH_SCOPE = "https://storage.azure.com/.default"

sdk/storage/azure-storage-queue/azure/storage/queue/_shared/base_client.py

@@ -35,7 +35,14 @@
 )
 
 from .authentication import SharedKeyCredentialPolicy
-from .constants import CONNECTION_TIMEOUT, DEFAULT_OAUTH_SCOPE, READ_TIMEOUT, SERVICE_HOST_BASE, STORAGE_OAUTH_SCOPE
+from .constants import (
+    CONNECTION_TIMEOUT,
+    DATA_BLOCK_SIZE,
+    DEFAULT_OAUTH_SCOPE,
+    READ_TIMEOUT,
+    SERVICE_HOST_BASE,
+    STORAGE_OAUTH_SCOPE,
+)
 from .models import LocationMode, StorageConfiguration
 from .parser import DEVSTORE_ACCOUNT_KEY, _get_development_storage_endpoint
 from .policies import (
@@ -268,6 +275,7 @@ def _create_pipeline(
         transport = kwargs.get("transport")
         kwargs.setdefault("connection_timeout", CONNECTION_TIMEOUT)
         kwargs.setdefault("read_timeout", READ_TIMEOUT)
+        kwargs.setdefault("connection_data_block_size", DATA_BLOCK_SIZE)
         if not transport:
             transport = RequestsTransport(**kwargs)
         policies = [