Skip to content

Commit 1b66229

Browse files
authored
Log new headers (#37528)
* Log new headers * update
1 parent f7930c8 commit 1b66229

File tree

4 files changed

+7
-0
lines changed

4 files changed

+7
-0
lines changed

.vscode/cspell.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,7 @@
138138
"conda/conda-releaselogs/azure-mgmt.md"
139139
],
140140
"words": [
141+
"msedge",
141142
"spinup",
142143
"cibuildwheel",
143144
"aoai",

sdk/core/azure-core/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010

1111
### Other Changes
1212

13+
- Log "x-vss-e2eid" and "x-msedge-ref" headers in `HttpLoggingPolicy`.
14+
1315
## 1.31.0 (2024-09-12)
1416

1517
### Features Added

sdk/core/azure-core/azure/core/pipeline/policies/_universal.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -417,6 +417,8 @@ class HttpLoggingPolicy(
417417
"Transfer-Encoding",
418418
"User-Agent",
419419
"WWW-Authenticate", # OAuth Challenge header.
420+
"x-vss-e2eid", # Needed by Azure DevOps pipelines.
421+
"x-msedge-ref", # Needed by Azure DevOps pipelines.
420422
]
421423
)
422424
REDACTED_PLACEHOLDER: str = "REDACTED"

sdk/core/azure-core/tests/test_pipeline.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,8 @@ def test_default_http_logging_policy(http_request):
7070
assert http_logging_policy.allowed_header_names == HttpLoggingPolicy.DEFAULT_HEADERS_WHITELIST
7171
assert http_logging_policy.allowed_header_names == HttpLoggingPolicy.DEFAULT_HEADERS_ALLOWLIST
7272
assert "WWW-Authenticate" in http_logging_policy.allowed_header_names
73+
assert "x-vss-e2eid" in http_logging_policy.allowed_header_names
74+
assert "x-msedge-ref" in http_logging_policy.allowed_header_names
7375
# Testing I can replace the set entirely
7476
HttpLoggingPolicy.DEFAULT_HEADERS_ALLOWLIST = set(HttpLoggingPolicy.DEFAULT_HEADERS_ALLOWLIST)
7577
HttpLoggingPolicy.DEFAULT_HEADERS_WHITELIST = set(HttpLoggingPolicy.DEFAULT_HEADERS_ALLOWLIST)

0 commit comments

Comments
 (0)