Remove str from credentials (#42310)

* Remove `mypy=false` and `type_check_samples=false`

* Enhance PhoneNumbersClient with type casting and improve error handling

* Enhance SipRoutingClient with additional type annotations and improve error handling for trunk retrieval

* Refactor environment variable access to use os.environ for consistency across samples

* Fix pylint errors

* Update sdk/communication/azure-communication-phonenumbers/samples/browse_and_reserve_phone_numbers_sample_async.py

Remove redundant initialization

Co-authored-by: Copilot <[email protected]>

* Update sdk/communication/azure-communication-phonenumbers/samples/browse_and_reserve_phone_numbers_sample.py

Co-authored-by: Copilot <[email protected]>

* Update sdk/communication/azure-communication-phonenumbers/samples/browse_and_reserve_numbers_bulk_sample_async.py

Co-authored-by: Copilot <[email protected]>

* Update sdk/communication/azure-communication-phonenumbers/samples/browse_and_reserve_numbers_bulk_sample.py

Co-authored-by: Copilot <[email protected]>

* Update config trunks error message

* Remove string from the credential type

* Fix pylint extra whitespace

---------

Co-authored-by: Copilot <[email protected]>

Author: sofiar-msft

sdk/communication/azure-communication-phonenumbers/azure/communication/phonenumbers/siprouting/_sip_routing_client.py

@@ -29,15 +29,15 @@ class SipRoutingClient(object):
     :param endpoint: The endpoint url for Azure Communication Service resource.
     :type endpoint: str
     :param credential: The credentials with which to authenticate.
-    :type credential: Union[TokenCredential, AzureKeyCredential, str]
+    :type credential: Union[TokenCredential, AzureKeyCredential]
     :keyword api_version: Api Version. Default value is "2021-05-01-preview". Note that overriding
      this default value may result in unsupported behavior.
     :paramtype api_version: str
     """
     def __init__(
         self,
         endpoint: str,
-        credential: Union["TokenCredential", AzureKeyCredential, str],
+        credential: Union["TokenCredential", AzureKeyCredential],
         **kwargs: Any
     ) -> None:
 
@@ -72,8 +72,8 @@ def from_connection_string(
         :returns: The newly created client.
         :rtype: ~azure.communication.siprouting.SipRoutingClient
         """
-        endpoint, credential = parse_connection_str(conn_str)
-        return cls(endpoint, credential, **kwargs)
+        endpoint, access_key = parse_connection_str(conn_str)
+        return cls(endpoint, AzureKeyCredential(access_key), **kwargs)
 
     @distributed_trace
     def get_trunk(

sdk/communication/azure-communication-phonenumbers/azure/communication/phonenumbers/siprouting/aio/_sip_routing_client_async.py

@@ -31,7 +31,7 @@ class SipRoutingClient(object):
     :param endpoint: The endpoint url for Azure Communication Service resource.
     :type endpoint: str
     :param credential: The credentials with which to authenticate.
-    :type credential: Union[AsyncTokenCredential, AzureKeyCredential, str]
+    :type credential: Union[AsyncTokenCredential, AzureKeyCredential]
     :keyword api_version: Api Version. Default value is "2021-05-01-preview". Note that overriding
      this default value may result in unsupported behavior.
     :paramtype api_version: str
@@ -40,7 +40,7 @@ class SipRoutingClient(object):
     def __init__(
         self,
         endpoint: str,
-        credential: Union["AsyncTokenCredential", AzureKeyCredential, str],
+        credential: Union["AsyncTokenCredential", AzureKeyCredential],
         **kwargs: Any
     ) -> None:
 
@@ -77,8 +77,8 @@ def from_connection_string(
         :rtype: ~azure.communication.siprouting.models.SipRoutingClient
         """
 
-        endpoint, credential = parse_connection_str(conn_str)
-        return cls(endpoint, credential, **kwargs)
+        endpoint, access_key = parse_connection_str(conn_str)
+        return cls(endpoint, AzureKeyCredential(access_key), **kwargs)
 
     @distributed_trace_async
     async def get_trunk(