Skip to content

Commit 20f7d18

Browse files
Added back download_blob overloads to fix API Views (#42769)
1 parent d1b981f commit 20f7d18

File tree

2 files changed

+42
-2
lines changed

2 files changed

+42
-2
lines changed

sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client.py

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
from datetime import datetime
1010
from functools import partial
1111
from typing import (
12-
Any, AnyStr, cast, Dict, IO, Iterable, List, Optional, Tuple, Union,
12+
Any, AnyStr, cast, Dict, IO, Iterable, List, Optional, overload, Tuple, Union,
1313
TYPE_CHECKING
1414
)
1515
from typing_extensions import Self
@@ -633,6 +633,26 @@ def upload_blob(
633633
return upload_page_blob(**options)
634634
return upload_append_blob(**options)
635635

636+
@overload
637+
def download_blob(
638+
self, offset: Optional[int] = None,
639+
length: Optional[int] = None,
640+
*,
641+
encoding: str,
642+
**kwargs: Any
643+
) -> StorageStreamDownloader[str]:
644+
...
645+
646+
@overload
647+
def download_blob(
648+
self, offset: Optional[int] = None,
649+
length: Optional[int] = None,
650+
*,
651+
encoding: None = None,
652+
**kwargs: Any
653+
) -> StorageStreamDownloader[bytes]:
654+
...
655+
636656
@distributed_trace
637657
def download_blob(
638658
self, offset: Optional[int] = None,

sdk/storage/azure-storage-blob/azure/storage/blob/aio/_blob_client_async.py

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
from functools import partial
1111
from typing import (
1212
Any, AnyStr, AsyncIterable, Callable, cast, Dict, IO,
13-
Iterable, List, Optional, Tuple, Union,
13+
Iterable, List, Optional, overload, Tuple, Union,
1414
TYPE_CHECKING
1515
)
1616
from typing_extensions import Self
@@ -646,6 +646,26 @@ async def upload_blob(
646646
return cast(Dict[str, Any], await upload_page_blob(**options))
647647
return cast(Dict[str, Any], await upload_append_blob(**options))
648648

649+
@overload
650+
async def download_blob(
651+
self, offset: Optional[int] = None,
652+
length: Optional[int] = None,
653+
*,
654+
encoding: str,
655+
**kwargs: Any
656+
) -> StorageStreamDownloader[str]:
657+
...
658+
659+
@overload
660+
async def download_blob(
661+
self, offset: Optional[int] = None,
662+
length: Optional[int] = None,
663+
*,
664+
encoding: None = None,
665+
**kwargs: Any
666+
) -> StorageStreamDownloader[bytes]:
667+
...
668+
649669
@distributed_trace_async
650670
async def download_blob(
651671
self, offset: Optional[int] = None,

0 commit comments

Comments
 (0)