Addressed azure comments

Author: Vinothini Dharmaraj

sdk/communication/azure-communication-callautomation/azure/communication/callautomation/_generated/models/__init__.py

@@ -121,7 +121,7 @@
 from ._enums import RecordingKind
 from ._enums import RecordingState
 from ._enums import RecordingStorageKind
-from ._enums import TranscriptionResultType
+from ._enums import TranscriptionResultState
 from ._enums import TranscriptionStatus
 from ._enums import TranscriptionStatusDetails
 from ._enums import TranscriptionSubscriptionState
@@ -246,7 +246,7 @@
     "RecordingKind",
     "RecordingState",
     "RecordingStorageKind",
-    "TranscriptionResultType",
+    "TranscriptionResultState",
     "TranscriptionStatus",
     "TranscriptionStatusDetails",
     "TranscriptionSubscriptionState",

sdk/communication/azure-communication-callautomation/azure/communication/callautomation/_generated/models/_enums.py

@@ -208,8 +208,8 @@ class RecordingStorageKind(str, Enum, metaclass=CaseInsensitiveEnumMeta):
     """Storage managed by provided Azure blob"""
 
 
-class TranscriptionResultType(str, Enum, metaclass=CaseInsensitiveEnumMeta):
-    """TranscriptionResultType."""
+class TranscriptionResultState(str, Enum, metaclass=CaseInsensitiveEnumMeta):
+    """TranscriptionResultState."""
 
     FINAL = "final"
     INTERMEDIATE = "intermediate"

sdk/communication/azure-communication-callautomation/azure/communication/callautomation/_generated/models/_models.py

@@ -4580,7 +4580,7 @@ class TranscriptionSubscription(_serialization.Model):
      ~azure.communication.callautomation.models.TranscriptionSubscriptionState
     :ivar subscribed_result_types: Subscribed transcription result types.
     :vartype subscribed_result_types: list[str or
-     ~azure.communication.callautomation.models.TranscriptionResultType]
+     ~azure.communication.callautomation.models.TranscriptionResultState]
     """
 
     _attribute_map = {
@@ -4594,7 +4594,7 @@ def __init__(
         *,
         id: Optional[str] = None,  # pylint: disable=redefined-builtin
         state: Optional[Union[str, "_models.TranscriptionSubscriptionState"]] = None,
-        subscribed_result_types: Optional[List[Union[str, "_models.TranscriptionResultType"]]] = None,
+        subscribed_result_types: Optional[List[Union[str, "_models.TranscriptionResultState"]]] = None,
         **kwargs: Any
     ) -> None:
         """
@@ -4606,7 +4606,7 @@ def __init__(
          ~azure.communication.callautomation.models.TranscriptionSubscriptionState
         :keyword subscribed_result_types: Subscribed transcription result types.
         :paramtype subscribed_result_types: list[str or
-         ~azure.communication.callautomation.models.TranscriptionResultType]
+         ~azure.communication.callautomation.models.TranscriptionResultState]
         """
         super().__init__(**kwargs)
         self.id = id

sdk/communication/azure-communication-callautomation/azure/communication/callautomation/_models.py

@@ -40,7 +40,7 @@
         MediaStreamingAudioChannelType,
         TranscriptionTransportType,
         TranscriptionSubscriptionState,
-        TranscriptionResultType,
+        TranscriptionResultState,
         CallConnectionState,
         RecordingState,
         RecordingKind,
@@ -512,22 +512,22 @@ class TranscriptionSubscription:
      ~azure.communication.callautomation.models.TranscriptionSubscriptionState
     :keyword subscribed_result_types: Subscribed transcription result types.
     :paramtype subscribed_result_types: list[str or
-     ~azure.communication.callautomation.models.TranscriptionResultType]
+     ~azure.communication.callautomation.models.TranscriptionResultState]
     """
 
     id: Optional[str]
     """subscription id."""
     state: Optional[Union[str, 'TranscriptionSubscriptionState']]
     """transcription subscription state."""
-    subscribed_result_types: Optional[List[Union[str, 'TranscriptionResultType']]]
-    """subscribed transcription result types."""
+    subscribed_result_states: Optional[List[Union[str, 'TranscriptionResultState']]]
+    """subscribed transcription result states."""
 
     def __init__(
         self,
         *,
         id: Optional[str] = None,  # pylint: disable=redefined-builtin
         state: Optional[Union[str, "TranscriptionSubscriptionState"]] = None,
-        subscribed_result_types: Optional[List[Union[str, "TranscriptionResultType"]]] = None
+        subscribed_result_states: Optional[List[Union[str, "TranscriptionResultState"]]] = None
     ) -> None:
         """
         :keyword id: Subscription Id.
@@ -536,20 +536,20 @@ def __init__(
         "active".
         :paramtype state: str or
         ~azure.communication.callautomation.models.TranscriptionSubscriptionState
-        :keyword subscribed_result_types: Subscribed transcription result types.
-        :paramtype subscribed_result_types: list[str or
-        ~azure.communication.callautomation.models.TranscriptionResultType]
+        :keyword subscribed_result_states: Subscribed transcription result types.
+        :paramtype subscribed_result_states: list[str or
+        ~azure.communication.callautomation.models.TranscriptionResultState]
         """
 
         self.id = id
         self.state = state
-        self.subscribed_result_types = subscribed_result_types
+        self.subscribed_result_states = subscribed_result_states
 
     def _to_generated(self):
         return TranscriptionSubscriptionInternal(
             id=self.id,
             state=self.state ,
-            subscribed_result_types=self.subscribed_result_types
+            subscribed_result_types=self.subscribed_result_states
         )
 
 class CallConnectionProperties:  # pylint: disable=too-many-instance-attributes
@@ -943,7 +943,7 @@ def _from_generated(cls, cancel_add_participant_operation_result_generated: 'Can
             operation_context=cancel_add_participant_operation_result_generated.operation_context
         )
 
-class ResultStatus(Enum):
+class ResultState(Enum):
     """
     The status of the result of transcription.
     """
@@ -995,15 +995,21 @@ class TranscriptionMetadata:
     """ Transcription Subscription Id. """
     locale: str
     """ The target locale in which the translated text needs to be. """
-    callConnection_id: str
+    call_connection_id: str
     """ call connection Id. """
     correlation_id: str
     """ correlation Id. """
 
-    def __init__(self, subscription_id: str, locale: str, callConnection_id: str, correlation_id: str):
-        self.subscriptionId = subscription_id
+    def __init__(
+            self,
+            *,
+            subscription_id: str,
+            locale: str,
+            call_connection_id: str,
+            correlation_id: str):
+        self.subscription_id = subscription_id
         self.locale = locale
-        self.callConnection_id = callConnection_id
+        self.call_connection_id = call_connection_id
         self.correlation_id = correlation_id
 
 class TranscriptionData:
@@ -1023,8 +1029,9 @@ class TranscriptionData:
     :paramtype words: List[WordData]
     :keyword participant: The identified speaker based on participant raw ID.
     :paramtype participant: CommunicationIdentifier
-    :keyword resultStatus: Status of the result of transcription.
-    :paramtype resultStatus: ResultStatus
+    :keyword result_state: Status of the result of transcription.
+    :paramtype result_state: str or
+     ~azure.communication.callautomation.models.TranscriptionResultState
     """
     text: str
     """ The display form of the recognized word. """
@@ -1040,16 +1047,25 @@ class TranscriptionData:
     """ The result for each word of the phrase. """
     participant: CommunicationIdentifier
     """ The identified speaker based on participant raw ID. """
-    result_status: ResultStatus
-    """ Status of the result of transcription. """
+    result_state: 'TranscriptionResultState'
+    """ State of the result of transcription. """
 
-    def __init__(self, text: str, format: TextFormat, confidence: float, offset: int, duration: int,
-    words: List[WordData], participant: CommunicationIdentifier, result_status: ResultStatus):
+    def __init__(
+            self,
+            *,
+            text: str,
+            format: TextFormat,
+            confidence: float,
+            offset: int,
+            duration: int,
+            words: List[WordData],
+            participant: CommunicationIdentifier,
+            result_state: 'TranscriptionResultState'):
         self.text = text
         self.format = format
         self.confidence = confidence
         self.offset = offset
         self.duration = duration
         self.words = words
         self.participant = participant
-        self.result_status = result_status
+        self.result_state = result_state

sdk/communication/azure-communication-callautomation/azure/communication/callautomation/_streaming_data_parser.py

@@ -31,7 +31,11 @@ def parse(packet_data: Union[str, bytes]) -> Union[TranscriptionMetadata, Transc
         kind = json_object['kind']
 
         if kind == 'TranscriptionMetadata':
-            transcription_metadata = TranscriptionMetadata(**json_object['transcriptionMetadata'])
+            transcription_metadata = TranscriptionMetadata(
+                subscription_id=json_object['transcriptionMetadata']['subscriptionId'],
+                locale=json_object['transcriptionMetadata']['locale'],
+                call_connection_id=json_object['transcriptionMetadata']['callConnectionId'],
+                correlation_id=json_object['transcriptionMetadata']['correlationId'])
             return transcription_metadata
         if kind == 'TranscriptionData':
             participant = identifier_from_raw_id(json_object['transcriptionData']['participantRawID'])
@@ -45,7 +49,7 @@ def parse(packet_data: Union[str, bytes]) -> Union[TranscriptionMetadata, Transc
                 duration=json_object['transcriptionData']['duration'],
                 words=words,
                 participant=participant,
-                result_status=json_object['transcriptionData']['resultStatus']
+                result_state=json_object['transcriptionData']['resultStatus']
             )
             return transcription_data
         raise ValueError(string_json)

sdk/communication/azure-communication-callautomation/swagger/SWAGGER.md

@@ -43,6 +43,10 @@ directive:
   where: $.definitions.RecordingContentType.x-ms-enum
   transform: >
     $["name"] = "RecordingContent";
+- from: swagger-document
+  where: $.definitions.TranscriptionResultType.x-ms-enum
+  transform: >
+    $["name"] = "TranscriptionResultState";
 - from: swagger-document
   where: $.definitions.RecordingChannelType.x-ms-enum
   transform: >

sdk/communication/azure-communication-callautomation/tests/test_streaming_data_parser.py

@@ -6,7 +6,7 @@
 
 import json
 import unittest
-from azure.communication.callautomation._models import (TranscriptionMetadata,TranscriptionData,WordData,TextFormat,ResultStatus)
+from azure.communication.callautomation._models import (TranscriptionMetadata,TranscriptionData,WordData,TextFormat,ResultState)
 from azure.communication.callautomation._streaming_data_parser import StreamingDataParser
 
 class TestStreamDataParser(unittest.TestCase):
@@ -40,12 +40,12 @@ def validate_transcription_metadata(self, transcriptionMetadata):
         self.assertEqual(transcriptionMetadata.subscription_id, "0000a000-9999-5555-ae00-cd00e0bc0000")
         self.assertEqual(transcriptionMetadata.locale, "en-US")
         self.assertEqual(transcriptionMetadata.correlation_id, "6d09449c-6677-4f91-8cb7-012c338e6ec1")
-        self.assertEqual(transcriptionMetadata.callConnection_id, "6d09449c-6677-4f91-8cb7-012c338e6ec1")
+        self.assertEqual(transcriptionMetadata.call_connection_id, "6d09449c-6677-4f91-8cb7-012c338e6ec1")
 
     def validate_transcription_data(self, transcriptionData):
         self.assertEqual(transcriptionData.text, "Is everything fine.")
         self.assertEqual(transcriptionData.format, "display")
-        self.assertEqual(transcriptionData.result_status, "Final")
+        self.assertEqual(transcriptionData.result_state, "Final")
         self.assertAlmostEqual(transcriptionData.confidence, 0.8138430714607239)
         self.assertEqual(transcriptionData.offset, 868464674)
         self.assertEqual(transcriptionData.duration, 11600000)