[ServiceBus] fix failing tests (#35394)

* fix failing tests

* change cached q to new for send_large_message async test

* update cached to new queue for client_session_fail test

* remove assert

Author: swathipil

sdk/servicebus/azure-servicebus/tests/async_tests/test_queues_async.py

@@ -1036,7 +1036,7 @@ async def test_async_queue_by_servicebus_client_receive_batch_with_retrieve_dead
     @pytest.mark.live_test_only
     @CachedServiceBusResourceGroupPreparer(name_prefix='servicebustest')
     @CachedServiceBusNamespacePreparer(name_prefix='servicebustest')
-    @CachedServiceBusQueuePreparer(name_prefix='servicebustest', dead_lettering_on_message_expiration=True)
+    @ServiceBusQueuePreparer(name_prefix='servicebustest', dead_lettering_on_message_expiration=True)
     @pytest.mark.parametrize("uamqp_transport", uamqp_transport_params, ids=uamqp_transport_ids)
     @ArgPasserAsync()
     async def test_async_queue_by_servicebus_client_session_fail(self, uamqp_transport, *, servicebus_namespace_connection_string=None, servicebus_queue=None, **kwargs):
@@ -1052,6 +1052,7 @@ async def test_async_queue_by_servicebus_client_session_fail(self, uamqp_transpo
             async with sb_client.get_queue_receiver(servicebus_queue.name) as receiver:
                 messages = await receiver.receive_messages()
                 for message in messages:
+                    assert str(message) == "test session sender"
                     await receiver.complete_message(message)
 
     @pytest.mark.asyncio
@@ -2152,10 +2153,11 @@ async def _hack_amqp_sender_run_async(self, **kwargs):
     @pytest.mark.live_test_only
     @CachedServiceBusResourceGroupPreparer(name_prefix='servicebustest')
     @CachedServiceBusNamespacePreparer(name_prefix='servicebustest')
-    @CachedServiceBusQueuePreparer(name_prefix='servicebustest', dead_lettering_on_message_expiration=True)
+    @ServiceBusQueuePreparer(name_prefix='servicebustest', dead_lettering_on_message_expiration=True)
     @pytest.mark.parametrize("uamqp_transport", uamqp_transport_params, ids=uamqp_transport_ids)
     @ArgPasserAsync()
     async def test_async_queue_send_large_message_receive(self, uamqp_transport, *, servicebus_namespace_connection_string=None, servicebus_queue=None, **kwargs):
+
         async with ServiceBusClient.from_connection_string(
             servicebus_namespace_connection_string,
             uamqp_transport=uamqp_transport

sdk/servicebus/azure-servicebus/tests/test_queues.py

@@ -1141,6 +1141,7 @@ def test_queue_by_servicebus_client_session_fail(self, uamqp_transport, *, servi
             with sb_client.get_queue_receiver(servicebus_queue.name) as receiver:
                 messages = receiver.receive_messages()
                 for message in messages:
+                    assert str(message) == "test session sender"
                     receiver.complete_message(message)