Revert "Bug fix for message field on Microsoft.ApplicationInsights.Message" (#43087)

* Revert "Bug fix for message field on Microsoft.ApplicationInsights.Message (#…"

This reverts commit 6095433.

* Update CHANGELOG to remove extra line

Author: rads-1996

sdk/monitor/azure-monitor-opentelemetry-exporter/CHANGELOG.md

@@ -9,7 +9,6 @@
   ([#43066](https://github.com/Azure/azure-sdk-for-python/pull/43066))
 - OneSettings control plane: Add killswitch + exponential  backoff + sdkstats feature control
   ([#43147](https://github.com/Azure/azure-sdk-for-python/pull/43147))
-
 - Performance Counters
   ([#43024](https://github.com/Azure/azure-sdk-for-python/pull/43024))
 
@@ -24,6 +23,8 @@
   ([#43122](https://github.com/Azure/azure-sdk-for-python/pull/43122))
 - Fix spelling for OTEL_PYTHON_EXCLUDED_URLS in samples
   ([#43141](https://github.com/Azure/azure-sdk-for-python/pull/43141))
+- Revert #43060
+  ([#43087](https://github.com/Azure/azure-sdk-for-python/pull/43087))
 
 ### Other Changes
 

sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/export/logs/_exporter.py

@@ -2,7 +2,7 @@
 # Licensed under the MIT License.
 import json
 import logging
-from typing import Optional, Sequence, Any, Union
+from typing import Optional, Sequence, Any
 
 from opentelemetry._logs.severity import SeverityNumber
 from opentelemetry.semconv.attributes.exception_attributes import (
@@ -63,7 +63,7 @@ def export(self, batch: Sequence[LogData], **kwargs: Any) -> LogExportResult:  #
         :return: The result of the export.
         :rtype: ~opentelemetry.sdk._logs.export.LogData
         """
-        envelopes = [envelope for log in batch if (envelope := self._log_to_envelope(log)) is not None]
+        envelopes = [self._log_to_envelope(log) for log in batch]
         try:
             result = self._transmit(envelopes)
             self._handle_transmit_from_storage(envelopes, result)
@@ -80,10 +80,8 @@ def shutdown(self) -> None:
         if self.storage:
             self.storage.close()
 
-    def _log_to_envelope(self, log_data: LogData) -> Union[TelemetryItem, None]:
+    def _log_to_envelope(self, log_data: LogData) -> TelemetryItem:
         envelope = _convert_log_to_envelope(log_data)
-        if envelope is None:
-            return None
         envelope.instrumentation_key = self._instrumentation_key
         return envelope
 
@@ -117,7 +115,7 @@ def _log_data_is_event(log_data: LogData) -> bool:
 
 
 # pylint: disable=protected-access
-def _convert_log_to_envelope(log_data: LogData) -> Union[TelemetryItem, None]:
+def _convert_log_to_envelope(log_data: LogData) -> TelemetryItem:
     log_record = log_data.log_record
     time_stamp = log_record.timestamp if log_record.timestamp is not None else log_record.observed_timestamp
     envelope = _utils._create_telemetry_item(time_stamp)
@@ -191,9 +189,6 @@ def _convert_log_to_envelope(log_data: LogData) -> Union[TelemetryItem, None]:
             severity_level=severity_level,  # type: ignore
             properties=properties,
         )
-        if len(data.message) == 0:
-            _logger.warning("Log record body cannot be empty. Skipping export for this log record.")
-            return None
         envelope.data = MonitorBase(base_data=data, base_type="MessageData")
 
     return envelope

sdk/monitor/azure-monitor-opentelemetry-exporter/tests/logs/test_logs.py

@@ -408,12 +408,16 @@ def test_log_to_envelope_log(self):
     def test_log_to_envelope_log_none(self):
         exporter = self._exporter
         envelope = exporter._log_to_envelope(self._log_data_none)
-        self.assertEqual(envelope, None)
+        self.assertEqual(envelope.name, "Microsoft.ApplicationInsights.Message")
+        self.assertEqual(envelope.data.base_type, "MessageData")
+        self.assertEqual(envelope.data.base_data.message, "")
 
     def test_log_to_envelope_log_empty(self):
         exporter = self._exporter
         envelope = exporter._log_to_envelope(self._log_data_empty)
-        self.assertEqual(envelope, None)
+        self.assertEqual(envelope.name, "Microsoft.ApplicationInsights.Message")
+        self.assertEqual(envelope.data.base_type, "MessageData")
+        self.assertEqual(envelope.data.base_data.message, "")
 
     def test_log_to_envelope_log_complex_body(self):
         exporter = self._exporter