Skip to content

Commit 2f728ba

Browse files
authored
Use azpysdk Bandit Check in CI (#44214)
* cut * sanity * nvm * pin bandit version * minor
1 parent 771fa84 commit 2f728ba

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

eng/pipelines/templates/steps/run_bandit.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,17 @@ steps:
1111
- task: PythonScript@0
1212
displayName: 'Run Bandit'
1313
inputs:
14-
scriptPath: 'scripts/devops_tasks/dispatch_tox.py'
14+
scriptPath: 'eng/scripts/dispatch_checks.py'
1515
arguments: >-
1616
"$(TargetingString)"
1717
--mark_arg="${{ parameters.TestMarkArgument }}"
1818
--service="${{ parameters.ServiceDirectory }}"
19-
--toxenv="bandit"
19+
--checks="bandit"
2020
--disable-compatibility-filter
2121
--disablecov
2222
${{ parameters.AdditionalTestArgs }}
23-
env: ${{ parameters.EnvVars }}
23+
env:
24+
TOX_PIP_IMPL: "uv"
25+
VIRTUAL_ENV: ""
26+
PYTHONHOME: ""
2427
condition: and(succeededOrFailed(), ne(variables['Skip.Bandit'],'true'))

eng/tools/azure-sdk-tools/azpysdk/bandit.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111
from ci_tools.logging import logger
1212
from ci_tools.functions import install_into_venv, get_pip_command
1313

14+
BANDIT_VERSION = "1.6.2"
15+
1416

1517
class bandit(Check):
1618
def __init__(self) -> None:
@@ -44,9 +46,10 @@ def run(self, args: argparse.Namespace) -> int:
4446
self.install_dev_reqs(executable, args, package_dir)
4547

4648
try:
47-
install_into_venv(executable, ["bandit"], package_dir)
49+
# pbr is required by the pinned version of bandit
50+
install_into_venv(executable, [f"bandit=={BANDIT_VERSION}", "pbr"], package_dir)
4851
except CalledProcessError as e:
49-
logger.error(f"Failed to install bandit: {e}")
52+
logger.error(f"Failed to install bandit and dependencies: {e}")
5053
return e.returncode
5154

5255
self.pip_freeze(executable)

0 commit comments

Comments
 (0)