Skip to content

Commit 2ff9ddb

Browse files
fix for abstract classes (#35891)
Co-authored-by: Catalina Peralta <[email protected]>
1 parent f838ccc commit 2ff9ddb

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

scripts/breaking_changes_checker/detect_breaking_changes.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,11 @@ def get_properties(cls: Type) -> Dict:
164164
analyzer = ClassTreeAnalyzer(base_class.__name__)
165165
analyzer.visit(module)
166166
cls_node = analyzer.cls_node
167-
get_property_names(cls_node, attribute_names)
167+
if cls_node:
168+
get_property_names(cls_node, attribute_names)
169+
else:
170+
# Abstract base classes fail here, e.g. "collections.abc.MuttableMapping"
171+
_LOGGER.info(f"Unable to get class node for {base_class.__name__}. Skipping...")
168172
else:
169173
get_property_names(cls_node, attribute_names)
170174
return attribute_names

0 commit comments

Comments
 (0)