Addressing comments

Author: v-dharmarajv

sdk/communication/azure-communication-callautomation/azure/communication/callautomation/_call_connection_client.py

@@ -610,11 +610,12 @@ def start_recognizing_media(
         interrupt_prompt: bool = False,
         dtmf_inter_tone_timeout: Optional[int] = None,
         dtmf_max_tones_to_collect: Optional[int] = None,
-        dtmf_stop_tones: Optional[List[Union[str, "DtmfTone"]]] = None,
+        dtmf_stop_tones: Optional[List[Union[str, 'DtmfTone']]] = None,
         speech_language: Optional[str] = None,
         choices: Optional[List["RecognitionChoice"]] = None,
         end_silence_timeout: Optional[int] = None,
         speech_recognition_model_endpoint_id: Optional[str] = None,
+        operation_callback_url: Optional[str] = None,
         **kwargs,
     ) -> None:
         """Recognize inputs from specific participant in this call.
@@ -952,16 +953,16 @@ def stop_transcription(
     @distributed_trace
     def update_transcription(
         self,
-        locale: str,
         *,
+        locale: str,
         operation_context: Optional[str] = None,
         speech_recognition_model_endpoint_id: Optional[str] = None,
         operation_callback_url: Optional[str] = None,
         **kwargs) -> None:
         """API to change transcription language.
 
-        :param locale: Defines new locale for transcription.
-        :type locale: str
+        :keyword locale: Defines new locale for transcription.
+        :paramtype locale: str
         :keyword operation_context: The value to identify context of the operation.
         :paramtype operation_context: str
         :keyword speech_recognition_model_endpoint_id: Endpoint where the custom model was deployed.

sdk/communication/azure-communication-callautomation/azure/communication/callautomation/_credential/call_automation_policy.py

@@ -30,8 +30,7 @@ def __init__(
         acs_url: str,
         access_key: Union[str, AzureKeyCredential],
         decode_url: bool = False,
-    ):
-        # type: (...) -> None
+    ) -> None:
         super(CallAutomationHMACCredentialsPolicy, self).__init__()
 
         if host.startswith("https://"):

sdk/communication/azure-communication-callautomation/azure/communication/callautomation/_models.py

@@ -391,6 +391,7 @@ class MediaStreamingOptions:
 
     def __init__(
         self,
+        *
         transport_url: str,
         transport_type: Union[str, 'StreamingTransportType'],
         content_type: Union[str, 'MediaStreamingContentType'],
@@ -407,7 +408,7 @@ def __init__(
         self.enable_bidirectional = enable_bidirectional
         self.audio_format = audio_format
 
-    def to_generated(self):
+    def _to_generated(self):
         return WebSocketMediaStreamingOptionsRest(
             transport_url=self.transport_url,
             transport_type=self.transport_type,
@@ -452,6 +453,7 @@ class TranscriptionOptions:
 
     def __init__(
         self,
+        *,
         transport_url: str,
         transport_type: Union[str, "StreamingTransportType"],
         locale: str,
@@ -466,7 +468,7 @@ def __init__(
         self.speech_recognition_model_endpoint_id = speech_recognition_model_endpoint_id
         self.enable_intermediate_results = enable_intermediate_results
 
-    def to_generated(self):
+    def _to_generated(self):
         return WebSocketTranscriptionOptionsRest(
             transport_url=self.transport_url,
             transport_type=self.transport_type,

sdk/communication/azure-communication-callautomation/azure/communication/callautomation/aio/_call_connection_client_async.py

@@ -631,7 +631,7 @@ async def start_recognizing_media(
         interrupt_prompt: bool = False,
         dtmf_inter_tone_timeout: Optional[int] = None,
         dtmf_max_tones_to_collect: Optional[int] = None,
-        dtmf_stop_tones: Optional[List[str or "DtmfTone"]] = None,
+        dtmf_stop_tones: Optional[List[Union[str, 'DtmfTone']]] = None,
         speech_language: Optional[str] = None,
         choices: Optional[List["RecognitionChoice"]] = None,
         end_silence_timeout: Optional[int] = None,
@@ -978,15 +978,16 @@ async def stop_transcription(
     @distributed_trace_async
     async def update_transcription(
         self,
-        locale: str,
         *,
+        locale: str,
         operation_context: Optional[str] = None,
         speech_recognition_model_endpoint_id: Optional[str] = None,
         operation_callback_url: Optional[str] = None,
         **kwargs) -> None:
         """API to change transcription language.
 
-        :param locale: Defines new locale for transcription.
+        :keyword locale: Defines new locale for transcription.
+        :paramtype locale: str
         :keyword operation_context: The value to identify context of the operation.
         :paramtype operation_context: str
         :keyword speech_recognition_model_endpoint_id: Endpoint where the custom model was deployed.
@@ -1107,7 +1108,7 @@ async def start_media_streaming(
             operation_callback_uri=operation_callback_url,
             operation_context=operation_context
         )
-        self._call_media_client.start_media_streaming(
+        await self._call_media_client.start_media_streaming(
             self._call_connection_id,
             start_media_streaming_request,
             **kwargs)
@@ -1137,7 +1138,7 @@ async def stop_media_streaming(
             operation_callback_uri=operation_callback_url,
             operation_context=operation_context
             )
-        self._call_media_client.stop_media_streaming(
+        await self._call_media_client.stop_media_streaming(
             self._call_connection_id,
             stop_media_streaming_request,
             **kwargs