Feature Management Update Schema (#34421)

* Update Schema

* spelling

* formatting

Author: mrm9084

sdk/appconfiguration/azure-appconfiguration-provider/README.md

@@ -170,11 +170,11 @@ config = load(endpoint=endpoint, credential=DefaultAzureCredential(), key_vault_
 
 ## Loading Feature Flags
 
-Feature Flags can be loaded from config stores using the provider. Feature flags are loaded as a dictionary of key/value pairs stored in the provider under the `FeatureManagement`, then `FeatureFlags`.
+Feature Flags can be loaded from config stores using the provider. Feature flags are loaded as a dictionary of key/value pairs stored in the provider under the `feature_management`, then `feature_flags`.
 
 ```python
 config = load(endpoint=endpoint, credential=DefaultAzureCredential(), feature_flags_enabled=True)
-alpha = config["FeatureManagement"]["FeatureFlags"]["Alpha"]
+alpha = config["feature_management"]["feature_flags"]["Alpha"]
 print(alpha["enabled"])
 ```
 
@@ -184,7 +184,7 @@ By default all feature flags with no label are loaded. If you want to load featu
 from azure.appconfiguration.provider import load, SettingSelector
 
 config = load(endpoint=endpoint, credential=DefaultAzureCredential(), feature_flags_enabled=True, feature_flag_selectors=[SettingSelector(key_filter="*", label_filter="dev")])
-alpha = config["FeatureManagement"]["FeatureFlags"]["Alpha"]
+alpha = config["feature_management"]["feature_flags"]["Alpha"]
 print(alpha["enabled"])
 ```
 

sdk/appconfiguration/azure-appconfiguration-provider/azure/appconfiguration/provider/_constants.py

@@ -4,8 +4,8 @@
 # license information.
 # -------------------------------------------------------------------------
 
-FEATURE_MANAGEMENT_KEY = "FeatureManagement"
-FEATURE_FLAG_KEY = "FeatureFlags"
+FEATURE_MANAGEMENT_KEY = "feature_management"
+FEATURE_FLAG_KEY = "feature_flags"
 FEATURE_FLAG_PREFIX = ".appconfig.featureflag/"
 
 EMPTY_LABEL = "\0"

sdk/appconfiguration/azure-appconfiguration-provider/samples/refresh_sample_feature_flags.py

@@ -44,7 +44,7 @@ def my_callback_on_fail(error):
 
 print(config["message"])
 print(config["my_json"]["key"])
-print(config["FeatureManagement"]["FeatureFlags"]["Beta"])
+print(config["feature_management"]["feature_flags"]["Beta"])
 
 # Updating the configuration setting
 feature_flag_setting.enabled = False
@@ -60,7 +60,7 @@ def my_callback_on_fail(error):
 # Printing the updated value
 print(config["message"])
 print(config["my_json"]["key"])
-print(config["FeatureManagement"]["FeatureFlags"]["Beta"])
+print(config["feature_management"]["feature_flags"]["Beta"])
 
 # Waiting for the refresh interval to pass
 time.sleep(2)
@@ -71,4 +71,4 @@ def my_callback_on_fail(error):
 # Printing the updated value
 print(config["message"])
 print(config["my_json"]["key"])
-print(config["FeatureManagement"]["FeatureFlags"]["Beta"])
+print(config["feature_management"]["feature_flags"]["Beta"])

sdk/appconfiguration/azure-appconfiguration-provider/tests/asynctestcase.py

@@ -4,18 +4,15 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # --------------------------------------------------------------------------
-import asyncio
 from devtools_testutils import AzureRecordedTestCase
 from azure.appconfiguration.aio import AzureAppConfigurationClient
-from azure.appconfiguration import ConfigurationSetting, FeatureFlagConfigurationSetting
 from testcase import get_configs
 from azure.appconfiguration.provider.aio import load
 from azure.appconfiguration.provider import SettingSelector, AzureAppConfigurationKeyVaultOptions
+from test_constants import FEATURE_MANAGEMENT_KEY, FEATURE_FLAG_KEY
 
 
 class AppConfigTestCase(AzureRecordedTestCase):
-    import asyncio
-
     async def create_aad_client(
         self,
         appconfiguration_endpoint_string,
@@ -153,7 +150,7 @@ async def setup_configs(client, keyvault_secret_url):
 
 
 def has_feature_flag(client, feature_id, enabled=False):
-    for feature_flag in client["FeatureManagement"]["FeatureFlags"]:
+    for feature_flag in client[FEATURE_MANAGEMENT_KEY][FEATURE_FLAG_KEY]:
         if feature_flag["id"] == feature_id:
             return feature_flag["enabled"] == enabled
     return False

sdk/appconfiguration/azure-appconfiguration-provider/tests/test_async_provider.py

@@ -7,6 +7,7 @@
 from devtools_testutils.aio import recorded_by_proxy_async
 from async_preparers import app_config_decorator_async
 from asynctestcase import AppConfigTestCase, has_feature_flag
+from test_constants import FEATURE_MANAGEMENT_KEY
 
 
 class TestAppConfigurationProvider(AppConfigTestCase):
@@ -21,7 +22,7 @@ async def test_provider_creation(self, appconfiguration_connection_string, appco
         ) as client:
             assert client["message"] == "hi"
             assert client["my_json"]["key"] == "value"
-            assert "FeatureManagement" in client
+            assert FEATURE_MANAGEMENT_KEY in client
             assert has_feature_flag(client, "Alpha")
 
     # method: provider_trim_prefixes
@@ -41,7 +42,7 @@ async def test_provider_trim_prefixes(
             assert client["my_json"]["key"] == "value"
             assert client["trimmed"] == "key"
             assert "test.trimmed" not in client
-            assert "FeatureManagement" in client
+            assert FEATURE_MANAGEMENT_KEY in client
             assert has_feature_flag(client, "Alpha")
 
     # method: provider_selectors
@@ -56,7 +57,7 @@ async def test_provider_selectors(self, appconfiguration_connection_string, appc
         ) as client:
             assert client["message"] == "test"
             assert "test.trimmed" not in client
-            assert "FeatureManagement" not in client
+            assert FEATURE_MANAGEMENT_KEY not in client
 
     # method: provider_selectors
     @app_config_decorator_async

sdk/appconfiguration/azure-appconfiguration-provider/tests/test_async_provider_aad.py

@@ -3,12 +3,11 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # --------------------------------------------------------------------------
-from azure.appconfiguration.provider.aio import load
 from azure.appconfiguration.provider import SettingSelector, AzureAppConfigurationKeyVaultOptions
 from devtools_testutils.aio import recorded_by_proxy_async
-from azure.appconfiguration.aio import AzureAppConfigurationClient
 from async_preparers import app_config_decorator_async
 from asynctestcase import AppConfigTestCase, has_feature_flag
+from test_constants import FEATURE_MANAGEMENT_KEY
 
 
 class TestAppConfigurationProvider(AppConfigTestCase):
@@ -23,7 +22,7 @@ async def test_provider_creation_aad(self, appconfiguration_endpoint_string, app
         ) as client:
             assert client.get("message") == "hi"
             assert client["my_json"]["key"] == "value"
-            assert "FeatureManagement" in client
+            assert FEATURE_MANAGEMENT_KEY in client
             assert has_feature_flag(client, "Alpha")
 
     # method: provider_trim_prefixes
@@ -40,7 +39,7 @@ async def test_provider_trim_prefixes(self, appconfiguration_endpoint_string, ap
             assert client["message"] == "hi"
             assert client["my_json"]["key"] == "value"
             assert client["trimmed"] == "key"
-            assert "FeatureManagement" in client
+            assert FEATURE_MANAGEMENT_KEY in client
             assert has_feature_flag(client, "Alpha")
 
     # method: provider_selectors
@@ -55,7 +54,7 @@ async def test_provider_selectors(self, appconfiguration_endpoint_string, appcon
         ) as client:
             assert client["message"] == "test"
             assert "test.trimmed" not in client
-            assert "FeatureManagement" not in client
+            assert FEATURE_MANAGEMENT_KEY not in client
 
     # method: provider_selectors
     @app_config_decorator_async

sdk/appconfiguration/azure-appconfiguration-provider/tests/test_async_provider_feature_management.py

@@ -9,6 +9,7 @@
 from devtools_testutils.aio import recorded_by_proxy_async
 from async_preparers import app_config_decorator_async
 from asynctestcase import AppConfigTestCase, setup_configs, has_feature_flag
+from test_constants import FEATURE_MANAGEMENT_KEY
 
 
 from azure.appconfiguration.provider._azureappconfigurationprovider import _delay_failure
@@ -25,7 +26,7 @@ async def test_load_only_feature_flags(self, appconfiguration_connection_string)
             feature_flag_enabled=True,
         ) as client:
             assert len(client.keys()) == 1
-            assert "FeatureManagement" in client
+            assert FEATURE_MANAGEMENT_KEY in client
             assert has_feature_flag(client, "Alpha")
 
     # method: load
@@ -43,5 +44,5 @@ async def test_select_feature_flags(self, appconfiguration_connection_string):
             user_agent="SDK/Integration",
         ) as client:
             assert len(client.keys()) == 1
-            assert "FeatureManagement" in client
+            assert FEATURE_MANAGEMENT_KEY in client
             assert not has_feature_flag(client, "Alpha")

sdk/appconfiguration/azure-appconfiguration-provider/tests/test_async_provider_refresh.py

@@ -12,7 +12,7 @@
 from devtools_testutils.aio import recorded_by_proxy_async
 from async_preparers import app_config_decorator_async
 from asynctestcase import AppConfigTestCase, has_feature_flag
-
+from test_constants import FEATURE_MANAGEMENT_KEY
 
 try:
     # Python 3.7 does not support AsyncMock
@@ -37,7 +37,7 @@ async def test_refresh(self, appconfiguration_endpoint_string, appconfiguration_
             ) as client:
                 assert client["refresh_message"] == "original value"
                 assert client["my_json"]["key"] == "value"
-                assert "FeatureManagement" in client
+                assert FEATURE_MANAGEMENT_KEY in client
                 assert has_feature_flag(client, "Alpha")
                 setting = await client._client.get_configuration_setting(key="refresh_message")
                 setting.value = "updated value"
@@ -101,7 +101,7 @@ async def test_empty_refresh(self, appconfiguration_endpoint_string, appconfigur
                 assert client["refresh_message"] == "original value"
                 assert client["non_refreshed_message"] == "Static"
                 assert client["my_json"]["key"] == "value"
-                assert "FeatureManagement" in client
+                assert FEATURE_MANAGEMENT_KEY in client
                 assert has_feature_flag(client, "Alpha")
                 setting = await client._client.get_configuration_setting(key="refresh_message")
                 setting.value = "updated value"

sdk/appconfiguration/azure-appconfiguration-provider/tests/test_constants.py

@@ -0,0 +1,2 @@
+FEATURE_MANAGEMENT_KEY = "feature_management"
+FEATURE_FLAG_KEY = "feature_flags"

sdk/appconfiguration/azure-appconfiguration-provider/tests/test_provider.py

@@ -9,6 +9,7 @@
 from testcase import AppConfigTestCase, has_feature_flag
 import datetime
 from unittest.mock import patch
+from test_constants import FEATURE_MANAGEMENT_KEY
 
 from azure.appconfiguration.provider._azureappconfigurationprovider import _delay_failure
 
@@ -29,7 +30,7 @@ def test_provider_creation(self, appconfiguration_connection_string, appconfigur
         )
         assert client["message"] == "hi"
         assert client["my_json"]["key"] == "value"
-        assert "FeatureManagement" in client
+        assert FEATURE_MANAGEMENT_KEY in client
         assert has_feature_flag(client, "Alpha")
 
     # method: provider_trim_prefixes
@@ -47,7 +48,7 @@ def test_provider_trim_prefixes(self, appconfiguration_connection_string, appcon
         assert client["my_json"]["key"] == "value"
         assert client["trimmed"] == "key"
         assert "test.trimmed" not in client
-        assert "FeatureManagement" in client
+        assert FEATURE_MANAGEMENT_KEY in client
         assert has_feature_flag(client, "Alpha")
 
     # method: provider_selectors
@@ -62,7 +63,7 @@ def test_provider_selectors(self, appconfiguration_connection_string, appconfigu
         )
         assert client["message"] == "test"
         assert "test.trimmed" not in client
-        assert "FeatureManagement" not in client
+        assert FEATURE_MANAGEMENT_KEY not in client
 
     # method: provider_selectors
     @recorded_by_proxy