accept float "retry-after" (#34253)

* accept float "retry-after"

* black

* update

* update tests

* update

Author: xiangyan99

sdk/core/azure-core/CHANGELOG.md

@@ -10,6 +10,8 @@
 
 ### Other Changes
 
+- Accept float for `retry_after` header.  #34203
+
 ## 1.30.0 (2024-02-01)
 
 ### Features Added

sdk/core/azure-core/azure/core/pipeline/policies/_utils.py

@@ -66,7 +66,7 @@ def parse_retry_after(retry_after: str) -> float:
     """
     delay: float  # Using the Mypy recommendation to use float for "int or float"
     try:
-        delay = int(retry_after)
+        delay = float(retry_after)
     except ValueError:
         # Not an integer? Try HTTP date
         retry_date = _parse_http_date(retry_after)

sdk/core/azure-core/tests/async_tests/test_retry_policy_async.py

@@ -59,7 +59,7 @@ def test_retry_types():
     assert backoff_time == 4
 
 
-@pytest.mark.parametrize("retry_after_input,http_request", product(["0", "800", "1000", "1200"], HTTP_REQUESTS))
+@pytest.mark.parametrize("retry_after_input,http_request", product(["0", "800", "1000", "1200", "0.9"], HTTP_REQUESTS))
 def test_retry_after(retry_after_input, http_request):
     retry_policy = AsyncRetryPolicy()
     request = http_request("GET", "http://localhost")
@@ -78,7 +78,7 @@ def test_retry_after(retry_after_input, http_request):
     assert retry_after == float(retry_after_input)
 
 
-@pytest.mark.parametrize("retry_after_input,http_request", product(["0", "800", "1000", "1200"], HTTP_REQUESTS))
+@pytest.mark.parametrize("retry_after_input,http_request", product(["0", "800", "1000", "1200", "0.9"], HTTP_REQUESTS))
 def test_x_ms_retry_after(retry_after_input, http_request):
     retry_policy = AsyncRetryPolicy()
     request = http_request("GET", "http://localhost")

sdk/core/azure-core/tests/test_retry_policy.py

@@ -61,7 +61,8 @@ def test_retry_types():
 
 
 @pytest.mark.parametrize(
-    "retry_after_input,http_request,http_response", product(["0", "800", "1000", "1200"], HTTP_REQUESTS, HTTP_RESPONSES)
+    "retry_after_input,http_request,http_response",
+    product(["0", "800", "1000", "1200", "0.9"], HTTP_REQUESTS, HTTP_RESPONSES),
 )
 def test_retry_after(retry_after_input, http_request, http_response):
     retry_policy = RetryPolicy()
@@ -82,7 +83,8 @@ def test_retry_after(retry_after_input, http_request, http_response):
 
 
 @pytest.mark.parametrize(
-    "retry_after_input,http_request,http_response", product(["0", "800", "1000", "1200"], HTTP_REQUESTS, HTTP_RESPONSES)
+    "retry_after_input,http_request,http_response",
+    product(["0", "800", "1000", "1200", "0.9"], HTTP_REQUESTS, HTTP_RESPONSES),
 )
 def test_x_ms_retry_after(retry_after_input, http_request, http_response):
     retry_policy = RetryPolicy()

sdk/core/azure-core/tests/test_utils.py

@@ -8,6 +8,7 @@
 import pytest
 from azure.core.utils import case_insensitive_dict
 from azure.core.utils._utils import get_running_async_lock
+from azure.core.pipeline.policies._utils import parse_retry_after
 
 
 @pytest.fixture()
@@ -134,3 +135,14 @@ def test_get_running_async_module_sync():
         sys.modules.pop("trio", None)
         with pytest.raises(RuntimeError):
             get_running_async_lock()
+
+
+def test_parse_retry_after():
+    ret = parse_retry_after("100")
+    assert ret == 100
+    ret = parse_retry_after("Fri, 1 Oct 2100 00:00:00 GMT")
+    assert ret > 0
+    ret = parse_retry_after("0")
+    assert ret == 0
+    ret = parse_retry_after("0.9")
+    assert ret == 0.9