Skip to content

Commit 43646c0

Browse files
authored
Simulator bugfixes (#34753)
* Reverting models to make sure calls to the simulator work * quotes * Spellcheck fixes * ignore the models for doc generation * Fixed the quotes on f strings * pylint skip file * Support for summarization * Adding a limit of 2 conversation turns for all but conversation simulators * exclude synthetic from mypy * Another lint fix * Skip the file causing linting issues * Bugfix on output to json_qa_lines and empty response from callbacks * Skip pylint
1 parent dbef227 commit 43646c0

File tree

2 files changed

+25
-11
lines changed

2 files changed

+25
-11
lines changed

sdk/ai/azure-ai-generative/azure/ai/generative/synthetic/simulator/simulator/_callback_conversation_bot.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,17 @@ async def generate_response(
4646
"id": None,
4747
"template_parameters": {}
4848
}
49+
if not result:
50+
result = {
51+
"messages": [{
52+
"content": "Callback did not return a response.",
53+
"role": "assistant"
54+
}],
55+
"finish_reason": ["stop"],
56+
"id": None,
57+
"template_parameters": {}
58+
}
59+
4960
self.logger.info("Using user provided callback returning response.")
5061

5162
time_taken = 0

sdk/ai/azure-ai-generative/azure/ai/generative/synthetic/simulator/simulator/_utils.py

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# ---------------------------------------------------------
22
# Copyright (c) Microsoft Corporation. All rights reserved.
33
# ---------------------------------------------------------
4-
# pylint: disable=C0303
4+
# pylint: skip-file
55
"""
66
This module contains a utility class for managing a list of JSON lines.
77
"""
@@ -52,14 +52,17 @@ def to_eval_qa_json_lines(self):
5252
assistant_message = message['content']
5353
if 'context' in message:
5454
context = message.get("context", None)
55-
if user_message and assistant_message:
56-
if context:
57-
json_lines += json.dumps({
58-
'question': user_message,
59-
'answer': assistant_message,
60-
'context': context}) + "\n"
61-
else:
62-
json_lines += json.dumps({
63-
'question': user_message,
64-
'answer': assistant_message}) + "\n"
55+
if user_message and assistant_message:
56+
if context:
57+
json_lines += json.dumps({
58+
'question': user_message,
59+
'answer': assistant_message,
60+
'context': context}) + "\n"
61+
user_message = assistant_message = context = None
62+
else:
63+
json_lines += json.dumps({
64+
'question': user_message,
65+
'answer': assistant_message}) + "\n"
66+
user_message = assistant_message = None
67+
6568
return json_lines

0 commit comments

Comments
 (0)