Ensure that azpysdk checks are dispatched with correct working directory (#42948)

Author: scbedd

eng/tools/azure-sdk-tools/azpysdk/Check.py

@@ -65,7 +65,7 @@ def create_venv(self, isolate: bool, venv_location: str) -> str:
 
             # TODO: we should reuse part of build_whl_for_req to integrate with PREBUILT_WHL_DIR so that we don't have to fresh build for each
             # venv
-            install_into_venv(venv_location, [os.path.join(REPO_ROOT, "eng/tools/azure-sdk-tools[build]")])
+            install_into_venv(venv_location, [os.path.join(REPO_ROOT, "eng/tools/azure-sdk-tools[build]")], REPO_ROOT)
             venv_python_exe = get_venv_python(venv_location)
 
             return venv_python_exe

eng/tools/azure-sdk-tools/azpysdk/black.py

@@ -48,7 +48,7 @@ def run(self, args: argparse.Namespace) -> int:
 
             # install black
             try:
-                install_into_venv(executable, [f"black=={BLACK_VERSION}"])
+                install_into_venv(executable, [f"black=={BLACK_VERSION}"], package_dir)
             except CalledProcessError as e:
                 logger.error("Failed to install black:", e)
                 return e.returncode

eng/tools/azure-sdk-tools/azpysdk/mypy.py

@@ -66,9 +66,9 @@ def run(self, args: argparse.Namespace) -> int:
             try:
                 if args.next:
                     # use latest version of mypy
-                    install_into_venv(executable, ["mypy"] + additional_requirements)
+                    install_into_venv(executable, ["mypy"] + additional_requirements, package_dir)
                 else:
-                    install_into_venv(executable, [f"mypy=={MYPY_VERSION}"] + additional_requirements)
+                    install_into_venv(executable, [f"mypy=={MYPY_VERSION}"] + additional_requirements, package_dir)
             except CalledProcessError as e:
                 logger.error("Failed to install mypy:", e)
                 return e.returncode

eng/tools/azure-sdk-tools/azpysdk/pylint.py

@@ -29,7 +29,7 @@ def register(self, subparsers: "argparse._SubParsersAction", parent_parsers: Opt
             "--next",
             default=False,
             help="Next version of pylint is being tested.",
-            required=False,      
+            required=False,
         )
 
     def run(self, args: argparse.Namespace) -> int:
@@ -49,7 +49,7 @@ def run(self, args: argparse.Namespace) -> int:
 
             # install dependencies
             try:
-                install_into_venv(executable, ["azure-pylint-guidelines-checker==0.5.6", "--index-url=https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-python/pypi/simple/"])
+                install_into_venv(executable, ["azure-pylint-guidelines-checker==0.5.6", "--index-url=https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-python/pypi/simple/"], package_dir)
             except CalledProcessError as e:
                 logger.error("Failed to install dependencies:", e)
                 return e.returncode
@@ -58,9 +58,9 @@ def run(self, args: argparse.Namespace) -> int:
             try:
                 if args.next:
                     # use latest version of pylint
-                    install_into_venv(executable, ["pylint"])
+                    install_into_venv(executable, ["pylint"], package_dir)
                 else:
-                    install_into_venv(executable, [f"pylint=={PYLINT_VERSION}"])
+                    install_into_venv(executable, [f"pylint=={PYLINT_VERSION}"], package_dir)
             except CalledProcessError as e:
                 logger.error("Failed to install pylint:", e)
                 return e.returncode

eng/tools/azure-sdk-tools/azpysdk/sphinx.py

@@ -280,7 +280,7 @@ def run(self, args: argparse.Namespace) -> int:
             try:
                 if args.next:
                     install_into_venv(
-                        executable, ["sphinx", "sphinx_rtd_theme", "myst_parser", "sphinxcontrib-jquery"],
+                        executable, ["sphinx", "sphinx_rtd_theme", "myst_parser", "sphinxcontrib-jquery"], package_dir
                     )
                 else:
                     install_into_venv(
@@ -291,6 +291,7 @@ def run(self, args: argparse.Namespace) -> int:
                             f"myst_parser=={MYST_PARSER_VERSION}",
                             f"sphinxcontrib-jquery=={SPHINX_CONTRIB_JQUERY_VERSION}",
                         ],
+                        package_dir
                     )
             except CalledProcessError as e:
                 logger.error("Failed to install sphinx:", e)

eng/tools/azure-sdk-tools/azpysdk/whl.py

@@ -45,7 +45,7 @@ def run(self, args: argparse.Namespace) -> int:
 
             if os.path.exists(dev_requirements):
                 print(f"Installing dev_requirements at {dev_requirements}")
-                install_into_venv(executable, [f"{dev_requirements}"])
+                install_into_venv(executable, [f"{dev_requirements}"], pkg)
             else:
                 print("Skipping installing dev_requirements")
 

eng/tools/azure-sdk-tools/ci_tools/functions.py

@@ -509,7 +509,7 @@ def get_venv_python(venv_path: str) -> str:
 
 
 def install_into_venv(
-    venv_path_or_executable: str, requirements: List[str]
+    venv_path_or_executable: str, requirements: List[str], working_directory: str
 ) -> None:
     """
     Install the requirements into an existing venv (venv_path) without activating it.
@@ -528,7 +528,7 @@ def install_into_venv(
         cmd += ["--python", py]
 
     # todo: clean this up so that we're using run_logged from #42862
-    subprocess.check_call(cmd)
+    subprocess.check_call(cmd, cwd=working_directory)
 
 
 def pip_install_requirements_file(requirements_file: str, python_executable: Optional[str] = None) -> bool: