[Monitor OpenTelemetry Exporter] Remove the Device OS Setting (#41549)

* Remove the device OS setting.

* Update CHANGELOG.md

* Update changelog message.

Author: JacksonWeber

sdk/monitor/azure-monitor-opentelemetry-exporter/CHANGELOG.md

@@ -9,6 +9,8 @@
 ### Bugs Fixed
 - Fix for issue #41470. Added back exception message, removed earlier due to linting errors
   ([#41512] https://github.com/Azure/azure-sdk-for-python/pull/41512)
+- Should leave ingestion to populate Device OS from User Agent
+  ([#41549] https://github.com/Azure/azure-sdk-for-python/pull/41549)
 
 ### Other Changes
 

sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_utils.py

@@ -130,7 +130,6 @@ def _getlocale():
 azure_monitor_context = {
     ContextTagKeys.AI_DEVICE_ID: platform.node(),
     ContextTagKeys.AI_DEVICE_LOCALE: _getlocale(),
-    ContextTagKeys.AI_DEVICE_OS_VERSION: platform.version(),
     ContextTagKeys.AI_DEVICE_TYPE: "Other",
     ContextTagKeys.AI_INTERNAL_SDK_VERSION: _get_sdk_version(),
 }

sdk/monitor/azure-monitor-opentelemetry-exporter/tests/logs/test_logs.py

@@ -362,10 +362,6 @@ def test_log_to_envelope_partA(self):
         self.assertEqual(
             envelope.tags.get(ContextTagKeys.AI_DEVICE_LOCALE), azure_monitor_context[ContextTagKeys.AI_DEVICE_LOCALE]
         )
-        self.assertEqual(
-            envelope.tags.get(ContextTagKeys.AI_DEVICE_OS_VERSION),
-            azure_monitor_context[ContextTagKeys.AI_DEVICE_OS_VERSION],
-        )
         self.assertEqual(
             envelope.tags.get(ContextTagKeys.AI_DEVICE_TYPE), azure_monitor_context[ContextTagKeys.AI_DEVICE_TYPE]
         )

sdk/monitor/azure-monitor-opentelemetry-exporter/tests/metrics/test_metrics.py

@@ -187,10 +187,6 @@ def test_point_to_envelope_partA(self):
         self.assertEqual(
             envelope.tags.get(ContextTagKeys.AI_DEVICE_LOCALE), azure_monitor_context[ContextTagKeys.AI_DEVICE_LOCALE]
         )
-        self.assertEqual(
-            envelope.tags.get(ContextTagKeys.AI_DEVICE_OS_VERSION),
-            azure_monitor_context[ContextTagKeys.AI_DEVICE_OS_VERSION],
-        )
         self.assertEqual(
             envelope.tags.get(ContextTagKeys.AI_DEVICE_TYPE), azure_monitor_context[ContextTagKeys.AI_DEVICE_TYPE]
         )

sdk/monitor/azure-monitor-opentelemetry-exporter/tests/test_utils.py

@@ -15,12 +15,10 @@
 
 TEST_AI_DEVICE_ID = "TEST_AI_DEVICE_ID"
 TEST_AI_DEVICE_LOCALE = "TEST_AI_DEVICE_LOCALE"
-TEST_OS_VERSION = "TEST_OS_VERSION"
 TEST_SDK_VERSION_PREFIX = "TEST_AZURE_SDK_VERSION_PREFIX"
 TEST_AZURE_MONITOR_CONTEXT = {
     "ai.device.id": TEST_AI_DEVICE_ID,
     "ai.device.locale": TEST_AI_DEVICE_LOCALE,
-    "ai.device.osVersion": TEST_OS_VERSION,
     "ai.device.type": "Other",
     "ai.internal.sdkVersion": "{}py1.2.3:otel4.5.6:ext7.8.9".format(
         TEST_SDK_VERSION_PREFIX,

sdk/monitor/azure-monitor-opentelemetry-exporter/tests/trace/test_trace.py

@@ -290,10 +290,6 @@ def test_span_to_envelope_partA(self):
         self.assertEqual(
             envelope.tags.get(ContextTagKeys.AI_DEVICE_LOCALE), azure_monitor_context[ContextTagKeys.AI_DEVICE_LOCALE]
         )
-        self.assertEqual(
-            envelope.tags.get(ContextTagKeys.AI_DEVICE_OS_VERSION),
-            azure_monitor_context[ContextTagKeys.AI_DEVICE_OS_VERSION],
-        )
         self.assertEqual(
             envelope.tags.get(ContextTagKeys.AI_DEVICE_TYPE), azure_monitor_context[ContextTagKeys.AI_DEVICE_TYPE]
         )
@@ -1448,10 +1444,6 @@ def test_span_events_to_envelopes_exception(self):
         self.assertEqual(
             envelope.tags.get(ContextTagKeys.AI_DEVICE_LOCALE), azure_monitor_context[ContextTagKeys.AI_DEVICE_LOCALE]
         )
-        self.assertEqual(
-            envelope.tags.get(ContextTagKeys.AI_DEVICE_OS_VERSION),
-            azure_monitor_context[ContextTagKeys.AI_DEVICE_OS_VERSION],
-        )
         self.assertEqual(
             envelope.tags.get(ContextTagKeys.AI_DEVICE_TYPE), azure_monitor_context[ContextTagKeys.AI_DEVICE_TYPE]
         )
@@ -1510,10 +1502,6 @@ def test_span_events_to_envelopes_message(self):
         self.assertEqual(
             envelope.tags.get(ContextTagKeys.AI_DEVICE_LOCALE), azure_monitor_context[ContextTagKeys.AI_DEVICE_LOCALE]
         )
-        self.assertEqual(
-            envelope.tags.get(ContextTagKeys.AI_DEVICE_OS_VERSION),
-            azure_monitor_context[ContextTagKeys.AI_DEVICE_OS_VERSION],
-        )
         self.assertEqual(
             envelope.tags.get(ContextTagKeys.AI_DEVICE_TYPE), azure_monitor_context[ContextTagKeys.AI_DEVICE_TYPE]
         )
@@ -1574,10 +1562,6 @@ def test_span_events_to_envelopes_sample_rate(self):
         self.assertEqual(
             envelope.tags.get(ContextTagKeys.AI_DEVICE_LOCALE), azure_monitor_context[ContextTagKeys.AI_DEVICE_LOCALE]
         )
-        self.assertEqual(
-            envelope.tags.get(ContextTagKeys.AI_DEVICE_OS_VERSION),
-            azure_monitor_context[ContextTagKeys.AI_DEVICE_OS_VERSION],
-        )
         self.assertEqual(
             envelope.tags.get(ContextTagKeys.AI_DEVICE_TYPE), azure_monitor_context[ContextTagKeys.AI_DEVICE_TYPE]
         )