[ML] Fixing bugs related with workspace resource operations. (#34034)

* remove PNA and manage network check for project

* add dump support for diagnose result, and fix list key schema issue

* Update diagnose json dump method

* running black

* Add ChangeLog

* Update project arm template to support more properties

Author: ZhidaLiu

sdk/ml/azure-ai-ml/CHANGELOG.md

@@ -7,6 +7,8 @@
 
 ### Bugs Fixed
 - Fix pipeline job `outputs` not load correctly when `component: <local-file>` exists in pipeline job yaml.
+- Workspace ListKey operation serialization issue fixed.
+- Workspace Diagnose result now can be print in to Json format.
 
 ### Breaking Changes
 

sdk/ml/azure-ai-ml/azure/ai/ml/_arm_deployments/arm_templates/workspace_project.json

@@ -689,6 +689,9 @@
                 "description": "[parameters('description')]",
                 "primaryUserAssignedIdentity": "[parameters('primaryUserAssignedIdentity')]",
                 "hubResourceId": "[parameters('workspace_hub')]",
+                "enableDataIsolation": "[parameters('enable_data_isolation')]",
+                "managedNetwork": "[parameters('managedNetwork')]",
+                "publicNetworkAccess": "[parameters('publicNetworkAccess')]",
                 "serverlessComputeSettings": "[parameters('serverless_compute_settings')]"
             }
         }

sdk/ml/azure-ai-ml/azure/ai/ml/entities/_workspace/diagnose.py

@@ -1,7 +1,9 @@
 # ---------------------------------------------------------
 # Copyright (c) Microsoft Corporation. All rights reserved.
 # ---------------------------------------------------------
-from typing import Any, Dict, List, Optional
+
+import json
+from typing import Any, Dict, Optional, List
 
 from azure.ai.ml._restclient.v2023_08_01_preview.models import (
     DiagnoseRequestProperties as RestDiagnoseRequestProperties,
@@ -145,6 +147,15 @@ def _to_rest_object(self) -> RestDiagnoseResponseResultValue:
             other_results=self.other_results,
         )
 
+    def __json__(self):
+        results = self.__dict__.copy()
+        for k, v in results.items():
+            results[k] = [item.__dict__ for item in v]
+        return results
+
+    def __str__(self) -> str:
+        return json.dumps(self, default=lambda o: o.__json__(), indent=2)
+
 
 class DiagnoseResult:
     """Result of Diagnose."""

sdk/ml/azure-ai-ml/azure/ai/ml/entities/_workspace/workspace_keys.py

@@ -4,7 +4,7 @@
 
 from typing import List, Optional
 
-from azure.ai.ml._restclient.v2023_06_01_preview.models import ListWorkspaceKeysResult
+from azure.ai.ml._restclient.v2023_08_01_preview.models import ListWorkspaceKeysResult
 
 
 class ContainerRegistryCredential:
@@ -93,7 +93,7 @@ def _from_rest_object(cls, rest_obj: ListWorkspaceKeysResult) -> Optional["Works
 
         return WorkspaceKeys(
             user_storage_key=rest_obj.user_storage_key,
-            user_storage_resource_id=rest_obj.user_storage_resource_id,
+            user_storage_resource_id=rest_obj.user_storage_arm_id,
             app_insights_instrumentation_key=rest_obj.app_insights_instrumentation_key,
             container_registry_credentials=container_registry_credentials,
             notebook_access_keys=notebook_access_keys,

sdk/ml/azure-ai-ml/azure/ai/ml/operations/_workspace_operations_base.py

@@ -164,9 +164,6 @@ def begin_create(
                     workspace.storage_account,
                     workspace.container_registry,
                     workspace.key_vault,
-                    workspace.public_network_access,
-                    workspace.managed_network,
-                    workspace.customer_managed_key,
                 ]
             ):
                 msg = (