Merge branch 'main' into lusu/agentserver-1110

Author: lusu-msft

.vscode/cspell.json

@@ -356,6 +356,7 @@
     "nbsp",
     "noarch",
     "NOPERM",
+    "norecursedirs",
     "northcentralus",
     "nspkg",
     "OAEP",

doc/dev/mgmt/hybrid_model_migration.md

@@ -17,6 +17,7 @@ When migrating to the hybrid model design, expect these breaking changes:
 | [Additional Properties](#additional-properties-handling)                            | `additional_properties` parameter removed                 | Use direct dictionary syntax: `model["key"] = value`                              |
 | [String Representation](#string-representation-matches-rest-api)                    | Model key output changed from `snake_case` to `camelCase` | Update any code parsing model strings to expect `camelCase`                       |
 | [Serialization/Deserialization](#serialization-and-deserialization-methods-removed) | `serialize` and `deserialize` methods removed     | Use dictionary access for serialization, constructor for deserialization          |
+| [Reserved Property Names](#reserved-property-name-conflicts)                      | Conflicting names suffixed with `_property`       | Update code to use `_property` suffix: `model.keys` → `model.keys_property`      |
 
 ## Detailed Breaking Changes
 
@@ -273,6 +274,50 @@ serialized_dict = as_attribute_dict(model, exclude_readonly=False)
 serialized_dict = as_attribute_dict(model, exclude_readonly=True)
 ```
 
+### Reserved Property Name Conflicts
+
+**What changed**: Hybrid models now inherit from Python's built-in `dict`. If a REST API property name collides with a `dict` method name (e.g. `keys`, `values`, `items`, `clear`, `update`, `get`, `pop`, `popitem`, `setdefault`, `copy`), the Python emitter appends `_property` to the generated attribute to avoid masking the dictionary method.
+
+**What will break**:
+
+- Constructor calls that pass reserved names as keyword arguments: `Model(keys=...)` will now pass the argument to the underlying `dict` constructor, which means the property value will not be set as expected and may result in a `TypeError` or unexpected behavior.
+- Attribute access expecting the property value: `model.keys` now refers to the method; calling it without parentheses will not return the property data.
+
+**Before**:
+
+```python
+from azure.mgmt.test.models import Model
+
+model = Model(keys={"a": 1}, values=[1, 2, 3])
+print(model.keys)      # Property value (old behavior)
+print(model.values)    # Property value (old behavior)
+print(model.as_dict()["keys"]) # REST layer value
+```
+
+**After**:
+
+```python
+from azure.mgmt.test.models import Model
+
+# Reserved property names receive a `_property` suffix
+model = Model(keys_property={"a": 1}, values_property=[1, 2, 3])
+
+print(model.keys_property)    # ✅ Property value
+print(model.values_property)  # ✅ Property value
+print(model["keys"])          # REST layer value
+
+# names without suffix are now dict methods
+print(list(model.keys()))     # ✅ Dict method listing all keys in the model
+print(list(model.values()))   # ✅ Dict method listing all values
+```
+
+**Migration steps:**
+
+1. Search for any usage of reserved names as constructor keywords or attribute accesses.
+2. Append `_property` to both initialization and attribute access: `Model(keys=...)` → `Model(keys_property=...)`; `model.keys` → `model.keys_property`.
+3. Update tests and documentation references accordingly.
+4. If you had dynamic code relying on `getattr(model, name)`, ensure you add a rule to transform reserved names to `name + "_property"` first.
+
 ---
 
 ## Additional Helper Methods

doc/tool_usage_guide.md

@@ -27,6 +27,7 @@ This repo is currently migrating all checks from a slower `tox`-based framework,
 |`verifysdist`| Verify directories included in sdist and contents in manifest file. Also ensures that py.typed configuration is correct within the setup.py. | `azpysdk verifysdist .` |
 |`verify_keywords`| Verify that the keyword 'azure sdk' is present in the targeted package's keywords. | `azpysdk verify_keywords .` |
 |`import_all`| Installs the package w/ default dependencies, then attempts to `import *` from the base namespace. Ensures that all imports will resolve after a base install and import. | `azpysdk import_all .` |
+|`breaking`| Checks for breaking changes. | `azpysdk breaking .` |
 
 ## Common arguments
 

eng/common/instructions/azsdk-tools/verify-setup.instructions.md

@@ -3,18 +3,17 @@ description: 'Verify Setup'
 ---
 
 ## Goal
-This tool verifies the developer's environment for SDK development and release tasks. It returns what requirements are missing for the specified languages and repo.
+This tool verifies the developer's environment for SDK development and release tasks. It returns what requirements are missing for the specified languages and repo, or success if all requirements are satisfied.
 
 Your goal is to identify the project repo root, and pass in the `packagePath` to the Verify Setup tool. For a language repo, pass in the language of the repo.
 
 ## Examples
 - in `azure-sdk-for-js`, run `azsdk_verify_setup` with `(langs=javascript, packagePath=<path>/azure-sdk-for-js)`.
-- in `azure-sdk-for-python`, run `azsdk_verify_setup` with `(langs=python, packagePath=<path>/azure-sdk-for-python, venvPath=<path-to-venv>)`.
 
 ## Parameter Requirements
-WHENEVER Python is included in `langs`, BEFORE RUNNING `azsdk_verify_setup`, you MUST ASK THE USER TO SPECIFY WHICH virtual environment they want to check. DO NOT ASSUME THE VENV WITHOUT ASKING THE USER. After obtaining the `venvPath`, you can run the tool.
-
-The user can specify multiple languages to check. If the user wants to check all languages, pass in ALL supported languages and STILL ASK for a `venvPath`. Passing in no languages will only check the core requirements.
+The user can specify multiple languages to check. If the user wants to check all languages, pass in ALL supported languages. Passing in no languages will only check the core requirements.
 
 ## Output
-Display results in a user-friendly and concise format, highlighting any missing dependencies that need to be addressed.
+Display results in a user-friendly and concise format, highlighting any missing dependencies that need to be addressed and how to resolve them.
+
+WHENEVER Python related requirements fail, ALWAYS ASK the user if they have set the `AZSDKTOOLS_PYTHON_VENV_PATH` system environment variable to their desired virtual environment. This tool can only check requirements in the venv path specified by that environment variable.