Skip to content

Commit 62e49b4

Browse files
authored
MoMo api review changes (#34670)
* api review * fix
1 parent 61e9c57 commit 62e49b4

File tree

1 file changed

+4
-15
lines changed

1 file changed

+4
-15
lines changed

sdk/ml/azure-ai-ml/azure/ai/ml/entities/_monitoring/thresholds.py

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -104,10 +104,6 @@ def _get_default_thresholds(cls) -> "NumericalDriftMetrics":
104104
normalized_wasserstein_distance=0.1,
105105
)
106106

107-
@classmethod
108-
def defaults(cls) -> "NumericalDriftMetrics":
109-
return cls._get_default_thresholds()
110-
111107

112108
class CategoricalDriftMetrics(RestTranslatableMixin):
113109
"""Categorical Drift Metrics
@@ -166,13 +162,6 @@ def _get_default_thresholds(cls) -> "CategoricalDriftMetrics":
166162
jensen_shannon_distance=0.1,
167163
)
168164

169-
@classmethod
170-
def defaults(cls) -> "CategoricalDriftMetrics":
171-
return cls._get_default_thresholds()
172-
173-
def get_name_and_threshold(self) -> Tuple:
174-
return self._find_name_and_threshold()
175-
176165

177166
class DataDriftMetricThreshold(MetricThreshold):
178167
"""Data drift metric threshold
@@ -241,8 +230,8 @@ def _from_rest_object(cls, obj: DataDriftMetricThresholdBase) -> "DataDriftMetri
241230
@classmethod
242231
def _get_default_thresholds(cls) -> "DataDriftMetricThreshold":
243232
return cls(
244-
numerical=NumericalDriftMetrics.defaults(),
245-
categorical=CategoricalDriftMetrics.defaults(),
233+
numerical=NumericalDriftMetrics._get_default_thresholds(),
234+
categorical=CategoricalDriftMetrics._get_default_thresholds(),
246235
)
247236

248237
def __eq__(self, other: Any) -> bool:
@@ -316,8 +305,8 @@ def _from_rest_object(cls, obj: PredictionDriftMetricThresholdBase) -> "Predicti
316305
@classmethod
317306
def _get_default_thresholds(cls) -> "PredictionDriftMetricThreshold":
318307
return cls(
319-
numerical=NumericalDriftMetrics.defaults(),
320-
categorical=CategoricalDriftMetrics.defaults(),
308+
numerical=NumericalDriftMetrics._get_default_thresholds(),
309+
categorical=CategoricalDriftMetrics._get_default_thresholds(),
321310
)
322311

323312
def __eq__(self, other: Any) -> bool:

0 commit comments

Comments
 (0)