code review feedback

Author: paulbatum

sdk/ai/azure-ai-projects/.env.template

@@ -44,6 +44,12 @@ AZURE_AI_PROJECTS_TESTS_CONTAINER_PROJECT_ENDPOINT=
 AZURE_AI_PROJECTS_TESTS_CONTAINER_APP_RESOURCE_ID=
 AZURE_AI_PROJECTS_TESTS_CONTAINER_INGRESS_SUBDOMAIN_SUFFIX=
 
+# Connection IDs and settings used in agent tool tests
+AZURE_AI_PROJECTS_TESTS_BING_PROJECT_CONNECTION_ID=
+AZURE_AI_PROJECTS_TESTS_AI_SEARCH_PROJECT_CONNECTION_ID=
+AZURE_AI_PROJECTS_TESTS_AI_SEARCH_INDEX_NAME=
+AZURE_AI_PROJECTS_TESTS_MCP_PROJECT_CONNECTION_ID=
+
 # Used in tools
 BING_PROJECT_CONNECTION_ID=
 MCP_PROJECT_CONNECTION_ID=

sdk/ai/azure-ai-projects/samples/agents/tools/sample_agent_bing_grounding.py

@@ -64,7 +64,7 @@
     # [END tool_declaration]
 
     agent = project_client.agents.create_version(
-        agent_name="bing-grounding-agent",
+        agent_name="MyAgent",
         definition=PromptAgentDefinition(
             model=os.environ["AZURE_AI_MODEL_DEPLOYMENT_NAME"],
             instructions="You are a helpful assistant.",

sdk/ai/azure-ai-projects/tests/agents/tools/README.md

@@ -14,11 +14,11 @@
 
 import os
 import pytest
+from io import BytesIO
 from test_base import TestBase, servicePreparer
 from devtools_testutils import is_live_and_not_recording
 from azure.ai.projects.models import PromptAgentDefinition, FileSearchTool, CodeInterpreterTool, CodeInterpreterToolAuto
 
-
 class TestAgentFileSearchAndCodeInterpreter(TestBase):
     """Tests for agents using File Search + Code Interpreter combination."""
 
@@ -40,9 +40,7 @@ def test_find_and_analyze_data(self, **kwargs):
 
         # Create data file
         txt_content = "Sample data: 10, 20, 30, 40, 50"
-        vector_store = openai_client.vector_stores.create(name="DataStore")
-
-        from io import BytesIO
+        vector_store = openai_client.vector_stores.create(name="DataStore")        
 
         txt_file = BytesIO(txt_content.encode("utf-8"))
         txt_file.name = "data.txt"

sdk/ai/azure-ai-projects/tests/agents/tools/multitool/__init__.py

@@ -85,14 +85,14 @@ def test_agent_ai_search_question_answering(self, **kwargs):
         openai_client = project_client.get_openai_client()
 
         # Get AI Search connection and index from environment
-        ai_search_connection_id = kwargs.get("azure_ai_projects_tests_ai_search_connection_id")
+        ai_search_connection_id = kwargs.get("azure_ai_projects_tests_ai_search_project_connection_id")
         ai_search_index_name = kwargs.get("azure_ai_projects_tests_ai_search_index_name")
 
         if not ai_search_connection_id:
-            pytest.skip("AI_SEARCH_PROJECT_CONNECTION_ID environment variable not set")
+            pytest.skip("AZURE_AI_PROJECTS_TESTS_AI_SEARCH_PROJECT_CONNECTION_ID environment variable not set")
 
         if not ai_search_index_name:
-            pytest.skip("AI_SEARCH_INDEX_NAME environment variable not set")
+            pytest.skip("AZURE_AI_PROJECTS_TESTS_AI_SEARCH_INDEX_NAME environment variable not set")
 
         assert isinstance(ai_search_connection_id, str), "ai_search_connection_id must be a string"
         assert isinstance(ai_search_index_name, str), "ai_search_index_name must be a string"

sdk/ai/azure-ai-projects/tests/agents/tools/multitool/test_agent_file_search_and_code_interpreter.py

@@ -151,17 +151,17 @@ async def test_agent_ai_search_question_answering_async_parallel(self, **kwargs)
         project_client = self.create_async_client(operation_group="agents", **kwargs)
 
         async with project_client:
-            openai_client = await project_client.get_openai_client()
+            openai_client = project_client.get_openai_client()
 
             # Get AI Search connection and index from environment
-            ai_search_connection_id = kwargs.get("azure_ai_projects_tests_ai_search_connection_id")
+            ai_search_connection_id = kwargs.get("azure_ai_projects_tests_ai_search_project_connection_id")
             ai_search_index_name = kwargs.get("azure_ai_projects_tests_ai_search_index_name")
 
             if not ai_search_connection_id:
-                pytest.skip("AI_SEARCH_PROJECT_CONNECTION_ID environment variable not set")
+                pytest.skip("AZURE_AI_PROJECTS_TESTS_AI_SEARCH_PROJECT_CONNECTION_ID environment variable not set")
 
             if not ai_search_index_name:
-                pytest.skip("AI_SEARCH_INDEX_NAME environment variable not set")
+                pytest.skip("AZURE_AI_PROJECTS_TESTS_AI_SEARCH_INDEX_NAME environment variable not set")
 
             assert isinstance(ai_search_connection_id, str), "ai_search_connection_id must be a string"
             assert isinstance(ai_search_index_name, str), "ai_search_index_name must be a string"