[mcp] add more tox validation (#41573)

* thi

* tox-uv?

* tox-uv option w/ copilot help

* this

* this

* this?

* this

* lets do this

* dotn need

* this

* merge pip function to one place

* comments

* formatting

* remove

* same for next

* tox-uv

* tox cache

* update

* this

Author: l0lawrence

.github/copilot-instructions.md

@@ -122,6 +122,24 @@ tox -e pyright -c [path to tox.ini] --root .
 
 # Step 3d: Verifytypes
 tox -e verifytypes -c [path to tox.ini] --root .
+
+# Step 3e: Sphinx
+tox -e sphinx -c [path to tox.ini] --root .
+
+# Step 3f: Mindependency
+tox -e mindependency -c [path to tox.ini] --root .
+
+# Step 3g: Bandit
+tox -e bandit -c [path to tox.ini] --root .
+
+# Step 3h: Black
+tox -e black -c [path to tox.ini] --root .
+
+# Step 3i: Samples
+tox -e samples -c [path to tox.ini] --root .
+
+# Step 3j: Breaking
+tox -e breaking -c [path to tox.ini] --root .
 ```
 
 **REQUIREMENTS:**

eng/tools/mcp/azure-sdk-python-mcp/main.py

@@ -11,6 +11,9 @@
 from github import Github
 from mcp.server.fastmcp import FastMCP
 
+# Set default pip implementation for tox to use uv
+os.environ.setdefault('TOX_PIP_IMPL', 'uv pip')
+
 # Create FastMCP instance
 mcp = FastMCP("azure-sdk-python-mcp")
 
@@ -24,6 +27,7 @@
 logger.info(f"Running with Python executable: {sys.executable}")
 logger.info(f"Virtual environment path: {os.environ.get('VIRTUAL_ENV', 'Not running in a virtual environment')}")
 logger.info(f"Working directory: {os.getcwd()}")
+logger.info(f"TOX_PIP_IMPL set to: {os.environ.get('TOX_PIP_IMPL', 'not set')}")
 
 def get_latest_commit(tspurl: str) -> str:
     """Get the latest commit hash for a given TypeSpec config URL.

eng/tools/mcp/azure-sdk-python-mcp/pyproject.toml

@@ -13,6 +13,7 @@ dependencies = [
     "pylint>=3.3.7",
     "tox>=4.26.0",
     "httpx>=0.24.0",
+    "tox-uv>=1.26.0",
 ]
 
 [project.scripts]

eng/tools/mcp/azure-sdk-python-mcp/uv.lock

@@ -19,7 +19,7 @@
 from packaging.version import Version
 
 from ci_tools.parsing import ParsedSetup, parse_require
-from ci_tools.functions import compare_python_version, handle_incompatible_minimum_dev_reqs
+from ci_tools.functions import compare_python_version, handle_incompatible_minimum_dev_reqs, get_pip_command
 
 from typing import List
 
@@ -366,12 +366,8 @@ def filter_dev_requirements(
 
 def install_packages(packages, req_file):
     # install list of given packages from PyPI
-    commands = [
-        sys.executable,
-        "-m",
-        "pip",
-        "install",
-    ]
+    commands = get_pip_command()
+    commands.append("install")
 
     if packages:
         commands.extend(packages)

eng/tox/install_depend_packages.py

@@ -19,7 +19,7 @@
 sys.path.append(common_task_path)
 
 from common_tasks import get_installed_packages
-from ci_tools.functions import discover_targeted_packages
+from ci_tools.functions import discover_targeted_packages, get_pip_command
 from ci_tools.parsing import ParsedSetup
 
 EXCLUDED_PKGS = [
@@ -61,12 +61,8 @@ def get_installed_azure_packages(pkg_name_to_exclude):
 
 def uninstall_packages(packages):
     # This method uninstall list of given packages so dev build version can be reinstalled
-    commands = [
-        sys.executable,
-        "-m",
-        "pip",
-        "uninstall",
-    ]
+    commands = get_pip_command()
+    commands.append("uninstall")
 
     logging.info("Uninstalling packages: %s", packages)
     commands.extend(packages)
@@ -79,12 +75,8 @@ def uninstall_packages(packages):
 def install_packages(packages):
     # install list of given packages from devops feed
 
-    commands = [
-        sys.executable,
-        "-m",
-        "pip",
-        "install",
-    ]
+    commands = get_pip_command()
+    commands.append("install")
 
     logging.info("Installing dev build version for packages: %s", packages)
     commands.extend(packages)

eng/tox/install_dev_build_dependency.py

@@ -22,11 +22,11 @@
 from ci_tools.parsing import ParsedSetup
 from ci_tools.environment_exclusions import is_check_enabled, is_typing_ignored
 from ci_tools.variables import in_ci
+from ci_tools.functions import get_pip_command
 
 logging.getLogger().setLevel(logging.INFO)
 root_dir = os.path.abspath(os.path.join(os.path.abspath(__file__), "..", "..", ".."))
 
-
 def install_from_main(setup_path: str) -> None:
     path = pathlib.Path(setup_path)
     subdirectory = path.relative_to(root_dir)
@@ -51,10 +51,7 @@ def install_from_main(setup_path: str) -> None:
 
             os.chdir(subdirectory)
 
-            command = [
-                sys.executable,
-                "-m",
-                "pip",
+            command = get_pip_command() + [
                 "install",
                 ".",
                 "--force-reinstall"

eng/tox/run_verifytypes.py

@@ -5,6 +5,17 @@
 
 # In all cases, whenever we install an azure-* package from a requirement (read: not a specific file), the only source will be from the dev feed.
 # once we've downloaded these dependencies, only then do we install other packages from pypi.
+
+# INSTALLER SELECTION:
+# You can control which pip implementation is used by setting the TOX_PIP_IMPL environment variable:
+# - TOX_PIP_IMPL=pip (default) - Uses standard pip for package installation
+# - TOX_PIP_IMPL=uv - Uses uv pip for faster package installation
+# 
+# Example usage:
+#   tox -e pylint                                                    # Use standard pip (default)
+#   TOX_PIP_IMPL=pip tox -e pylint                                  # Use standard pip explicitly
+#   TOX_PIP_IMPL=uv tox -e pylint                                  # Use uv for faster installation
+
 [tox]
 requires=
   # Ensure that we're running a version of tox compatible with this config
@@ -13,6 +24,10 @@ requires=
   tox>=4.4.10
 # note that this envlist is the default set of environments that will run if a target environment is not selected.
 envlist = whl,sdist
+# Environment variable controlled installer configuration
+# Set TOX_PIP_IMPL=uv pip to use uv pip, or TOX_PIP_IMPL=pip (default) to use standard pip
+pip_impl = {env:TOX_PIP_IMPL:pip}
+pip_command = {[tox]pip_impl}
 
 
 [tools]
@@ -51,27 +66,28 @@ ignore_args=--ignore=.tox --ignore=build --ignore=.eggs --ignore=samples
 default_args = -rsfE --junitxml={tox_root}/test-junit-{envname}.xml --verbose --cov-branch --durations=10 --ignore=azure {[pytest]ignore_args} --log-cli-level={pytest_log_level}
 
 [testenv]
+uv_seed = true
 parallel_show_output =True
 skip_install = true
 skipsdist = true
 usedevelop = false
 passenv = *
 download=true
+# Allow both pip and uv as external commands since we support both via TOX_PIP_IMPL
+allowlist_externals = uv,pip
 requires=
   {[packaging]pkgs}
 setenv =
   SPHINX_APIDOC_OPTIONS=members,undoc-members,inherited-members
-  PIP_EXTRA_INDEX_URL=https://pypi.python.org/simple
   PROXY_URL=http://localhost:5000
   VIRTUALENV_WHEEL=0.45.1
   VIRTUALENV_PIP=24.0
   VIRTUALENV_SETUPTOOLS=75.3.2
+  PIP_EXTRA_INDEX_URL=https://pypi.python.org/simple
 deps = {[base]deps}
-install_command = python -m pip install {opts} {packages} --cache-dir {tox_root}/../.tox_pip_cache_{envname}
+install_command = python -m {[tox]pip_command} install {opts} {packages} --cache-dir {tox_root}/../.tox_pip_cache_{envname}
 commands =
-    python -m pip --version
     python {repository_root}/eng/tox/create_package_and_install.py -d {envtmpdir} -p {tox_root} -w {envtmpdir}
-    python -m pip freeze
     pytest {[pytest]default_args} {posargs} {tox_root}
     python {repository_root}/eng/tox/run_coverage.py -t {tox_root} -r {repository_root}
 
@@ -91,8 +107,8 @@ setenv =
 deps =
   -rdev_requirements.txt
 commands =
-    python -m pip install pylint=={[testenv:pylint]pylint_version}
-    python -m pip install azure-pylint-guidelines-checker==0.5.6 --index-url="https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-python/pypi/simple/"
+    python -m {[tox]pip_command} install pylint=={[testenv:pylint]pylint_version}
+    python -m {[tox]pip_command} install azure-pylint-guidelines-checker==0.5.6 --index-url="https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-python/pypi/simple/"
     python {repository_root}/eng/tox/create_package_and_install.py \
       -d {envtmpdir}/dist \
       -p {tox_root} \
@@ -116,8 +132,8 @@ deps =
   -rdev_requirements.txt
   PyGitHub>=1.59.0
 commands =
-    python -m pip install pylint=={[testenv:next-pylint]pylint_version}
-    python -m pip install azure-pylint-guidelines-checker==0.5.6 --index-url="https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-python/pypi/simple/"
+    python -m {[tox]pip_command} install pylint=={[testenv:next-pylint]pylint_version}
+    python -m {[tox]pip_command} install azure-pylint-guidelines-checker==0.5.6 --index-url="https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-python/pypi/simple/"
     python {repository_root}/eng/tox/create_package_and_install.py \
       -d {envtmpdir}/dist \
       -p {tox_root} \
@@ -272,10 +288,10 @@ setenv =
   {[testenv]setenv}
   PROXY_URL=http://localhost:5004
 commands =
-    - python -m pip uninstall aiohttp --yes
+    - python -m {[tox]pip_command} uninstall aiohttp --yes
     python {repository_root}/eng/tox/create_package_and_install.py -d {envtmpdir} -p {tox_root} -w {envtmpdir}
     python {repository_root}/eng/tox/try_import.py aiohttp -p {tox_root}
-    python -m pip freeze
+    python -m {[tox]pip_command} freeze
     pytest {[pytest]default_args} --ignore-glob='*async*.py' {posargs} --no-cov {tox_root}
 
 
@@ -297,7 +313,7 @@ commands =
       -p {tox_root} \
       -w {envtmpdir} \
       --package-type sdist
-    python -m pip freeze
+    python -m {[tox]pip_command} freeze
     pytest {posargs} --no-cov {[pytest]ignore_args} {tox_root}
 
 
@@ -380,12 +396,12 @@ setenv =
 deps =
   {[packaging]pkgs}
 commands =
-    python -m pip install {repository_root}/tools/azure-sdk-tools --no-deps
+    python -m {[tox]pip_command} install {repository_root}/tools/azure-sdk-tools --no-deps
     python {repository_root}/eng/tox/create_package_and_install.py \
       -d {envtmpdir} \
       -p {tox_root} \
       -w {envtmpdir}
-    python -m pip freeze
+    python -m {[tox]pip_command} freeze
     python {repository_root}/eng/tox/import_all.py -t {tox_root}
 
 
@@ -399,7 +415,7 @@ setenv =
 deps =
     {[packaging]pkgs}
 commands =
-    python -m pip install {repository_root}/tools/azure-sdk-tools --no-deps
+    python -m {[tox]pip_command} install {repository_root}/tools/azure-sdk-tools --no-deps
     python {repository_root}/eng/tox/create_package_and_install.py -d {envtmpdir} -p {tox_root} --skip-install True
     python {repository_root}/eng/tox/verify_whl.py -d {envtmpdir} -t {tox_root}
 
@@ -409,12 +425,11 @@ description=Verify directories included in sdist and contents in manifest file.
 skipsdist = true
 skip_install = true
 setenv =
-  {[testenv]setenv}
-  PROXY_URL=http://localhost:5010
+  {[testenv]setenv}  PROXY_URL=http://localhost:5010
 deps =
     {[packaging]pkgs}
 commands =
-    python -m pip install {repository_root}/tools/azure-sdk-tools --no-deps
+    python -m {[tox]pip_command} install {repository_root}/tools/azure-sdk-tools --no-deps
     python {tox_root}/setup.py --q sdist -d {envtmpdir}
     python {repository_root}/eng/tox/verify_sdist.py -d {envtmpdir} -t {tox_root}
 
@@ -435,7 +450,7 @@ commands =
 commands =
     python {repository_root}/eng/tox/install_depend_packages.py -t {tox_root} -d {env:DEPENDENCY_TYPE:} -w {envtmpdir}
     python {repository_root}/eng/tox/create_package_and_install.py -d {envtmpdir} -p {tox_root} -w {envtmpdir} --pre-download-disabled
-    python -m pip freeze
+    python -m {[tox]pip_command} freeze
     python {repository_root}/eng/tox/verify_installed_packages.py --packages-file {envtmpdir}/packages.txt
     pytest {[pytest]default_args} {posargs} --no-cov {tox_root}
 
@@ -484,8 +499,8 @@ deps =
   {[base]deps}
 commands =
     # install API stub generator
-    python -m pip install -r {repository_root}/eng/apiview_reqs.txt --index-url="https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-python/pypi/simple/"
-    python -m pip freeze
+    python -m {[tox]pip_command} install -r {repository_root}/eng/apiview_reqs.txt --index-url="https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-python/pypi/simple/"
+    python -m {[tox]pip_command} freeze
     python {repository_root}/eng/tox/run_apistubgen.py -t {tox_root} -w {envtmpdir} {posargs}
 
 
@@ -501,7 +516,7 @@ setenv =
 deps =
   {[base]deps}
 commands =
-    python -m pip freeze
+    python -m {[tox]pip_command} freeze
     python {repository_root}/eng/tox/run_bandit.py -t {tox_root}
 
 
@@ -518,7 +533,7 @@ deps =
   {[base]deps}
   subprocess32; python_version < '3.5'
 commands =
-    python -m pip freeze
+    python -m {[tox]pip_command} freeze
     python {repository_root}/scripts/devops_tasks/test_run_samples.py -t {tox_root}
 
 
@@ -584,5 +599,5 @@ setenv =
   {[testenv]setenv}
   PROXY_URL=http://localhost:5018
 commands =
-    {envbindir}/python -m pip install {toxinidir}/../../../tools/azure-sdk-tools[build]
+    {envbindir}/python -m {[tox]pip_command} install {toxinidir}/../../../tools/azure-sdk-tools[build]
     python {repository_root}/eng/tox/run_optional.py -t {toxinidir} --temp={envtmpdir} {posargs}

eng/tox/tox.ini

@@ -927,3 +927,20 @@ def verify_package_classifiers(package_name: str, package_version: str, package_
         if num < 5:
             return False, f"{package_name} has version {package_version} and is a GA release, but had development status '{c}'. Expecting a development classifier that is equal or greater than 'Development Status :: 5 - Production/Stable'."
     return True, None
+
+def get_pip_command(python_exe: Optional[str] = None) -> List[str]:
+    """
+    Determine whether to use 'uv pip' or regular 'pip' based on environment.
+
+    :param str python_exe: The Python executable to use (if not using the default).
+    :return: List of command arguments for pip.
+    :rtype: List[str]
+    
+    """
+    # Check TOX_PIP_IMPL environment variable (aligns with tox.ini configuration)
+    pip_impl = os.environ.get('TOX_PIP_IMPL', 'pip').lower()
+
+    if pip_impl == 'uv':
+        return ["uv", "pip"]
+    else:
+        return [python_exe if python_exe else sys.executable, "-m", "pip"]

tools/azure-sdk-tools/ci_tools/functions.py

@@ -14,13 +14,13 @@
     discover_prebuilt_package,
     pip_install,
     pip_uninstall,
+    get_pip_command,
 )
 from ci_tools.build import cleanup_build_artifacts, create_package
 from ci_tools.parsing import ParsedSetup, parse_require
 from ci_tools.functions import get_package_from_repo_or_folder, find_whl, get_pip_list_output, pytest
 from .managed_virtual_env import ManagedVirtualEnv
 
-
 def prepare_environment(package_folder: str, venv_directory: str, env_name: str) -> str:
     """
     Empties the venv_directory directory and creates a virtual environment within. Returns the path to the new python executable.
@@ -112,10 +112,8 @@ def create_package_and_install(
                         "Found {} azure requirement(s): {}".format(len(azure_requirements), azure_requirements)
                     )
 
-                    download_command = [
-                        python_exe,
-                        "-m",
-                        "pip",
+                    pip_cmd = get_pip_command(python_exe)
+                    download_command = pip_cmd + [
                         "download",
                         "-d",
                         tmp_dl_folder,
@@ -174,7 +172,8 @@ def create_package_and_install(
                             for package_name in non_present_reqs
                         ]
 
-            commands = [python_exe, "-m", "pip", "install", built_pkg_path]
+            pip_cmd = get_pip_command(python_exe)
+            commands = pip_cmd + ["install", built_pkg_path]
             commands.extend(additional_downloaded_reqs)
             commands.extend(commands_options)