Skip to content

Commit 7abfac8

Browse files
Fixed File Share tests
1 parent 9b6be82 commit 7abfac8

File tree

2 files changed

+8
-18
lines changed

2 files changed

+8
-18
lines changed

sdk/storage/azure-storage-file-share/tests/test_file.py

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4023,21 +4023,16 @@ def test_download_file_no_decompress_chunks(self, **kwargs):
40234023
share_name=self.share_name,
40244024
file_path=file_name,
40254025
credential=storage_account_key,
4026-
max_range_size=4 * 1024
4026+
max_chunk_get_size=4,
4027+
max_single_get_size=4,
40274028
)
40284029
compressed_data = b'\x1f\x8b\x08\x00\x00\x00\x00\x00\x00\xff\xcaH\xcd\xc9\xc9WH+\xca\xcfUH\xaf\xca,\x00\x00\x00\x00\xff\xff\x03\x00d\xaa\x8e\xb5\x0f\x00\x00\x00'
40294030
content_settings = ContentSettings(content_encoding='gzip')
40304031

40314032
# Act / Assert
40324033
file_client.upload_file(data=compressed_data, content_settings=content_settings)
40334034

4034-
chunk_size=4
4035-
data = bytearray()
4036-
for offset in range(0, len(compressed_data), chunk_size):
4037-
stream = file_client.download_file(offset=offset, length=chunk_size, decompress=False)
4038-
chunk = stream.readall()
4039-
assert chunk == compressed_data[offset:offset+chunk_size]
4040-
data.extend(chunk)
4041-
assert data == compressed_data
4035+
result = file_client.download_file(decompress=False).readall()
4036+
assert result == compressed_data
40424037

40434038
# ------------------------------------------------------------------------------

sdk/storage/azure-storage-file-share/tests/test_file_async.py

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4152,19 +4152,14 @@ async def test_download_file_no_decompress_chunks(self, **kwargs):
41524152
share_name=self.share_name,
41534153
file_path=file_name,
41544154
credential=storage_account_key,
4155-
max_range_size=4 * 1024
4155+
max_chunk_get_size=4,
4156+
max_single_get_size=4,
41564157
)
41574158
compressed_data = b'\x1f\x8b\x08\x00\x00\x00\x00\x00\x00\xff\xcaH\xcd\xc9\xc9WH+\xca\xcfUH\xaf\xca,\x00\x00\x00\x00\xff\xff\x03\x00d\xaa\x8e\xb5\x0f\x00\x00\x00'
41584159
content_settings = ContentSettings(content_encoding='gzip')
41594160

41604161
# Act / Assert
41614162
await file_client.upload_file(data=compressed_data, content_settings=content_settings)
41624163

4163-
chunk_size = 4
4164-
data = bytearray()
4165-
for offset in range(0, len(compressed_data), chunk_size):
4166-
stream = await file_client.download_file(offset=offset, length=chunk_size, decompress=False)
4167-
chunk = await stream.readall()
4168-
assert chunk == compressed_data[offset:offset + chunk_size]
4169-
data.extend(chunk)
4170-
assert data == compressed_data
4164+
result = await (await file_client.download_file(decompress=False)).readall()
4165+
assert result == compressed_data

0 commit comments

Comments
 (0)