Address Condition Failure (#36423)

* ensuring that our common template calls are properly conditioned

Author: scbedd

eng/pipelines/templates/jobs/ci.yml

@@ -196,7 +196,7 @@ jobs:
         - 'CoalesceBuildArtifacts'
       - ${{ else }}:
         - 'Build'
-      
+
     timeoutInMinutes: 90
 
     pool:
@@ -247,6 +247,7 @@ jobs:
         ${{ if ne(variables['Build.Reason'], 'PullRequest') }}:
           Directory: sdk/${{ parameters.ServiceDirectory }}
         CheckLinkGuidance: $true
+        Condition: succeededOrFailed()
 
     - task: DownloadPipelineArtifact@2
       condition: succeededOrFailed()

eng/pipelines/templates/steps/analyze.yml

@@ -27,6 +27,7 @@ steps:
 
   - task: PythonScript@0
     displayName: 'Set Tox Environment Skips'
+    condition: succeededOrFailed()
     inputs:
       scriptPath: 'scripts/devops_tasks/set_tox_environment.py'
       arguments: '"$(TargetingString)" --team-project="$(System.TeamProject)" --service="${{ parameters.ServiceDirectory }}"'
@@ -38,6 +39,7 @@ steps:
           PackageName: ${{artifact.name}}
           ServiceName: ${{parameters.ServiceDirectory}}
           ForRelease: false
+          Condition: succeededOrFailed()
 
   - script: |
       python -m pip install "./tools/azure-sdk-tools[build]" -q -I
@@ -60,10 +62,12 @@ steps:
         }
       }
     displayName: Check for CRLF Line endings
+    condition: succeededOrFailed()
 
   - template: /eng/common/pipelines/templates/steps/verify-path-length.yml
     parameters:
       SourceDirectory: $(Build.SourcesDirectory)
+      Condition: succeededOrFailed()
 
   - template: ../steps/verify-autorest.yml
     parameters:
@@ -73,7 +77,7 @@ steps:
   - template: ../steps/set-dev-build.yml
     parameters:
       ServiceDirectory: ${{ parameters.ServiceDirectory }}
-      
+
   - task: PythonScript@0
     displayName: 'Verify sdist'
     condition: and(succeededOrFailed(), ne(variables['Skip.VerifySdist'],'true'))

eng/pipelines/templates/steps/analyze_dependency.yml

@@ -17,6 +17,7 @@ steps:
   - template: /eng/common/pipelines/templates/steps/verify-readme.yml
     parameters:
       ScanPath: ${{ parameters.ScanPath }}
+      Condition: succeededOrFailed()
 
   - pwsh: |
       sdk_analyze_deps --verbose --out "$(Build.ArtifactStagingDirectory)/reports/dependencies.html" --dump "$(Build.ArtifactStagingDirectory)/reports"

eng/pipelines/templates/steps/build-package-artifacts.yml

@@ -97,7 +97,7 @@ steps:
       twine check $(Build.ArtifactStagingDirectory)/**/*.whl
       twine check $(Build.ArtifactStagingDirectory)/**/*.tar.gz
     displayName: 'Verify Readme'
-    condition: and(succeeded(), eq(variables['Agent.OS'], 'Linux'))
+    condition: and(succeededOrFailed(), eq(variables['Agent.OS'], 'Linux'))
 
   - ${{ parameters.BeforePublishSteps }}
 

eng/pipelines/templates/steps/set-dev-build.yml

@@ -11,6 +11,7 @@ steps:
   - template: /eng/common/pipelines/templates/steps/daily-dev-build-variable.yml
     parameters:
       ServiceDirectory: ${{ parameters.ServiceDirectory }}
+      Condition: succeededOrFailed()
 
   - pwsh: |
       python -m pip install "tools/azure-sdk-tools[build]"