Skip to content

Commit 7ef2a3f

Browse files
authored
Provider Revert Init (#37260)
* Making change unbreaking for API * removing endpoint
1 parent b2e0cd8 commit 7ef2a3f

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

sdk/appconfiguration/azure-appconfiguration-provider/azure/appconfiguration/provider/_azureappconfigurationprovider.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -317,10 +317,11 @@ def _buildprovider(
317317
if not endpoint:
318318
raise ValueError("No endpoint specified.")
319319

320+
kwargs["endpoint"] = endpoint
320321
kwargs["connection_string"] = connection_string
321322
kwargs["credential"] = credential
322323

323-
return AzureAppConfigurationProvider(endpoint, **kwargs)
324+
return AzureAppConfigurationProvider(**kwargs)
324325

325326

326327
def _resolve_keyvault_reference(
@@ -450,7 +451,8 @@ class AzureAppConfigurationProvider(Mapping[str, Union[str, JSON]]): # pylint:
450451
keys. Enables resolution of Key Vault references in configuration settings.
451452
"""
452453

453-
def __init__(self, endpoint, **kwargs) -> None:
454+
def __init__(self, **kwargs) -> None:
455+
endpoint = kwargs.pop("endpoint", None)
454456
self._origin_endpoint = endpoint
455457

456458
if "user_agent" in kwargs:

sdk/appconfiguration/azure-appconfiguration-provider/azure/appconfiguration/provider/aio/_azureappconfigurationproviderasync.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -246,11 +246,11 @@ async def _buildprovider(
246246
if not endpoint:
247247
raise ValueError("No endpoint specified.")
248248

249+
kwargs["endpoint"] = endpoint
249250
kwargs["connection_string"] = connection_string
250251
kwargs["credential"] = credential
251252

252-
provider = AzureAppConfigurationProvider(endpoint, **kwargs)
253-
return provider
253+
return AzureAppConfigurationProvider(**kwargs)
254254

255255

256256
async def _resolve_keyvault_reference(
@@ -308,7 +308,8 @@ class AzureAppConfigurationProvider(Mapping[str, Union[str, JSON]]): # pylint:
308308
keys. Enables resolution of Key Vault references in configuration settings.
309309
"""
310310

311-
def __init__(self, endpoint, **kwargs) -> None:
311+
def __init__(self, **kwargs) -> None:
312+
endpoint = kwargs.pop("endpoint", None)
312313
self._origin_endpoint = endpoint
313314

314315
if "user_agent" in kwargs:

0 commit comments

Comments
 (0)