Howie/next lint (#41621)

* Fix pylintrc to exclude agents generated code (#41612)

* Fix pylintrc to exclude agents generated code

* Update pylintrc

Co-authored-by: Copilot <[email protected]>

* Resolved

* Update eng/pylintrc

* Update pylintrc

---------

Co-authored-by: Copilot <[email protected]>
Co-authored-by: Libba Lawrence <[email protected]>

* Fix lint

---------

Co-authored-by: Copilot <[email protected]>
Co-authored-by: Libba Lawrence <[email protected]>

Author: 3 people

eng/pylintrc

@@ -6,7 +6,7 @@ reports=no
 ignore-paths=
     azure\\mixedreality\\remoterendering\\_api_version.py,
     azure/mixedreality/remoterendering/_api_version.py,
-    (?:.*[/\\]|^)projects/(models/_models.py|_model_base.py|operations/_operations.py|aio/operations/_operations.py)$,
+    (?:.*[/\\]|^).*[/\\](projects|agents)[/\\](models/_models.py|_model_base.py|operations/_operations.py|aio/operations/_operations.py)$,
     # Exclude any path that contains the following directory names
     (?:.*[/\\]|^)(?:_vendor|_generated|_restclient|samples|examples|test|tests|doc|\.tox)(?:[/\\]|$)
 

pylintrc

@@ -7,8 +7,7 @@ reports=no
 ignore-paths=
     azure\\mixedreality\\remoterendering\\_api_version.py,
     azure/mixedreality/remoterendering/_api_version.py,
-    (?:.*[/\\]|^)projects/(models/_models.py|_model_base.py|operations/_operations.py|aio/operations/_operations.py)$,
-    (?:.*[/\\]|^)agents/(models/_models.py|_model_base.py|operations/_operations.py|aio/operations/_operations.py)$,
+    (?:.*[/\\]|^).*[/\\](projects|agents)[/\\](models/_models.py|_model_base.py|operations/_operations.py|aio/operations/_operations.py)$,
     # Exclude any path that contains the following directory names
     (?:.*[/\\]|^)(?:_vendor|_generated|_restclient|samples|examples|test|tests|doc|\.tox)(?:[/\\]|$)
 

sdk/ai/azure-ai-agents/azure/ai/agents/aio/operations/_patch.py

@@ -1614,7 +1614,10 @@ def write_file(collected_chunks: list):
             logger.debug("File '%s' saved successfully at '%s'.", sanitized_file_name, target_file_path)
 
         except (ValueError, RuntimeError, TypeError, IOError) as e:
-            logger.error("An error occurred in save_file: %s", e)
+            logger.error(  # pylint: disable=do-not-log-exceptions-if-not-debug, do-not-log-raised-errors
+                "An error occurred in save_file: %s",
+                e,
+            )
             raise
 
     @distributed_trace_async

sdk/ai/azure-ai-agents/azure/ai/agents/models/_patch.py

@@ -1126,7 +1126,7 @@ def _create_tool_resources_from_dict(self, resources: Dict[str, Any]) -> ToolRes
         try:
             return ToolResources(**resources)
         except TypeError as e:
-            logger.error("Error creating ToolResources: %s", e)
+            logger.error("Error creating ToolResources: %s", e)  # pylint: disable=do-not-log-exceptions-if-not-debug
             raise ValueError("Invalid resources for ToolResources.") from e
 
     def get_definitions_and_resources(self) -> Dict[str, Any]:
@@ -1432,8 +1432,8 @@ async def _process_event(self, event_data_str: str) -> Tuple[str, StreamEventDat
                 func_rt = await self.on_unhandled_event(
                     event_type, event_data_obj
                 )  # pylint: disable=assignment-from-none
-        except Exception as e:  # pylint: disable=broad-exception-caught
-            logger.error("Error in event handler for event '%s': %s", event_type, e)
+        except Exception:  # pylint: disable=broad-exception-caught
+            logger.error("Error in event handler for event '%s'", event_type)
         return event_type, event_data_obj, func_rt
 
     async def on_message_delta(
@@ -1559,8 +1559,8 @@ def _process_event(self, event_data_str: str) -> Tuple[str, StreamEventData, Opt
                 func_rt = self.on_done()  # pylint: disable=assignment-from-none
             else:
                 func_rt = self.on_unhandled_event(event_type, event_data_obj)  # pylint: disable=assignment-from-none
-        except Exception as e:  # pylint: disable=broad-exception-caught
-            logger.error("Error in event handler for event '%s': %s", event_type, e)
+        except Exception:  # pylint: disable=broad-exception-caught
+            logger.debug("Error in event handler for event '%s'", event_type)
         return event_type, event_data_obj, func_rt
 
     def on_message_delta(

sdk/ai/azure-ai-agents/azure/ai/agents/operations/_patch.py

@@ -1614,7 +1614,9 @@ def save(self, file_id: str, file_name: str, target_dir: Optional[Union[str, Pat
             logger.debug("File '%s' saved successfully at '%s'.", sanitized_file_name, target_file_path)
 
         except (ValueError, RuntimeError, TypeError, IOError) as e:
-            logger.error("An error occurred in save_file: %s", e)
+            logger.error(  # pylint: disable=do-not-log-exceptions-if-not-debug, do-not-log-raised-errors
+                "An error occurred in save_file: %s", e
+            )
             raise
 
     @distributed_trace

sdk/ai/azure-ai-agents/azure/ai/agents/telemetry/_ai_agents_instrumentor.py

@@ -1839,15 +1839,17 @@ def _generate_api_and_injector(self, apis):
                         yield api, method_name, trace_type, injector, name
                 except AttributeError as e:
                     # Log the attribute exception with the missing class information
-                    logger.warning(
+                    logger.warning(  # pylint: disable=do-not-log-exceptions-if-not-debug
                         "AttributeError: The module '%s' does not have the class '%s'. %s",
                         module_name,
                         class_name,
                         str(e),
                     )
                 except Exception as e:  # pylint: disable=broad-except
                     # Log other exceptions as a warning, as we are not sure what they might be
-                    logger.warning("An unexpected error occurred: '%s'", str(e))
+                    logger.warning(  # pylint: disable=do-not-log-exceptions-if-not-debug
+                        "An unexpected error occurred: '%s'", str(e)
+                    )
 
     def _available_agents_apis_and_injectors(self):
         """