[Storage] Fix Public Access Tests (w/ recordings) (#36593)

Author: vincenttran-msft

sdk/storage/azure-storage-blob/assets.json

@@ -2,5 +2,5 @@
   "AssetsRepo": "Azure/azure-sdk-assets",
   "AssetsRepoPrefixPath": "python",
   "TagPrefix": "python/storage/azure-storage-blob",
-  "Tag": "python/storage/azure-storage-blob_4bb162f320"
+  "Tag": "python/storage/azure-storage-blob_adfb24f3d6"
 }

sdk/storage/azure-storage-blob/tests/test_common_blob.py

@@ -1881,72 +1881,6 @@ def test_create_blob_blob_unicode_data(self, **kwargs):
         # Assert
         assert resp.get('etag') is not None
 
-    @pytest.mark.live_test_only
-    @BlobPreparer()
-    def test_no_sas_private_blob(self, **kwargs):
-        # Test Proxy playback does not currently work with requests outside SDK clients
-        storage_account_name = kwargs.pop("storage_account_name")
-        storage_account_key = kwargs.pop("storage_account_key")
-
-        self._setup(storage_account_name, storage_account_key)
-        blob_name = self._create_block_blob()
-        blob = self.bsc.get_blob_client(self.container_name, blob_name)
-
-        # Act
-        response = requests.get(blob.url)
-
-        # Assert
-        assert not response.ok
-        assert -1 != response.text.find('ResourceNotFound')
-
-    @pytest.mark.live_test_only
-    @BlobPreparer()
-    def test_no_sas_public_blob(self, **kwargs):
-        # Test Proxy playback does not currently work with requests outside SDK clients
-        storage_account_name = kwargs.pop("storage_account_name")
-        storage_account_key = kwargs.pop("storage_account_key")
-
-        self._setup(storage_account_name, storage_account_key)
-        data = b'a public blob can be read without a shared access signature'
-        blob_name = 'blob1.txt'
-        container_name = self._get_container_reference()
-        try:
-            container = self.bsc.create_container(container_name, public_access='blob')
-        except ResourceExistsError:
-            container = self.bsc.get_container_client(container_name)
-        blob = container.upload_blob(blob_name, data, overwrite=True)
-
-        # Act
-        response = requests.get(blob.url)
-
-        # Assert
-        assert response.ok
-        assert data == response.content
-
-    @BlobPreparer()
-    @recorded_by_proxy
-    def test_public_access_blob(self, **kwargs):
-        storage_account_name = kwargs.pop("storage_account_name")
-        storage_account_key = kwargs.pop("storage_account_key")
-
-        self._setup(storage_account_name, storage_account_key)
-        data = b'public access blob'
-        blob_name = 'blob1.txt'
-        container_name = self._get_container_reference()
-        try:
-            container = self.bsc.create_container(container_name, public_access='blob')
-        except ResourceExistsError:
-            container = self.bsc.get_container_client(container_name)
-        blob = container.upload_blob(blob_name, data, overwrite=True)
-
-        # Act
-        service = BlobClient.from_blob_url(blob.url)
-        #self._set_test_proxy(service, self.settings)
-        content = service.download_blob().readall()
-
-        # Assert
-        assert data == content
-
     @pytest.mark.live_test_only
     @BlobPreparer()
     def test_sas_access_blob(self, **kwargs):
@@ -3494,4 +3428,4 @@ def test_upload_blob_partial_stream_chunked(self, **kwargs):
         result = blob.download_blob().readall()
         assert result == data[:length]
 
-    # ------------------------------------------------------------------------------
+    # ------------------------------------------------------------------------------

sdk/storage/azure-storage-blob/tests/test_common_blob_async.py

@@ -2107,74 +2107,6 @@ async def test_create_blob_blob_unicode_data(self, **kwargs):
         # Assert
         assert resp.get('etag') is not None
 
-    @pytest.mark.live_test_only
-    @BlobPreparer()
-    async def test_no_sas_private_blob(self, **kwargs):
-        # Test Proxy playback does not currently work with requests outside SDK clients
-        storage_account_name = kwargs.pop("storage_account_name")
-        storage_account_key = kwargs.pop("storage_account_key")
-
-        # Arrange
-        await self._setup(storage_account_name, storage_account_key)
-        blob_name = await self._create_block_blob()
-        blob = self.bsc.get_blob_client(self.container_name, blob_name)
-
-        # Act
-        response = requests.get(blob.url)
-
-        # Assert
-        assert not response.ok
-        assert -1 != response.text.find('ResourceNotFound')
-
-    @pytest.mark.live_test_only
-    @BlobPreparer()
-    async def test_no_sas_public_blob(self, **kwargs):
-        # Test Proxy playback does not currently work with requests outside SDK clients
-        storage_account_name = kwargs.pop("storage_account_name")
-        storage_account_key = kwargs.pop("storage_account_key")
-
-        # Arrange
-        await self._setup(storage_account_name, storage_account_key)
-        data = b'a public blob can be read without a shared access signature'
-        blob_name = 'blob1.txt'
-        container_name = self._get_container_reference()
-        try:
-            container = await self.bsc.create_container(container_name, public_access='blob')
-        except ResourceExistsError:
-            container = self.bsc.get_container_client(container_name)
-        blob = await container.upload_blob(blob_name, data)
-
-        # Act
-        response = requests.get(blob.url)
-
-        # Assert
-        assert response.ok
-        assert data == response.content
-
-    @BlobPreparer()
-    @recorded_by_proxy_async
-    async def test_public_access_blob(self, **kwargs):
-        storage_account_name = kwargs.pop("storage_account_name")
-        storage_account_key = kwargs.pop("storage_account_key")
-
-        # Arrange
-        await self._setup(storage_account_name, storage_account_key)
-        data = b'public access blob'
-        blob_name = 'blob1.txt'
-        container_name = self._get_container_reference()
-        try:
-            container = await self.bsc.create_container(container_name, public_access='blob')
-        except ResourceExistsError:
-            container = self.bsc.get_container_client(container_name)
-        blob = await container.upload_blob(blob_name, data)
-
-        # Act
-        service = BlobClient.from_blob_url(blob.url)
-        content = await (await service.download_blob()).readall()
-
-        # Assert
-        assert data == content
-
     @pytest.mark.live_test_only
     @BlobPreparer()
     async def test_sas_access_blob(self, **kwargs):
@@ -3418,4 +3350,4 @@ async def test_upload_blob_partial_stream_chunked(self, **kwargs):
         # Assert
         result = await (await blob.download_blob()).readall()
         assert result == data[:length]
-# ------------------------------------------------------------------------------
+# ------------------------------------------------------------------------------

sdk/storage/azure-storage-blob/tests/test_container.py

@@ -88,6 +88,7 @@ def test_create_container_with_already_existing_container_fail_on_exist(self, **
         # Assert
         assert created
 
+    @pytest.mark.playback_test_only
     @BlobPreparer()
     @recorded_by_proxy
     def test_create_container_with_public_access_container(self, **kwargs):
@@ -104,6 +105,7 @@ def test_create_container_with_public_access_container(self, **kwargs):
         # Assert
         assert created
 
+    @pytest.mark.playback_test_only
     @BlobPreparer()
     @recorded_by_proxy
     def test_create_container_with_public_access_blob(self, **kwargs):
@@ -329,6 +331,7 @@ def test_list_containers_with_include_metadata(self, **kwargs):
         self.assertNamedItemInContainer(containers, container.container_name)
         assert containers[0].metadata == metadata
 
+    @pytest.mark.playback_test_only
     @BlobPreparer()
     @recorded_by_proxy
     def test_list_containers_with_public_access(self, **kwargs):
@@ -681,6 +684,7 @@ def test_set_container_acl_with_lease_id(self, **kwargs):
 
         return variables
 
+    @pytest.mark.playback_test_only
     @BlobPreparer()
     @recorded_by_proxy
     def test_set_container_acl_with_public_access(self, **kwargs):
@@ -2717,4 +2721,4 @@ def test_storage_account_audience_container_client(self, **kwargs):
 
         # Assert
         response = cc.exists()
-        assert response is not None
+        assert response is not None

sdk/storage/azure-storage-blob/tests/test_container_async.py

@@ -101,6 +101,7 @@ async def test_create_cntnr_w_existing_cntnr_fail_on_exist(self, **kwargs):
         # Assert
         assert created
 
+    @pytest.mark.playback_test_only
     @BlobPreparer()
     @recorded_by_proxy_async
     async def test_create_container_with_public_access_container(self, **kwargs):
@@ -117,6 +118,7 @@ async def test_create_container_with_public_access_container(self, **kwargs):
         # Assert
         assert created
 
+    @pytest.mark.playback_test_only
     @BlobPreparer()
     @recorded_by_proxy_async
     async def test_create_container_with_public_access_blob(self, **kwargs):
@@ -382,6 +384,7 @@ async def test_list_containers_with_include_metadata(self, **kwargs):
         self.assertNamedItemInContainer(containers, container.container_name)
         assert containers[0].metadata == metadata
 
+    @pytest.mark.playback_test_only
     @BlobPreparer()
     @recorded_by_proxy_async
     async def test_list_containers_with_public_access(self, **kwargs):
@@ -748,6 +751,7 @@ async def test_set_container_acl_with_lease_id(self, **kwargs):
 
         return variables
 
+    @pytest.mark.playback_test_only
     @BlobPreparer()
     @recorded_by_proxy_async
     async def test_set_container_acl_with_public_access(self, **kwargs):
@@ -2587,4 +2591,4 @@ async def test_storage_account_audience_container_client(self, **kwargs):
 
         # Assert
         response = await cc.exists()
-        assert response is not None
+        assert response is not None

sdk/storage/azure-storage-file-datalake/tests/test_file_system.py

@@ -315,6 +315,7 @@ def test_create_file_system_with_metadata(self, **kwargs):
         assert created
         assert meta == metadata
 
+    @pytest.mark.playback_test_only
     @DataLakePreparer()
     @recorded_by_proxy
     def test_set_file_system_acl(self, **kwargs):
@@ -653,6 +654,7 @@ def test_list_file_systems_by_page(self, **kwargs):
         assert file_systems is not None
         assert len(file_systems) >= 3
 
+    @pytest.mark.playback_test_only
     @DataLakePreparer()
     @recorded_by_proxy
     def test_list_file_systems_with_public_access(self, **kwargs):

sdk/storage/azure-storage-file-datalake/tests/test_file_system_async.py

@@ -595,6 +595,7 @@ async def test_list_file_systems_with_include_metadata_async(self, **kwargs):
         self.assertNamedItemInContainer(file_systems, file_system.file_system_name)
         assert file_systems[0].metadata == metadata
 
+    @pytest.mark.playback_test_only
     @DataLakePreparer()
     @recorded_by_proxy_async
     async def test_set_file_system_acl(self, **kwargs):
@@ -653,6 +654,7 @@ async def test_list_file_systems_by_page(self, **kwargs):
         assert file_systems is not None
         assert len(file_systems) >= 3
 
+    @pytest.mark.playback_test_only
     @DataLakePreparer()
     @recorded_by_proxy_async
     async def test_list_file_systems_with_public_access_async(self, **kwargs):