@@ -14,7 +14,7 @@ In the case one of the targeted tags exists in the targeted assets.json, that ta
14
14
15
15
1. test-proxy restore -a <assets-file> -> populate .assets
16
16
2. test-proxy config locate -a <assets-file> -> get location of cloned git repo
17
- 3. walk the incoming tags, cherry-picking their changes directly into the changeset _in context_
17
+ 3. walk the incoming tags, merging their changes directly into the changeset _in context_
18
18
4. In the case of a discovered git conflict, the process ends. A list of which tags merged and which didn't will be presented to the user.
19
19
4a. Users should resolve the git conflicts themselves.
20
20
4b. If the conflict was on the final tag, resolve the conflict (leaving it uncommitted tyvm), and test-proxy push, you're done.
@@ -243,10 +243,10 @@ function Combine-Tags($RemainingTags, $AssetsRepoLocation, $MountDirectory, $Rel
243
243
foreach ($Tag in $RemainingTags ) {
244
244
$tagSha = Get-Tag - SHA $Tag $AssetsRepoLocation
245
245
$existingTags = Save-Incomplete - Progress $Tag $MountDirectory
246
- $cherryPickResult = Git- Command- With- Result " cherry-pick $tagSha " - $AssetsRepoLocation - HardExit $false
246
+ $cherryPickResult = Git- Command- With- Result " merge $tagSha " - $AssetsRepoLocation - HardExit $false
247
247
248
248
if ($cherryPickResult.ExitCode -ne 0 ) {
249
- $error = " Conflicts while cherry-picking $Tag . Resolve the the conflict over in `" $AssetsRepoLocation `" , and re-invoke " +
249
+ $error = " Conflicts while merging $Tag . Resolve the the conflict over in `" $AssetsRepoLocation `" , and re-invoke " +
250
250
" by `" ./eng/common/testproxy/scripts/tag-merge/merge-proxy-tags.ps1 $RelativeAssetsJson $remainingTagString `" "
251
251
Write-Host $error - ForegroundColor Red
252
252
exit 1
@@ -286,11 +286,11 @@ $AssetsJson = Resolve-Path $AssetsJson
286
286
# directory so that the test-proxy restore operations work IN PLACE with existing tooling
287
287
$mountDirectory = Get-Repo - Root - StartDir $AssetsJson
288
288
289
- # ensure we actually have the .assets folder that we can cherry-pick on top of
289
+ # ensure we actually have the .assets folder that we can merge commits onto
290
290
Prepare- Assets $proxyExe $mountDirectory $AssetsJson
291
291
292
292
# using the mountingDirectory and the assets.json location, we can figure out where the assets slice actually lives within the .assets folder.
293
- # we will use this to invoke individual cherry-picks before pushing up the result
293
+ # we will use this to invoke individual SHA merges before pushing up the result
294
294
$assetsRepoLocation = Locate- Assets- Slice $proxyExe $AssetsJson $mountDirectory
295
295
296
296
# resolve the tags that we will go after. If the target assets.json contains one of these tags, that tag is _already present_
0 commit comments