Skip to content

Commit 94823b7

Browse files
azure-sdkscbedd
andauthored
use merge instead of cherry-pick in merge-proxy-tags.ps1 (#33935)
Co-authored-by: Scott Beddall (from Dev Box) <[email protected]>
1 parent 86f34c8 commit 94823b7

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

eng/common/testproxy/scripts/tag-merge/merge-proxy-tags.ps1

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ In the case one of the targeted tags exists in the targeted assets.json, that ta
1414
1515
1. test-proxy restore -a <assets-file> -> populate .assets
1616
2. test-proxy config locate -a <assets-file> -> get location of cloned git repo
17-
3. walk the incoming tags, cherry-picking their changes directly into the changeset _in context_
17+
3. walk the incoming tags, merging their changes directly into the changeset _in context_
1818
4. In the case of a discovered git conflict, the process ends. A list of which tags merged and which didn't will be presented to the user.
1919
4a. Users should resolve the git conflicts themselves.
2020
4b. If the conflict was on the final tag, resolve the conflict (leaving it uncommitted tyvm), and test-proxy push, you're done.
@@ -243,10 +243,10 @@ function Combine-Tags($RemainingTags, $AssetsRepoLocation, $MountDirectory, $Rel
243243
foreach($Tag in $RemainingTags) {
244244
$tagSha = Get-Tag-SHA $Tag $AssetsRepoLocation
245245
$existingTags = Save-Incomplete-Progress $Tag $MountDirectory
246-
$cherryPickResult = Git-Command-With-Result "cherry-pick $tagSha" - $AssetsRepoLocation -HardExit $false
246+
$cherryPickResult = Git-Command-With-Result "merge $tagSha" - $AssetsRepoLocation -HardExit $false
247247

248248
if ($cherryPickResult.ExitCode -ne 0) {
249-
$error = "Conflicts while cherry-picking $Tag. Resolve the the conflict over in `"$AssetsRepoLocation`", and re-invoke " +
249+
$error = "Conflicts while merging $Tag. Resolve the the conflict over in `"$AssetsRepoLocation`", and re-invoke " +
250250
"by `"./eng/common/testproxy/scripts/tag-merge/merge-proxy-tags.ps1 $RelativeAssetsJson $remainingTagString`""
251251
Write-Host $error -ForegroundColor Red
252252
exit 1
@@ -286,11 +286,11 @@ $AssetsJson = Resolve-Path $AssetsJson
286286
# directory so that the test-proxy restore operations work IN PLACE with existing tooling
287287
$mountDirectory = Get-Repo-Root -StartDir $AssetsJson
288288

289-
# ensure we actually have the .assets folder that we can cherry-pick on top of
289+
# ensure we actually have the .assets folder that we can merge commits onto
290290
Prepare-Assets $proxyExe $mountDirectory $AssetsJson
291291

292292
# using the mountingDirectory and the assets.json location, we can figure out where the assets slice actually lives within the .assets folder.
293-
# we will use this to invoke individual cherry-picks before pushing up the result
293+
# we will use this to invoke individual SHA merges before pushing up the result
294294
$assetsRepoLocation = Locate-Assets-Slice $proxyExe $AssetsJson $mountDirectory
295295

296296
# resolve the tags that we will go after. If the target assets.json contains one of these tags, that tag is _already present_

0 commit comments

Comments
 (0)