Skip to content

Commit 99ac866

Browse files
author
Yalin Li
authored
[AppConfig] Fix failing live pipeline (#36997)
1 parent ca110c9 commit 99ac866

File tree

3 files changed

+14
-11
lines changed

3 files changed

+14
-11
lines changed

sdk/appconfiguration/azure-appconfiguration/CHANGELOG.md

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,9 @@
11
# Release History
22

3-
## 1.7.1 (Unreleased)
4-
5-
### Features Added
6-
7-
### Breaking Changes
3+
## 1.7.1 (2024-08-22)
84

95
### Bugs Fixed
10-
11-
### Other Changes
6+
- Fixed a bug in serializing/deserializing tags filter in `ConfigurationSnapshot`.
127

138
## 1.7.0 (2024-08-15)
149

sdk/appconfiguration/azure-appconfiguration/azure/appconfiguration/_models.py

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -488,7 +488,11 @@ def _from_generated(cls, generated: GeneratedConfigurationSnapshot) -> "Configur
488488
if generated.filters:
489489
for config_setting_filter in generated.filters:
490490
filters.append(
491-
ConfigurationSettingsFilter(key=config_setting_filter.key, label=config_setting_filter.label)
491+
ConfigurationSettingsFilter(
492+
key=config_setting_filter.key,
493+
label=config_setting_filter.label,
494+
tags=config_setting_filter.tags,
495+
)
492496
)
493497
snapshot = cls(
494498
filters=filters,
@@ -519,7 +523,11 @@ def _from_deserialized(
519523
if deserialized.filters:
520524
for config_setting_filter in deserialized.filters:
521525
filters.append(
522-
ConfigurationSettingsFilter(key=config_setting_filter.key, label=config_setting_filter.label)
526+
ConfigurationSettingsFilter(
527+
key=config_setting_filter.key,
528+
label=config_setting_filter.label,
529+
tags=config_setting_filter.tags,
530+
)
523531
)
524532
snapshot = cls(
525533
filters=filters,
@@ -540,7 +548,7 @@ def _from_deserialized(
540548
def _to_generated(self) -> GeneratedConfigurationSnapshot:
541549
config_setting_filters = []
542550
for kv_filter in self.filters:
543-
config_setting_filters.append(KeyValueFilter(key=kv_filter.key, label=kv_filter.label))
551+
config_setting_filters.append(KeyValueFilter(key=kv_filter.key, label=kv_filter.label, tags=kv_filter.tags))
544552
return GeneratedConfigurationSnapshot(
545553
filters=config_setting_filters,
546554
composition_type=self.composition_type,

sdk/appconfiguration/tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ parameters:
55
type: object
66
default:
77
- azure-appconfiguration
8-
- azure-appconfiguration-provider
8+
# - azure-appconfiguration-provider
99

1010
extends:
1111
template: ../../eng/pipelines/templates/stages/archetype-sdk-tests.yml

0 commit comments

Comments
 (0)