[SDK generation pipeline] Fix for new changelog tool (#36951)

* new changelog fix

* fix

* fix

* Delete tools/azure-sdk-tools/packaging_tools/test.py

* fix

* fix

* changelog

Author: msyyc

scripts/automation_init.sh

@@ -14,6 +14,7 @@ PATH="$VIRTUAL_ENV/bin:$PATH"
 export PATH
 python -m pip install -U pip
 python scripts/dev_setup.py -p azure-core
+pip install tox==4.15.0
 
 # install tsp-client globally (local install may interfere with tooling)
 echo Install tsp-client

tools/azure-sdk-tools/packaging_tools/generate_utils.py

@@ -77,7 +77,11 @@ def return_origin_path(func):
     @wraps(func)
     def wrapper(*args, **kwargs):
         current_path = os.getcwd()
-        result = func(*args, **kwargs)
+        try:
+            result = func(*args, **kwargs)
+        except Exception as e:
+            os.chdir(current_path)
+            raise e
         os.chdir(current_path)
         return result
 

tools/azure-sdk-tools/packaging_tools/package_utils.py

@@ -2,7 +2,8 @@
 from typing import Optional
 from pathlib import Path
 import logging
-from subprocess import check_call, check_output, CalledProcessError
+from subprocess import check_call, CalledProcessError, getoutput
+from .generate_utils import return_origin_path
 
 from .change_log import main as change_log_main
 
@@ -21,22 +22,20 @@ def create_package(prefolder, name, dest_folder=DEFAULT_DEST_FOLDER):
     )
 
 
+@return_origin_path
 def change_log_new(package_folder: str, lastest_pypi_version: bool) -> str:
+    os.chdir(package_folder)
     cmd = "tox run -c ../../../eng/tox/tox.ini --root . -e breaking --  --changelog "
     if lastest_pypi_version:
         cmd += "--latest-pypi-version"
     try:
-        output = check_output(cmd, cwd=package_folder, shell=True)
+        output = getoutput(cmd)
     except CalledProcessError as e:
         _LOGGER.warning(f"Error ocurred when call breaking change detector: {e.output.decode('utf-8')}")
         raise e
-    result = [l for l in output.decode("utf-8").split(os.linesep)]
+    result = [l for l in output.split("\n")]
     begin = result.index("===== changelog start =====")
     end = result.index("===== changelog end =====")
-    if begin == -1 or end == -1:
-        warn_info = "Failed to get changelog from breaking change detector"
-        _LOGGER.warning(warn_info)
-        raise Exception(warn_info)
     return "\n".join(result[begin + 1 : end]).strip()