[Test proxy] Correctly raise in the event of recording failure (#43738)

Author: mccoyp

doc/dev/test_proxy_troubleshooting.md

@@ -275,6 +275,9 @@ To run recorded tests successfully when recorded values are inconsistent or rand
 proxy provides a `variables` API. This makes it possible for a test to record the values of variables that were used
 during recording and use the same values in playback mode without a sanitizer.
 
+Note that the recorded variables **must** have string values. For example, trying to record an integer value for a
+variable will cause a test proxy error.
+
 For example, imagine that a test uses a randomized `table_uuid` variable when creating resources. The same random value
 for `table_uuid` can be used in playback mode by using this `variables` API.
 
@@ -293,14 +296,14 @@ class TestExample(AzureRecordedTestCase):
     @recorded_by_proxy
     def test_example(self, **kwargs):
         # In live mode, variables is an empty dictionary
-        # In playback mode, the value of variables is {"table_uuid": "random-value"}
+        # In playback mode, the value of variables is {"current_time": "<previously recorded time>"}
         variables = kwargs.pop("variables", {})
 
-        # To fetch variable values, use the `setdefault` method to look for a key ("table_uuid")
-        # and set a real value for that key if it's not present ("random-value")
-        table_uuid = variables.setdefault("table_uuid", "random-value")
+        # To fetch variable values, use the `setdefault` method to look for a key ("current_time")
+        # and set a real value for that key if it's not present (str(time.time()))
+        # Note that time.time() is converted from a float to a string to record it properly
+        current_time = variables.setdefault("current_time", str(time.time()))
 
-        # use variables["table_uuid"] when using the table UUID throughout the test
         ...
 
         # return the variables at the end of the test to record them

eng/tools/azure-sdk-tools/devtools_testutils/proxy_testcase.py

@@ -114,32 +114,31 @@ def start_record_or_playback(test_id: str) -> "Tuple[str, Dict[str, str]]":
 
 
 def stop_record_or_playback(test_id: str, recording_id: str, test_variables: "Dict[str, str]") -> None:
-    try:
-        http_client = get_http_client()
-        if is_live():
-            http_client.request(
-                method="POST",
-                url=RECORDING_STOP_URL,
-                headers={
-                    "x-recording-file": test_id,
-                    "x-recording-id": recording_id,
-                    "x-recording-save": "true",
-                    "Content-Type": "application/json",
-                },
-                # tests don't record successfully unless test_variables is a dictionary
-                body=json.dumps(test_variables).encode("utf-8") if test_variables else "{}",
-            )
-        else:
-            http_client.request(
-                method="POST",
-                url=PLAYBACK_STOP_URL,
-                headers={"x-recording-id": recording_id},
-            )
-    except HTTPError as e:
+    http_client = get_http_client()
+    if is_live():
+        response = http_client.request(
+            method="POST",
+            url=RECORDING_STOP_URL,
+            headers={
+                "x-recording-file": test_id,
+                "x-recording-id": recording_id,
+                "x-recording-save": "true",
+                "Content-Type": "application/json",
+            },
+            # tests don't record successfully unless test_variables is a dictionary
+            body=json.dumps(test_variables or {}).encode("utf-8"),
+        )
+    else:
+        response = http_client.request(
+            method="POST",
+            url=PLAYBACK_STOP_URL,
+            headers={"x-recording-id": recording_id},
+        )
+    if response.status >= 400:
         raise HttpResponseError(
             "The test proxy ran into an error while ending the session. Make sure any test variables you record have "
-            "string values."
-        ) from e
+            f"string values. Full error details: {response.data}"
+        )
 
 
 def get_proxy_netloc() -> "Dict[str, str]":