Skip to content

Commit 9af712f

Browse files
committed
fix mypy
1 parent a9769c3 commit 9af712f

12 files changed

+27
-16
lines changed

sdk/ai/azure-ai-agentserver-langgraph/azure/ai/agentserver/langgraph/langgraph.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
# Copyright (c) Microsoft Corporation. All rights reserved.
33
# ---------------------------------------------------------
44
# pylint: disable=logging-fstring-interpolation,broad-exception-caught
5+
# mypy: disable-error-code="assignment,arg-type"
56
import os
67
import re
78
from typing import Optional

sdk/ai/azure-ai-agentserver-langgraph/azure/ai/agentserver/langgraph/models/langgraph_response_converter.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# Copyright (c) Microsoft Corporation. All rights reserved.
33
# ---------------------------------------------------------
44
# pylint: disable=logging-fstring-interpolation,broad-exception-caught,logging-not-lazy
5-
# mypy: ignore-errors
5+
# mypy: disable-error-code="valid-type,call-overload,attr-defined"
66
import copy
77
from typing import List
88

@@ -23,7 +23,7 @@ def __init__(self, context: AgentRunContext, output):
2323
self.context = context
2424
self.output = output
2525

26-
def convert(self) -> project_models.ItemResource:
26+
def convert(self) -> list[project_models.ItemResource]:
2727
res = []
2828
for step in self.output:
2929
for node_name, node_output in step.items():

sdk/ai/azure-ai-agentserver-langgraph/azure/ai/agentserver/langgraph/models/langgraph_state_converter.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# ---------------------------------------------------------
22
# Copyright (c) Microsoft Corporation. All rights reserved.
33
# ---------------------------------------------------------
4-
4+
# mypy: disable-error-code="call-overload,override"
55
"""Base interface for converting between LangGraph internal state and OpenAI-style responses.
66
77
A LanggraphStateConverter implementation bridges:

sdk/ai/azure-ai-agentserver-langgraph/azure/ai/agentserver/langgraph/models/langgraph_stream_response_converter.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
# Copyright (c) Microsoft Corporation. All rights reserved.
33
# ---------------------------------------------------------
44
# pylint: disable=logging-fstring-interpolation
5+
# mypy: disable-error-code="assignment,valid-type"
56
from typing import List
67

78
from langchain_core.messages import AnyMessage

sdk/ai/azure-ai-agentserver-langgraph/azure/ai/agentserver/langgraph/models/response_event_generators/item_content_helpers.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ def __init__(self, content_type: str):
1010
self.has_aggregated_content = False
1111

1212
def create_item_content(self) -> project_models.ItemContent:
13-
return project_models.ItemContent( # mypy: ignore[call-overload]
14-
content_type=self.content_type,
13+
return project_models.ItemContent(
14+
type=self.content_type,
1515
)
1616

1717

sdk/ai/azure-ai-agentserver-langgraph/azure/ai/agentserver/langgraph/models/response_event_generators/item_resource_helpers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ class MessageItemResourceHelper(ItemResourceHelper):
9292
def __init__(self, item_id: str, role: project_models.ResponsesMessageRole):
9393
super().__init__(project_models.ItemType.MESSAGE, item_id)
9494
self.role = role
95-
self.content = [] # mypy: ignore[var-annotated]
95+
self.content: list[project_models.ItemContent] = []
9696

9797
def create_item_resource(self, is_done: bool):
9898
content = {

sdk/ai/azure-ai-agentserver-langgraph/azure/ai/agentserver/langgraph/models/response_event_generators/response_event_generator.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
# Copyright (c) Microsoft Corporation. All rights reserved.
33
# ---------------------------------------------------------
44
# pylint: disable=unused-argument,unnecessary-pass
5+
# mypy: disable-error-code="valid-type"
56
from typing import List
67

78
from langchain_core.messages import AnyMessage
@@ -52,24 +53,26 @@ def try_process_message(
5253
"""
5354
pass
5455

55-
def on_start(self) -> tuple[bool, List[project_models.ResponseStreamEvent]]: # mypy: ignore[empty-body]
56+
def on_start(self) -> tuple[bool, List[project_models.ResponseStreamEvent]]:
5657
"""
5758
Generate the starting events for this layer.
5859
5960
:return: tuple of (started, events)
6061
:rtype: tuple[bool, List[ResponseStreamEvent]]
6162
"""
62-
pass
63+
return False, []
6364

64-
def on_end(self) -> tuple[bool, List[project_models.ResponseStreamEvent]]: # mypy: ignore[empty-body]
65+
def on_end(
66+
self, message: AnyMessage, context: AgentRunContext, stream_state: StreamEventState
67+
) -> tuple[bool, List[project_models.ResponseStreamEvent]]:
6568
"""
6669
Generate the ending events for this layer.
6770
TODO: handle different end conditions, e.g. normal end, error end, etc.
6871
6972
:return: tuple of (started, events)
7073
:rtype: tuple[bool, List[ResponseStreamEvent]]
7174
"""
72-
pass
75+
return False, []
7376

7477
def aggregate_content(self):
7578
"""

sdk/ai/azure-ai-agentserver-langgraph/azure/ai/agentserver/langgraph/models/response_event_generators/response_function_call_argument_event_generator.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ def try_process_message(
3939

4040
if self.should_end(message):
4141
has_finish_reason = self.has_finish_reason(message)
42-
complete_events = self.on_end(message, stream_state)
42+
complete_events = self.on_end(message, context, stream_state)
4343
events.extend(complete_events)
4444
next_processor = self.parent
4545
is_processed = has_finish_reason # if has finish reason, mark as processed and stop further processing
@@ -94,7 +94,7 @@ def should_end(self, event: AnyMessage) -> bool:
9494
return False
9595

9696
def on_end(
97-
self, message: AnyMessage, stream_state: StreamEventState
97+
self, message: AnyMessage, context: AgentRunContext, stream_state: StreamEventState
9898
) -> tuple[bool, List[project_models.ResponseStreamEvent]]:
9999
done_event = project_models.ResponseFunctionCallArgumentsDoneEvent(
100100
item_id=self.item_id,

sdk/ai/azure-ai-agentserver-langgraph/azure/ai/agentserver/langgraph/models/response_event_generators/response_output_text_event_generator.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,11 @@
22
# Copyright (c) Microsoft Corporation. All rights reserved.
33
# ---------------------------------------------------------
44
# pylint: disable=unused-argument
5+
# mypy: disable-error-code="return-value,assignment"
56
from typing import List
67

78
from azure.ai.agentserver.core.models import projects as project_models
9+
from azure.ai.agentserver.core.server.common.agent_run_context import AgentRunContext
810

911
from .response_event_generator import (
1012
ResponseEventGenerator,
@@ -91,7 +93,7 @@ def should_end(self, message) -> bool:
9193
return False
9294

9395
def on_end( # mypy: ignore[override]
94-
self, message, run_details, stream_state: StreamEventState
96+
self, message, context: AgentRunContext, stream_state: StreamEventState
9597
) -> tuple[bool, List[project_models.ResponseStreamEvent]]:
9698
if not self.started:
9799
return False, []

sdk/ai/azure-ai-agentserver-langgraph/azure/ai/agentserver/langgraph/models/response_event_generators/response_stream_event_generator.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ def try_process_message(
9393

9494
if self.should_end(message):
9595
# received a None message, indicating end of the stream
96-
done_events = self.on_end(context, stream_state)
96+
done_events = self.on_end(message, context, stream_state)
9797
events.extend(done_events)
9898
is_processed = True
9999
next_processor = None
@@ -106,7 +106,7 @@ def should_end(self, event: langgraph_messages.AnyMessage) -> bool:
106106
return True
107107
return False
108108

109-
def on_end(self, context: AgentRunContext, stream_state: StreamEventState):
109+
def on_end(self, message: langgraph_messages.AnyMessage, context: AgentRunContext, stream_state: StreamEventState):
110110
agent_id = context.get_agent_id_object()
111111
conversation = context.get_conversation_object()
112112
response_dict = {

0 commit comments

Comments
 (0)