close vnext issues if library passing (#33494)

* add close_vnext_issue function

* add close_vnext_issue function to ci checks that create issues

* add strict sphinx

* log GH issue number we're closing

Author: kristapratico

eng/tox/run_mypy.py

@@ -19,7 +19,6 @@
 from ci_tools.parsing import ParsedSetup
 from ci_tools.variables import in_ci
 
-
 logging.getLogger().setLevel(logging.INFO)
 
 root_dir = os.path.abspath(os.path.join(os.path.abspath(__file__), "..", "..", ".."))
@@ -101,9 +100,11 @@
                 sample_code_error = sample_err
 
     if args.next and in_ci() and not is_typing_ignored(package_name):
-        from gh_tools.vnext_issue_creator import create_vnext_issue
+        from gh_tools.vnext_issue_creator import create_vnext_issue, close_vnext_issue
         if src_code_error or sample_code_error:
             create_vnext_issue(package_name, "mypy")
+        else:
+            close_vnext_issue(package_name, "mypy")
 
     if src_code_error and sample_code_error:
         raise Exception(

eng/tox/run_pylint.py

@@ -77,3 +77,7 @@
             create_vnext_issue(pkg_details.name, "pylint")
 
         exit(1)
+
+    if args.next and in_ci():
+        from gh_tools.vnext_issue_creator import close_vnext_issue
+        close_vnext_issue(pkg_details.name, "pylint")

eng/tox/run_pyright.py

@@ -120,3 +120,7 @@ def get_pyright_config_path(args):
 
         print("See https://aka.ms/python/typing-guide for information.\n\n")
         raise error
+
+    if args.next and in_ci() and not is_typing_ignored(package_name):
+        from gh_tools.vnext_issue_creator import close_vnext_issue
+        close_vnext_issue(package_name, "pyright")

eng/tox/run_sphinx_build.py

@@ -134,5 +134,9 @@ def sphinx_build(target_dir, output_dir, fail_on_warning=False, package_name=Non
 
         if in_ci() or args.in_ci:
             move_output_and_compress(output_dir, package_dir, pkg_details.name)
+
+            if args.strict:
+                from gh_tools.vnext_issue_creator import close_vnext_issue
+                close_vnext_issue(pkg_details.name, "sphinx")
     else:
-        logging.info("Skipping sphinx build for {}".format(pkg_details.name))
+        logging.info("Skipping sphinx build for {}".format(pkg_details.name))

tools/azure-sdk-tools/gh_tools/vnext_issue_creator.py

@@ -158,3 +158,18 @@ def create_vnext_issue(package_name: str, check_type: CHECK_TYPE) -> None:
         title=title,
         body=template,
     )
+
+
+def close_vnext_issue(package_name: str, check_type: CHECK_TYPE) -> None:
+    """This is called when a client library passes a vnext check. If an issue exists for the library, it is closed."""
+
+    auth = Auth.Token(os.environ["GH_TOKEN"])
+    g = Github(auth=auth)
+
+    repo = g.get_repo("Azure/azure-sdk-for-python")
+
+    issues = repo.get_issues(state="open", labels=[check_type], creator="azure-sdk")
+    vnext_issue = [issue for issue in issues if issue.title.split("needs")[0].strip() == package_name]
+    if vnext_issue:
+        logging.info(f"{package_name} passes {check_type}. Closing existing GH issue #{vnext_issue[0].number}...")
+        vnext_issue[0].edit(state="closed")