Skip to content

Commit 9fb4c52

Browse files
Fix case where changelog wasn't marked as invalid (#36133)
Co-authored-by: Wes Haggard <[email protected]>
1 parent 0df317b commit 9fb4c52

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

eng/common/scripts/ChangeLog-Operations.ps1

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -297,8 +297,8 @@ function Remove-EmptySections {
297297
{
298298
$parsedSections = $ChangeLogEntry.Sections
299299
$sanitizedReleaseContent = New-Object System.Collections.ArrayList(,$releaseContent)
300-
301-
foreach ($key in @($parsedSections.Keys))
300+
301+
foreach ($key in @($parsedSections.Keys))
302302
{
303303
if ([System.String]::IsNullOrWhiteSpace($parsedSections[$key]))
304304
{
@@ -442,9 +442,10 @@ function Confirm-ChangeLogForRelease {
442442
if (!$foundRecommendedSection)
443443
{
444444
$ChangeLogStatus.Message = "The changelog entry did not contain any of the recommended sections ($($RecommendedSectionHeaders -join ', ')), please add at least one. See https://aka.ms/azsdk/guideline/changelogs for more info."
445+
$ChangeLogStatus.IsValid = $false
445446
if (!$SuppressErrors) {
446447
LogError "$($ChangeLogStatus.Message)"
447448
}
448449
}
449450
return $ChangeLogStatus.IsValid
450-
}
451+
}

0 commit comments

Comments
 (0)