Skip to content

Commit a0a99f0

Browse files
authored
EventGrid 100% TypeScore (#36132)
1 parent 60e1145 commit a0a99f0

File tree

4 files changed

+10
-11
lines changed

4 files changed

+10
-11
lines changed

sdk/eventgrid/azure-eventgrid/azure/eventgrid/_legacy/_generated/models/_models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ def __init__(
214214
self.data = data
215215
self.event_type = event_type
216216
self.event_time = event_time
217-
self.metadata_version = None
217+
self.metadata_version: Optional[str] = None
218218
self.data_version = data_version
219219

220220

sdk/eventgrid/azure-eventgrid/azure/eventgrid/_legacy/_messaging_shared.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@
1010
# Both the files should always be identical.
1111
# ==========================================================================
1212

13-
13+
from typing import Any
1414
import json
1515

1616

17-
def _get_json_content(obj): # pylint: disable=inconsistent-return-statements
17+
def _get_json_content(obj: Any) -> Any: # pylint: disable=inconsistent-return-statements
1818
"""Event mixin to have methods that are common to different Event types
1919
like CloudEvent, EventGridEvent etc.
2020

sdk/eventgrid/azure-eventgrid/azure/eventgrid/_legacy/_models.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,7 @@ class EventGridEvent(InternalEventGridEvent):
8181
"data_version": {"key": "dataVersion", "type": "str"},
8282
}
8383

84-
def __init__(self, subject, event_type, data, data_version, **kwargs):
85-
# type: (str, str, object, str, Any) -> None
84+
def __init__(self, subject: str, event_type: str, data: Any, data_version: str, **kwargs: Any) -> None:
8685
kwargs.setdefault("id", uuid.uuid4())
8786
kwargs.setdefault("subject", subject)
8887
kwargs.setdefault("event_type", event_type)
@@ -92,14 +91,13 @@ def __init__(self, subject, event_type, data, data_version, **kwargs):
9291

9392
super(EventGridEvent, self).__init__(**kwargs)
9493

95-
def __repr__(self):
94+
def __repr__(self) -> str:
9695
return "EventGridEvent(subject={}, event_type={}, id={}, event_time={})".format(
9796
self.subject, self.event_type, self.id, self.event_time
9897
)[:1024]
9998

10099
@classmethod
101-
def from_json(cls, event):
102-
# type: (Any) -> EventGridEvent
100+
def from_json(cls, event: Any) -> "EventGridEvent":
103101
"""
104102
Returns the deserialized EventGridEvent object when a json payload is provided.
105103
:param event: The json string that should be converted into a EventGridEvent. This can also be

sdk/eventgrid/azure-eventgrid/azure/eventgrid/models/_patch.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,16 @@
66
77
Follow our quickstart for examples: https://aka.ms/azsdk/python/dpcodegen/python/customize
88
"""
9-
from typing import List, overload, Mapping, Any
9+
from typing import List, overload, Mapping, Any, Generic, TypeVar
1010
from azure.core.messaging import CloudEvent
1111
from ._models import (
1212
ReceiveDetails as InternalReceiveDetails,
1313
BrokerProperties as InternalBrokerProperties,
1414
)
1515

16+
DataType = TypeVar("DataType")
1617

17-
class ReceiveDetails(InternalReceiveDetails):
18+
class ReceiveDetails(InternalReceiveDetails, Generic[DataType]):
1819
"""Receive operation details per Cloud Event.
1920
2021
All required parameters must be populated in order to send to Azure.
@@ -30,7 +31,7 @@ def __init__(
3031
self,
3132
*,
3233
broker_properties: "BrokerProperties",
33-
event: "CloudEvent",
34+
event: CloudEvent[DataType],
3435
): ...
3536

3637
@overload

0 commit comments

Comments
 (0)