communications linting fixes (#36142)

Author: annatisch

sdk/communication/azure-communication-jobrouter/azure/communication/jobrouter/_operations/_patch.py

@@ -16,6 +16,7 @@
     Union,
     overload,
     IO,
+    Literal,
 )
 from azure.core import MatchConditions
 from azure.core.paging import ItemPaged
@@ -27,11 +28,6 @@
 )
 from .._model_base import _deserialize_datetime as _convert_str_to_datetime  # pylint:disable=protected-access
 
-if sys.version_info >= (3, 8):
-    from typing import Literal  # pylint: disable=no-name-in-module, ungrouped-imports
-else:
-    from typing_extensions import Literal  # type: ignore  # pylint: disable=ungrouped-imports
-
 if sys.version_info >= (3, 9):
     from collections.abc import MutableMapping
 else:
@@ -44,7 +40,7 @@ class JobRouterAdministrationClientOperationsMixin(
 ):  # pylint:disable=too-many-lines,line-too-long,name-too-long
     # region ExceptionPolicy
     @overload
-    def upsert_exception_policy(  # pylint: disable=arguments-differ,unused-argument
+    def upsert_exception_policy(  # pylint: disable=arguments-differ
         self,
         exception_policy_id: str,
         *,
@@ -203,7 +199,7 @@ def upsert_exception_policy(
         :raises ~azure.core.exceptions.HttpResponseError:
         """
 
-    def upsert_exception_policy(
+    def upsert_exception_policy(  # pylint: disable=docstring-missing-param
         self, exception_policy_id: str, *args: Union[_models.ExceptionPolicy, JSON, IO[bytes]], **kwargs: Any
     ) -> _models.ExceptionPolicy:
         """Update an exception policy.
@@ -302,7 +298,7 @@ def list_exception_policies(
 
     # region DistributionPolicy
     @overload
-    def upsert_distribution_policy(  # pylint: disable=arguments-differ,unused-argument
+    def upsert_distribution_policy(  # pylint: disable=arguments-differ
         self,
         distribution_policy_id: str,
         *,
@@ -465,17 +461,13 @@ def upsert_distribution_policy(
         :raises ~azure.core.exceptions.HttpResponseError:
         """
 
-    def upsert_distribution_policy(
+    def upsert_distribution_policy(  # pylint: disable=docstring-missing-param,docstring-should-be-keyword
         self, distribution_policy_id: str, *args: Union[_models.DistributionPolicy, JSON, IO[bytes]], **kwargs: Any
     ) -> _models.DistributionPolicy:
         """Update a distribution policy.
 
         :param str distribution_policy_id: Id of the distribution policy.
 
-        :param distribution_policy: An instance of distribution policy. This is a positional-only parameter.
-          Please provide either this or individual keyword parameters.
-        :type distribution_policy: ~azure.communication.jobrouter.models.DistributionPolicy
-
         :keyword Optional[float] offer_expires_after_seconds: The expiry time of any offers created under this policy
           will be governed by the offer time to live.
 
@@ -574,7 +566,7 @@ def list_distribution_policies(
 
     # region Queue
     @overload
-    def upsert_queue(  # pylint: disable=arguments-differ,unused-argument
+    def upsert_queue(  # pylint: disable=arguments-differ
         self,
         queue_id: str,
         *,
@@ -591,10 +583,6 @@ def upsert_queue(  # pylint: disable=arguments-differ,unused-argument
 
         :param str queue_id: Id of the queue.
 
-        :param queue: An instance of JobQueue. This is a positional-only parameter.
-          Please provide either this or individual keyword parameters.
-        :type queue: ~azure.communication.jobrouter.models.RouterQueue
-
         :keyword Optional[str] distribution_policy_id: The ID of the distribution policy that will determine
           how a job is distributed to workers.
 
@@ -744,17 +732,13 @@ def upsert_queue(
         :raises ~azure.core.exceptions.HttpResponseError:
         """
 
-    def upsert_queue(
+    def upsert_queue(  # pylint: disable=docstring-missing-param
         self, queue_id: str, *args: Union[_models.RouterQueue, JSON, IO[bytes]], **kwargs: Any
     ) -> _models.RouterQueue:
         """Update a job queue
 
         :param str queue_id: Id of the queue.
 
-        :param queue: An instance of JobQueue. This is a positional-only parameter.
-          Please provide either this or individual keyword parameters.
-        :type queue: ~azure.communication.jobrouter.models.RouterQueue
-
         :keyword Optional[str] distribution_policy_id: The ID of the distribution policy that will determine
           how a job is distributed to workers.
 
@@ -852,7 +836,7 @@ def list_queues(self, *, results_per_page: Optional[int] = None, **kwargs: Any)
 
     # region ClassificationPolicy
     @overload
-    def upsert_classification_policy(  # pylint: disable=arguments-differ,unused-argument
+    def upsert_classification_policy(  # pylint: disable=arguments-differ
         self,
         classification_policy_id: str,
         *,
@@ -1061,7 +1045,7 @@ def upsert_classification_policy(
         :raises ~azure.core.exceptions.HttpResponseError:
         """
 
-    def upsert_classification_policy(
+    def upsert_classification_policy(  # pylint: disable=docstring-missing-param
         self, classification_policy_id: str, *args: Union[_models.ClassificationPolicy, JSON, IO[bytes]], **kwargs: Any
     ) -> _models.ClassificationPolicy:
         """Update a classification policy
@@ -1189,7 +1173,7 @@ def list_classification_policies(
 class JobRouterClientOperationsMixin(JobRouterClientOperationsMixinGenerated):
     # region Worker
     @overload
-    def upsert_worker(  # pylint: disable=arguments-differ,unused-argument
+    def upsert_worker(  # pylint: disable=arguments-differ
         self,
         worker_id: str,
         *,
@@ -1390,7 +1374,7 @@ def upsert_worker(
         :raises ~azure.core.exceptions.HttpResponseError:
         """
 
-    def upsert_worker(
+    def upsert_worker(  # pylint: disable=docstring-missing-param
         self, worker_id: str, *args: Union[_models.RouterWorker, JSON, IO[bytes]], **kwargs: Any
     ) -> _models.RouterWorker:
         """Update a router worker.
@@ -1570,7 +1554,7 @@ def list_workers(
 
     # region Job
     @overload
-    def upsert_job(  # pylint: disable=arguments-differ,unused-argument
+    def upsert_job(  # pylint: disable=arguments-differ
         self,
         job_id: str,
         *,
@@ -1768,7 +1752,7 @@ def upsert_job(
         :raises ~azure.core.exceptions.HttpResponseError:
         """
 
-    def upsert_job(
+    def upsert_job(  # pylint: disable=docstring-missing-param
             self,
             job_id: str,
             *args: Union[_models.RouterJob, JSON, IO[bytes]],

sdk/communication/azure-communication-jobrouter/azure/communication/jobrouter/aio/_operations/_patch.py

@@ -8,7 +8,7 @@
 """
 import sys
 import datetime
-from typing import List, Any, Optional, Dict, Union, overload, IO
+from typing import List, Any, Optional, Dict, Union, overload, IO, Literal
 
 from azure.core import MatchConditions
 from azure.core.tracing.decorator import distributed_trace
@@ -20,26 +20,23 @@
     JobRouterClientOperationsMixin as JobRouterClientOperationsMixinGenerated,
     JobRouterAdministrationClientOperationsMixin as JobRouterAdministrationClientOperationsMixinGenerated,
 )
-from ..._model_base import _deserialize_datetime as _convert_str_to_datetime  # pylint:disable=protected-access
-
-if sys.version_info >= (3, 8):
-    from typing import Literal  # pylint: disable=no-name-in-module, ungrouped-imports
-else:
-    from typing_extensions import Literal  # type: ignore  # pylint: disable=ungrouped-imports
+from ..._model_base import _deserialize_datetime as _convert_str_to_datetime
 
 if sys.version_info >= (3, 9):
     from collections.abc import MutableMapping
 else:
-    from typing import MutableMapping  # type: ignore  # pylint: disable=ungrouped-imports
+    from typing import MutableMapping  # type: ignore
+
+
 JSON = MutableMapping[str, Any]  # pylint: disable=unsubscriptable-object
 
 
 class JobRouterAdministrationClientOperationsMixin(
     JobRouterAdministrationClientOperationsMixinGenerated
-):  # pylint:disable=too-many-lines,line-too-long,name-too-long,arguments-differ,unused-argument
+):  # pylint:disable=too-many-lines,line-too-long,name-too-long,arguments-differ
     # region ExceptionPolicy
     @overload
-    async def upsert_exception_policy(  # pylint: disable=arguments-differ,unused-argument
+    async def upsert_exception_policy(  # pylint: disable=arguments-differ
         self,
         exception_policy_id: str,
         *,
@@ -53,26 +50,19 @@ async def upsert_exception_policy(  # pylint: disable=arguments-differ,unused-ar
         """Update an exception policy.
 
         :param str exception_policy_id: Id of the exception policy.
-
-        :keyword exception_rules: (Optional) A collection of exception rules on the exception
-          policy.
+        :keyword exception_rules: (Optional) A collection of exception rules on the exception policy.
         :paramtype exception_rules: Optional[Dict[str, ~azure.communication.jobrouter.models.ExceptionRule]]
-
         :keyword Optional[str] name: The name of this policy.
-
         :keyword if_unmodified_since: The request should only proceed if the entity was not modified
          after this time. Default value is None.
         :paramtype if_unmodified_since: ~datetime.datetime
-        :keyword etag: check if resource is changed. Set None to skip checking etag. Default value is
-         None.
+        :keyword etag: check if resource is changed. Set None to skip checking etag. Default value is None.
         :paramtype etag: str
         :keyword match_condition: The match condition to use upon the etag. Default value is None.
         :paramtype match_condition: ~azure.core.MatchConditions
-
         :return: Instance of ExceptionPolicy
         :rtype: ~azure.communication.jobrouter.models.ExceptionPolicy
-        :raises: ~azure.core.exceptions.HttpResponseError, ValueError
-
+        :raises: ~azure.core.exceptions.HttpResponseError
 
         .. admonition:: Example:
 
@@ -148,8 +138,7 @@ async def upsert_exception_policy(
         :keyword if_unmodified_since: The request should only proceed if the entity was not modified
          after this time. Default value is None.
         :paramtype if_unmodified_since: ~datetime.datetime
-        :keyword etag: check if resource is changed. Set None to skip checking etag. Default value is
-         None.
+        :keyword etag: check if resource is changed. Set None to skip checking etag. Default value is None.
         :paramtype etag: str
         :keyword match_condition: The match condition to use upon the etag. Default value is None.
         :paramtype match_condition: ~azure.core.MatchConditions
@@ -198,7 +187,7 @@ async def upsert_exception_policy(
         :raises ~azure.core.exceptions.HttpResponseError:
         """
 
-    async def upsert_exception_policy(
+    async def upsert_exception_policy(  # pylint: disable=docstring-missing-param
         self, exception_policy_id: str, *args: Union[_models.ExceptionPolicy, JSON, IO[bytes]], **kwargs: Any
     ) -> _models.ExceptionPolicy:
         """Update an exception policy.
@@ -297,7 +286,7 @@ def list_exception_policies(
 
     # region DistributionPolicy
     @overload
-    async def upsert_distribution_policy(  # pylint: disable=arguments-differ,unused-argument
+    async def upsert_distribution_policy(  # pylint: disable=arguments-differ
         self,
         distribution_policy_id: str,
         *,
@@ -460,7 +449,7 @@ async def upsert_distribution_policy(
         :raises ~azure.core.exceptions.HttpResponseError:
         """
 
-    async def upsert_distribution_policy(
+    async def upsert_distribution_policy(  # pylint: disable=docstring-missing-param
         self, distribution_policy_id: str, *args: Union[_models.DistributionPolicy, JSON, IO[bytes]], **kwargs: Any
     ) -> _models.DistributionPolicy:
         """Update a distribution policy.
@@ -565,7 +554,7 @@ def list_distribution_policies(
 
     # region Queue
     @overload
-    async def upsert_queue(  # pylint: disable=arguments-differ,unused-argument
+    async def upsert_queue(  # pylint: disable=arguments-differ
         self,
         queue_id: str,
         *,
@@ -731,7 +720,7 @@ async def upsert_queue(
         :raises ~azure.core.exceptions.HttpResponseError:
         """
 
-    async def upsert_queue(
+    async def upsert_queue(  # pylint: disable=docstring-missing-param
         self, queue_id: str, *args: Union[_models.RouterQueue, JSON, IO[bytes]], **kwargs: Any
     ) -> _models.RouterQueue:
         """Update a job queue
@@ -838,7 +827,7 @@ def list_queues(
 
     # region ClassificationPolicy
     @overload
-    async def upsert_classification_policy(  # pylint: disable=arguments-differ,unused-argument
+    async def upsert_classification_policy(  # pylint: disable=arguments-differ
         self,
         classification_policy_id: str,
         *,
@@ -1046,7 +1035,7 @@ async def upsert_classification_policy(
         :raises ~azure.core.exceptions.HttpResponseError:
         """
 
-    async def upsert_classification_policy(
+    async def upsert_classification_policy(  # pylint: disable=docstring-missing-param
         self, classification_policy_id: str, *args: Union[_models.ClassificationPolicy, JSON, IO[bytes]], **kwargs: Any
     ) -> _models.ClassificationPolicy:
         """Update a classification policy
@@ -1174,7 +1163,7 @@ def list_classification_policies(
 class JobRouterClientOperationsMixin(JobRouterClientOperationsMixinGenerated):
     # region Worker
     @overload
-    async def upsert_worker(  # pylint: disable=arguments-differ,unused-argument
+    async def upsert_worker(  # pylint: disable=arguments-differ
         self,
         worker_id: str,
         *,
@@ -1384,7 +1373,7 @@ async def upsert_worker(
         :raises ~azure.core.exceptions.HttpResponseError:
         """
 
-    async def upsert_worker(
+    async def upsert_worker(  # pylint: disable=docstring-missing-param
         self, worker_id: str, *args: Union[_models.RouterWorker, JSON, IO[bytes]], **kwargs: Any
     ) -> _models.RouterWorker:
         """Update a router worker.
@@ -1554,7 +1543,7 @@ def list_workers(
 
     # region Job
     @overload
-    async def upsert_job(  # pylint: disable=arguments-differ,unused-argument
+    async def upsert_job(  # pylint: disable=arguments-differ
         self,
         job_id: str,
         *,
@@ -1752,7 +1741,7 @@ async def upsert_job(
         :raises ~azure.core.exceptions.HttpResponseError:
         """
 
-    async def upsert_job(
+    async def upsert_job(  # pylint: disable=docstring-missing-param
         self, job_id: str, *args: Union[_models.RouterJob, JSON, IO[bytes]], **kwargs: Any
     ) -> _models.RouterJob:
         """Update a job.