Merge remote-tracking branch 'upstream/main'

Author: Xiting Zhang

.github/CODEOWNERS

@@ -108,7 +108,7 @@
 
 # ServiceLabel: %Communication - Phone Numbers
 # PRLabel: %Communication - Phone Numbers
-/sdk/communication/azure-communication-phonenumbers/                 @Arazan @whisper6284 @danielortega-msft @sofiar-msft
+/sdk/communication/azure-communication-phonenumbers/                 @gfeitosa-msft @phermanov-msft @ilyapaliakou-msft @besh2014 @ihuseynov-msft @kirill-linnik
 
 # ServiceLabel: %Communication - Rooms
 # PRLabel: %Communication - Rooms

eng/common/instructions/azsdk-tools/create-release-plan.instructions.md

@@ -23,10 +23,6 @@ Follow these steps in order to create or manage a release plan for an API specif
 Collect the following required information from the user. Do not create a release plan with temporary values. Confirm the values with the user before proceeding to create the release plan.
 If any details are missing, prompt the user accordingly:
 
-- **API Lifecycle Stage**: Must be one of:
-    - Private Preview
-    - Public Preview  
-    - GA (Generally Available)
 - **Service Tree ID**: GUID format identifier for the service in Service Tree. Before creating release plan, always show the value to user and ask them to confirm it's a valid value in service tree.
 - **Product Service Tree ID**: GUID format identifier for the product in Service Tree. Before creating release plan, always show the value to user and ask them to confirm it's a valid value in service tree.
 - **Expected Release Timeline**: Format must be in "Month YYYY"

eng/common/instructions/azsdk-tools/typespec-to-sdk.instructions.md

@@ -94,29 +94,19 @@ Wait for the user to respond with a confirmation before proceeding to Step 1. Us
 **Actions**:
 1. Run `azsdk_get_sdk_pull_request_link` to fetch generated SDK PR info.
 
-## Step 9: Validate Label and Codeowners
-**Goal**: Validate the label and all codeowners for a service. Create new label and codeowner entry if none exist.
-**Actions**:
-1. To validate a service label refer to #file:./validate-service-label.instructions.md
-2. After service label is validated or created refer to #file:./validate-codeowners.instructions.md
-3. Handle post-validation actions based on results:
-   - **If both label and codeowners were already valid**: Prompt user "Your service label and codeowners are already properly configured. Would you like to modify the existing codeowners entry for your service?"
-   - **If new label or codeowner entries were created**: Display details of the label and codeowners PR if they were created, then prompt user "The following PRs have been created for your service configuration: [list PRs]. Would you like to make any additional modifications to these entries?"
-**Success Criteria**: Service label exists and codeowners are properly configured with at least 2 valid owners. For created entries, showcase all PR's.
-
-## Step 10: Create release plan
+## Step 9: Create release plan
 **Goal**: Create a release plan for the generated SDKs
 **Actions**:
 1. Refer to #file:create-release-plan.instructions.md to create a release plan using the spec pull request.
 2. If the release plan already exists, display the existing plan details.
 
-## Step 11: Mark Spec PR as Ready for Review
+## Step 10: Mark Spec PR as Ready for Review
 **Goal**: Update spec PR to ready for review status
 **Actions**:
 1. Prompt user to change spec PR to ready for review: "Please change the spec pull request to ready for review status"
 2. Get approval and merge the spec PR
 
-## Step 12: Release SDK Package
+## Step 11: Release SDK Package
 **Goal**: Release the SDK package using the release plan
 **Actions**:
 1. Run `ReleaseSdkPackage` to release the SDK package.

eng/common/scripts/Helpers/CommandInvocation-Helpers.ps1

@@ -1,4 +1,6 @@
-function Invoke-LoggedCommand
+. $PSScriptRoot/../logging.ps1
+
+function Invoke-LoggedMsbuildCommand
 {
     [CmdletBinding()]
     param
@@ -8,12 +10,26 @@ function Invoke-LoggedCommand
         [switch] $GroupOutput,
         [int[]] $AllowedExitCodes = @(0)
     )
+    return Invoke-LoggedCommand $Command -ExecutePath $ExecutePath -GroupOutput:$GroupOutput -AllowedExitCodes $AllowedExitCodes -OutputProcessor { param($line) ProcessMsBuildLogLine $line }
+
+}
+
+function Invoke-LoggedCommand
+{
+    [CmdletBinding()]
+    param
+    (
+        [string] $Command,
+        [string] $ExecutePath,
+        [switch] $GroupOutput,
+        [int[]] $AllowedExitCodes = @(0),
+        [scriptblock] $OutputProcessor
+    )
 
-    $pipelineBuild = !!$env:TF_BUILD
     $startTime = Get-Date
 
-    if($pipelineBuild -and $GroupOutput) {
-        Write-Host "##[group]$Command"
+    if($GroupOutput) {
+        LogGroupStart $Command
     } else {
         Write-Host "> $Command"
     }
@@ -22,22 +38,22 @@ function Invoke-LoggedCommand
       Push-Location $ExecutePath
     }
 
+    if (!$OutputProcessor) {
+      $OutputProcessor = { param($line) $line }
+    }
+
     try {
-      Invoke-Expression $Command
+      Invoke-Expression $Command | Foreach-Object { & $OutputProcessor $_ }
 
       $duration = (Get-Date) - $startTime
 
-      if($pipelineBuild -and $GroupOutput) {
-        Write-Host "##[endgroup]"
+      if($GroupOutput) {
+        LogGroupEnd
       }
 
       if($LastExitCode -notin $AllowedExitCodes)
       {
-          if($pipelineBuild) {
-              Write-Error "##[error]Command failed to execute ($duration): $Command`n"
-          } else {
-              Write-Error "Command failed to execute ($duration): $Command`n"
-          }
+          LogError "Command failed to execute ($duration): $Command`n"
       }
       else {
           Write-Host "Command succeeded ($duration)`n"

eng/common/scripts/Helpers/DevOps-WorkItem-Helpers.ps1

@@ -1085,12 +1085,15 @@ function Update-PullRequestInReleasePlan($releasePlanWorkItemId, $pullRequestUrl
     }
 
     $fields = @()
-    $fields += "`"SDKPullRequestFor$($devopsFieldLanguage)=$pullRequestUrl`""
+    if ($pullRequestUrl)
+    {
+        $fields += "`"SDKPullRequestFor$($devopsFieldLanguage)=$pullRequestUrl`""
+    }
     $fields += "`"SDKPullRequestStatusFor$($devopsFieldLanguage)=$status`""
 
-    Write-Host "Updating Release Plan [$releasePlanWorkItemId] with Pull Request URL for language [$languageName]."
+    Write-Host "Updating release plan [$releasePlanWorkItemId] with pull request details for language [$languageName]."
     $workItem = UpdateWorkItem -id $releasePlanWorkItemId -fields $fields
-    Write-Host "Updated Pull Request URL [$pullRequestUrl] for [$languageName] in Release Plan [$releasePlanWorkItemId]"
+    Write-Host "Updated pull request details for [$languageName] in release plan [$releasePlanWorkItemId]"
 }
 
 function Get-ReleasePlan-Link($releasePlanWorkItemId)

eng/common/scripts/Submit-PullRequest.ps1

@@ -130,7 +130,8 @@ else {
 
     # ensure that the user that was used to create the PR is not attempted to add as a reviewer
     # we cast to an array to ensure that length-1 arrays actually stay as array values
-    $cleanedUsers = @(SplitParameterArray -members $UserReviewers) | ? { $_ -ne $prOwnerUser -and $null -ne $_ }
+    # we also filter out dependabot user who doesn't have write permission to avoid errors
+    $cleanedUsers = @(SplitParameterArray -members $UserReviewers) | ? { $_ -ne $prOwnerUser -and $null -ne $_ -and $_ -inotlike "dependabot*" }
     $cleanedTeamReviewers = @(SplitParameterArray -members $TeamReviewers) | ? { $_ -ne $prOwnerUser -and $null -ne $_ }
 
     if ($cleanedUsers -or $cleanedTeamReviewers) {
@@ -146,8 +147,13 @@ else {
       $prState = "open"
     }
 
+    # Clean assignees - remove null entries and bot accounts
+    $cleanedAssignees = @(SplitParameterArray -members $Assignees) | ? { 
+      $null -ne $_ -and $_ -inotlike "dependabot*" -and $_ -inotlike "copilot*" 
+    }
+
     Update-GitHubIssue -RepoOwner $RepoOwner -RepoName $RepoName -IssueNumber $prNumber `
-    -State $prState -Labels $PRLabels -Assignees $Assignees -AuthToken $AuthToken
+    -State $prState -Labels $PRLabels -Assignees $cleanedAssignees -AuthToken $AuthToken
 
     if ($AddBuildSummary) {
       $summaryPath = New-TemporaryFile

eng/common/scripts/logging.ps1

@@ -111,3 +111,15 @@ function LogJobFailure() {
   }
   # No equivalent for GitHub Actions.  Failure is only determined by nonzero exit code.
 }
+
+function ProcessMsBuildLogLine($line) {
+  if (Test-SupportsDevOpsLogging) {
+    if ($line -like "*: warning*") {
+      return ("##vso[task.LogIssue type=warning;]$line" -replace "`n", "%0D%0A")
+    }
+    elseif ($line -like "*: error*") {
+      return ("##vso[task.LogIssue type=error;]$line" -replace "`n", "%0D%0A")
+    }
+  }
+  return $line
+}

eng/common/testproxy/target_version.txt

@@ -1 +1 @@
-1.0.0-dev.20250805.1
+1.0.0-dev.20250922.2

eng/common/tsp-client/package-lock.json

@@ -1,5 +1,5 @@
 {
   "dependencies": {
-    "@azure-tools/typespec-client-generator-cli": "0.28.1"
+    "@azure-tools/typespec-client-generator-cli": "0.28.3"
   }
 }