Not support source_delay and source_process_code for derived featureset (#35250)

* Not support source_delay and source_precess_code for derived featureset

* update unit test

* update unit test

* update msg format

* update format

---------

Co-authored-by: Anya Li <[email protected]>

Author: anyalee0221

sdk/ml/azure-ai-ml/azure/ai/ml/entities/_feature_set/source_metadata.py

@@ -47,15 +47,16 @@ def __init__(
                         target=ErrorTarget.FEATURE_SET,
                         error_category=ErrorCategory.USER_ERROR,
                     )
-                if timestamp_column:
-                    msg = f"Cannot provide timestamp_column for {type} feature source."
+                if timestamp_column or source_delay or source_process_code:
+                    msg = f"Cannot provide timestamp_column/source_delay/source_process_code for {type} feature source."
                     raise ValidationException(
                         message=msg,
                         no_personal_data_message=msg,
                         error_type=ValidationErrorType.INVALID_VALUE,
                         target=ErrorTarget.FEATURE_SET,
                         error_category=ErrorCategory.USER_ERROR,
                     )
+
             if not (path and not dict and not source_process_code):
                 msg = f"Cannot provide source_process_code or kwargs for {type} feature source."
                 raise ValidationException(

sdk/ml/azure-ai-ml/tests/feature_set/unittests/test_feature_set_spec_schema.py

@@ -91,3 +91,15 @@ def test_feature_set_spec_load_failure(self) -> None:
         featureset_spec_yaml_path = Path(spec_path, "FeatureSetSpec.yaml")
         with pytest.raises(ValidationException):
             FeaturesetSpecMetadata._load(featureset_spec_contents, featureset_spec_yaml_path)
+
+        spec_path = "./tests/test_configs/feature_set/invalid_spec8"
+        featureset_spec_contents = read_feature_set_metadata(path=spec_path)
+        featureset_spec_yaml_path = Path(spec_path, "FeatureSetSpec.yaml")
+        with pytest.raises(ValidationException):
+            FeaturesetSpecMetadata._load(featureset_spec_contents, featureset_spec_yaml_path)
+
+        spec_path = "./tests/test_configs/feature_set/invalid_spec9"
+        featureset_spec_contents = read_feature_set_metadata(path=spec_path)
+        featureset_spec_yaml_path = Path(spec_path, "FeatureSetSpec.yaml")
+        with pytest.raises(ValidationException):
+            FeaturesetSpecMetadata._load(featureset_spec_contents, featureset_spec_yaml_path)

sdk/ml/azure-ai-ml/tests/test_configs/feature_set/invalid_spec8/FeatureSetSpec.yaml

@@ -0,0 +1,26 @@
+# source_delay is not supported for featureset feature source
+source:
+  type: featureset
+  path: azureml://subscriptions/my_sub/resourcegroups/my_rg/workspaces/my_fs/feturesets/source_feature_set_name/versions/version1
+  source_delay:
+    days: 2
+    hours: 0
+    minutes: 0
+feature_transformation_code:
+  path: ./code
+  transformer_class: driver_hourly_transform.DriverHourlyTransformer
+features:
+  - name: conv_rate
+    type: double
+  - name: acc_rate
+    type: double
+  - name: avg_daily_trips
+    type: double
+source_lookback:
+    days: 30
+    hours: 0
+    minutes: 0
+temporal_join_lookback:
+    days: 2
+    hours: 0
+    minutes: 0

sdk/ml/azure-ai-ml/tests/test_configs/feature_set/invalid_spec9/FeatureSetSpec.yaml

@@ -0,0 +1,25 @@
+# source_process_code is not supported for featureset feature source
+source:
+  type: featureset
+  path: azureml://subscriptions/my_sub/resourcegroups/my_rg/workspaces/my_fs/feturesets/source_feature_set_name/versions/version1
+  source_process_code:
+    path: ./source_process_code
+    process_class: source_process.MyDataSourceLoader
+feature_transformation_code:
+  path: ./code
+  transformer_class: driver_hourly_transform.DriverHourlyTransformer
+features:
+  - name: conv_rate
+    type: double
+  - name: acc_rate
+    type: double
+  - name: avg_daily_trips
+    type: double
+source_lookback:
+    days: 30
+    hours: 0
+    minutes: 0
+temporal_join_lookback:
+    days: 2
+    hours: 0
+    minutes: 0