[Key Vault] Add __(a)enter__ methods to user-facing clients (#35115)

Author: mccoyp

sdk/keyvault/azure-keyvault-administration/CHANGELOG.md

@@ -7,6 +7,8 @@
 ### Breaking Changes
 
 ### Bugs Fixed
+- Typing errors from using Key Vault clients as context managers have been fixed
+  ([#34744](https://github.com/Azure/azure-sdk-for-python/issues/34744))
 
 ### Other Changes
 

sdk/keyvault/azure-keyvault-administration/azure/keyvault/administration/_access_control_client.py

@@ -248,3 +248,7 @@ def list_role_definitions(
             cls=lambda result: [KeyVaultRoleDefinition._from_generated(d) for d in result],
             **kwargs
         )
+
+    def __enter__(self) -> "KeyVaultAccessControlClient":
+        self._client.__enter__()
+        return self

sdk/keyvault/azure-keyvault-administration/azure/keyvault/administration/_backup_client.py

@@ -247,3 +247,7 @@ def begin_restore(self, folder_url: str, *args: str, **kwargs: Any) -> LROPoller
             polling=polling,
             **kwargs,
         )
+
+    def __enter__(self) -> "KeyVaultBackupClient":
+        self._client.__enter__()
+        return self

sdk/keyvault/azure-keyvault-administration/azure/keyvault/administration/_settings_client.py

@@ -82,3 +82,7 @@ def update_setting(self, setting: KeyVaultSetting, **kwargs: Any) -> KeyVaultSet
             **kwargs
         )
         return KeyVaultSetting._from_generated(result)
+
+    def __enter__(self) -> "KeyVaultSettingsClient":
+        self._client.__enter__()
+        return self

sdk/keyvault/azure-keyvault-administration/azure/keyvault/administration/aio/_access_control_client.py

@@ -249,3 +249,7 @@ def list_role_definitions(
             cls=lambda result: [KeyVaultRoleDefinition._from_generated(d) for d in result],
             **kwargs
         )
+
+    async def __aenter__(self) -> "KeyVaultAccessControlClient":
+        await self._client.__aenter__()
+        return self

sdk/keyvault/azure-keyvault-administration/azure/keyvault/administration/aio/_backup_client.py

@@ -244,3 +244,7 @@ async def begin_restore(self, folder_url: str, *args: str, **kwargs: Any) -> Asy
             polling=polling,
             **kwargs,
         )
+
+    async def __aenter__(self) -> "KeyVaultBackupClient":
+        await self._client.__aenter__()
+        return self

sdk/keyvault/azure-keyvault-administration/azure/keyvault/administration/aio/_settings_client.py

@@ -85,3 +85,7 @@ async def update_setting(self, setting: KeyVaultSetting, **kwargs: Any) -> KeyVa
             **kwargs
         )
         return KeyVaultSetting._from_generated(result)
+
+    async def __aenter__(self) -> "KeyVaultSettingsClient":
+        await self._client.__aenter__()
+        return self

sdk/keyvault/azure-keyvault-certificates/CHANGELOG.md

@@ -7,6 +7,8 @@
 ### Breaking Changes
 
 ### Bugs Fixed
+- Typing errors from using Key Vault clients as context managers have been fixed
+  ([#34744](https://github.com/Azure/azure-sdk-for-python/issues/34744))
 
 ### Other Changes
 

sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/_client.py

@@ -1041,3 +1041,7 @@ def list_properties_of_issuers(self, **kwargs: Any) -> ItemPaged[IssuerPropertie
             cls=lambda objs: [IssuerProperties._from_issuer_item(issuer_item=x) for x in objs],
             **kwargs
         )
+
+    def __enter__(self) -> "CertificateClient":
+        self._client.__enter__()
+        return self

sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/aio/_client.py

@@ -1046,3 +1046,7 @@ def list_properties_of_issuers(self, **kwargs: Any) -> AsyncItemPaged[IssuerProp
             cls=lambda objs: [IssuerProperties._from_issuer_item(x) for x in objs],
             **kwargs
         )
+
+    async def __aenter__(self) -> "CertificateClient":
+        await self._client.__aenter__()
+        return self