Fix installation issues occurring during new checks (#43086)

* fix an issue in create_package_and_install to properly pass --python <python executable> when running with `uv`
* add debug `pip freeze` to `pylint`
* swap run_pylint.yml back to the new implementation

Author: scbedd

eng/pipelines/templates/steps/run_pylint.yml

@@ -1,7 +1,6 @@
 parameters:
   ServiceDirectory: ''
   TestMarkArgument: ''
-  EnvVars: {}
   AdditionalTestArgs: ''
 
 # Please use `$(TargetingString)` to refer to the python packages glob string. This variable is set from resolve-package-targeting.yml.
@@ -11,14 +10,13 @@ steps:
   - task: PythonScript@0
     displayName: 'Run Pylint'
     inputs:
-      scriptPath: 'scripts/devops_tasks/dispatch_tox.py'
+      scriptPath: 'eng/scripts/dispatch_checks.py'
       arguments: >-
         "$(TargetingString)"
-        --mark_arg="${{ parameters.TestMarkArgument }}"
         --service="${{ parameters.ServiceDirectory }}"
-        --toxenv="pylint"
-        --disablecov
+        --checks="pylint"
         --filter-type="Omit_management"
         ${{ parameters.AdditionalTestArgs }}
-    env: ${{ parameters.EnvVars }}
+    env:
+      TOX_PIP_IMPL: "uv"
     condition: and(succeededOrFailed(), ne(variables['Skip.Pylint'],'true'))

eng/scripts/dispatch_checks.py

@@ -299,6 +299,10 @@ def handler(signum, frame):
 
     logger.info(f"Beginning discovery for {args.service} and root dir {root_dir}. Resolving to {target_dir}.")
 
+    # ensure that recursive virtual envs aren't messed with by this call
+    os.environ.pop("VIRTUAL_ENV", None)
+    os.environ.pop("PYTHON_HOME", None)
+
     if args.filter_type == "None":
         args.filter_type = "Build"
         compatibility_filter = False

eng/tools/azure-sdk-tools/azpysdk/pylint.py

@@ -3,14 +3,15 @@
 import sys
 
 from typing import Optional, List
+import subprocess
 from subprocess import CalledProcessError, check_call
 
 from .Check import Check
-from ci_tools.functions import install_into_venv
+from ci_tools.functions import install_into_venv, get_pip_command
 from ci_tools.scenario.generation import create_package_and_install
 from ci_tools.variables import discover_repo_root, in_ci, set_envvar_defaults
 from ci_tools.environment_exclusions import is_check_enabled
-from ci_tools.logging import logger
+from ci_tools.logging import logger, run_logged
 
 REPO_ROOT = discover_repo_root()
 PYLINT_VERSION = "3.2.7"
@@ -48,6 +49,7 @@ def run(self, args: argparse.Namespace) -> int:
             package_name = parsed.name
             executable, staging_directory = self.get_executable(args.isolate, args.command, sys.executable, package_dir)
             logger.info(f"Processing {package_name} for pylint check")
+            pip_cmd = get_pip_command(executable)
 
             # install dependencies
             self.install_dev_reqs(executable, args, package_dir)
@@ -64,7 +66,7 @@ def run(self, args: argparse.Namespace) -> int:
                 cache_dir=None,
                 work_dir=staging_directory,
                 force_create=False,
-                package_type="wheel",
+                package_type="sdist",
                 pre_download_disabled=False,
                 python_executable=executable,
             )
@@ -80,6 +82,19 @@ def run(self, args: argparse.Namespace) -> int:
                 logger.error(f"Failed to install pylint: {e}")
                 return e.returncode
 
+            # debug a pip freeze result
+            cmd = pip_cmd + ["freeze"]
+            freeze_result = subprocess.run(
+                cmd,
+                cwd=package_dir,
+                check=False,
+                text=True,
+                stdout=subprocess.PIPE,
+                stderr=subprocess.STDOUT
+            )
+            logger.debug(f"Running pip freeze with {cmd}")
+            logger.debug(freeze_result.stdout)
+
             top_level_module = parsed.namespace.split(".")[0]
 
             if in_ci():
@@ -92,6 +107,15 @@ def run(self, args: argparse.Namespace) -> int:
             rcFileLocation = os.path.join(REPO_ROOT, "eng/pylintrc") if args.next else os.path.join(REPO_ROOT, "pylintrc")
 
             try:
+                logger.info([
+                        executable,
+                        "-m",
+                        "pylint",
+                        "--rcfile={}".format(rcFileLocation),
+                        "--output-format=parseable",
+                        os.path.join(package_dir, top_level_module),
+                    ])
+
                 results.append(check_call(
                     [
                         executable,

eng/tools/azure-sdk-tools/ci_tools/functions.py

@@ -5,6 +5,7 @@
 import tarfile
 import stat
 from ast import Not
+from packaging import tags
 from packaging.specifiers import SpecifierSet
 from packaging.version import Version, parse, InvalidVersion
 from packaging.requirements import Requirement
@@ -612,24 +613,7 @@ def get_interpreter_compatible_tags() -> List[str]:
     This function invokes pip from the invoking interpreter and discovers which tags the interpreter is compatible with.
     """
 
-    commands = [sys.executable, "-m", "pip", "debug", "--verbose"]
-
-    output = subprocess.run(
-        commands,
-        check=True,
-        capture_output=True,
-    ).stdout.decode(encoding="utf-8")
-
-    tag_strings = output.split(os.linesep)
-
-    index = 0
-    for index, value in enumerate(tag_strings):
-        if "Compatible tags" in value:
-            break
-
-    tags = tag_strings[index + 1 :]
-
-    return [tag.strip() for tag in tags if tag]
+    return [str(t) for t in tags.sys_tags()]
 
 
 def check_whl_against_tags(whl_name: str, tags: List[str]) -> bool:

eng/tools/azure-sdk-tools/ci_tools/scenario/generation.py

@@ -177,9 +177,13 @@ def create_package_and_install(
 
             pip_cmd = get_pip_command(python_exe)
             commands = pip_cmd + ["install", built_pkg_path]
+
             commands.extend(additional_downloaded_reqs)
             commands.extend(commands_options)
 
+            if pip_cmd[0] == "uv":
+                commands += ["--python", python_exe]
+
             if work_dir and os.path.exists(work_dir):
                 logger.info("Executing command from {0}:{1}".format(work_dir, commands))
                 subprocess.check_call(commands, cwd=work_dir)