[Storage] Improve datetime utility (#34041)

Author: vincenttran-msft

sdk/storage/azure-storage-file-share/CHANGELOG.md

@@ -14,6 +14,8 @@ pointing to the root of the file share would raise an `InvalidResourceName` on a
 Python 3.12.
 - Fixed an issue where authentication errors could raise `AttributeError` instead of `ClientAuthenticationError` when
 using async OAuth credentials.
+- Fixed an issue where specifying datetime objects with less than 7 digits of precision as input could incorrectly raise
+`InvalidHeaderValue` due to improper precision parsing.
 
 ## 12.15.0 (2023-11-07)
 

sdk/storage/azure-storage-file-share/assets.json

@@ -2,5 +2,5 @@
   "AssetsRepo": "Azure/azure-sdk-assets",
   "AssetsRepoPrefixPath": "python",
   "TagPrefix": "python/storage/azure-storage-file-share",
-  "Tag": "python/storage/azure-storage-file-share_b47b0652ef"
+  "Tag": "python/storage/azure-storage-file-share_48979bc3d9"
 }

sdk/storage/azure-storage-file-share/azure/storage/fileshare/_parser.py

@@ -5,6 +5,7 @@
 # --------------------------------------------------------------------------
 
 from datetime import datetime, timedelta
+from ._generated._serialization import Serializer
 
 _ERROR_TOO_MANY_FILE_PERMISSIONS = 'file_permission and file_permission_key should not be set at the same time'
 _FILE_PERMISSION_TOO_LONG = 'Size of file_permission is too large. file_permission should be <=8KB, else' \
@@ -41,4 +42,6 @@ def _parse_datetime_from_str(string_datetime):
 def _datetime_to_str(datetime_obj):
     if not datetime_obj:
         return None
-    return datetime_obj if isinstance(datetime_obj, str) else datetime_obj.isoformat() + '0Z'
+    if isinstance(datetime_obj, str):
+        return datetime_obj
+    return Serializer.serialize_iso(datetime_obj)[:-1].ljust(27, "0") + "Z"

sdk/storage/azure-storage-file-share/tests/test_file.py

@@ -4,10 +4,8 @@
 # license information.
 # --------------------------------------------------------------------------
 import base64
-import os
 import tempfile
-import uuid
-from datetime import datetime, timedelta
+from datetime import datetime, timedelta, timezone
 
 import pytest
 import requests
@@ -831,6 +829,39 @@ def test_set_file_properties(self, **kwargs):
         assert properties.creation_time is not None
         assert properties.permission_key is not None
 
+    @FileSharePreparer()
+    @recorded_by_proxy
+    def test_set_datetime_all_ms_precision(self, **kwargs):
+        storage_account_name = kwargs.pop("storage_account_name")
+        storage_account_key = kwargs.pop("storage_account_key")
+
+        self._setup(storage_account_name, storage_account_key)
+        file_client = self._create_file()
+
+        date_times = [
+            datetime(3005, 5, 11, 12, 24, 7),
+            datetime(3005, 5, 11, 12, 24, 7, 0),
+            datetime(3005, 5, 11, 12, 24, 7, 1),
+            datetime(3005, 5, 11, 12, 24, 7, 12),
+            datetime(3005, 5, 11, 12, 24, 7, 123),
+            datetime(3005, 5, 11, 12, 24, 7, 1234),
+            datetime(3005, 5, 11, 12, 24, 7, 12345),
+            datetime(3005, 5, 11, 12, 24, 7, 123456),
+            datetime(2023, 12, 8, tzinfo=timezone(-timedelta(hours=7))),
+            datetime(2023, 12, 8, tzinfo=timezone(-timedelta(hours=8))),
+        ]
+
+        # Act / Assert
+        content_settings = ContentSettings(
+            content_language='spanish',
+            content_disposition='inline')
+        for date1, date2 in zip(date_times[::2], date_times[1::2]):
+            file_client.set_http_headers(
+                content_settings=content_settings,
+                file_creation_time=date1,
+                file_last_write_time=date2
+            )
+
     @FileSharePreparer()
     @recorded_by_proxy
     def test_set_file_properties_trailing_dot(self, **kwargs):

sdk/storage/azure-storage-file-share/tests/test_file_async.py

@@ -8,8 +8,7 @@
 import base64
 import os
 import tempfile
-import uuid
-from datetime import datetime, timedelta
+from datetime import datetime, timedelta, timezone
 
 import pytest
 import requests
@@ -844,6 +843,39 @@ async def test_set_file_properties(self, **kwargs):
         assert properties.creation_time is not None
         assert properties.permission_key is not None
 
+    @FileSharePreparer()
+    @recorded_by_proxy_async
+    async def test_set_datetime_all_ms_precision(self, **kwargs):
+        storage_account_name = kwargs.pop("storage_account_name")
+        storage_account_key = kwargs.pop("storage_account_key")
+
+        self._setup(storage_account_name, storage_account_key)
+        file_client = await self._create_file(storage_account_name, storage_account_key)
+
+        date_times = [
+            datetime(3005, 5, 11, 12, 24, 7),
+            datetime(3005, 5, 11, 12, 24, 7, 0),
+            datetime(3005, 5, 11, 12, 24, 7, 1),
+            datetime(3005, 5, 11, 12, 24, 7, 12),
+            datetime(3005, 5, 11, 12, 24, 7, 123),
+            datetime(3005, 5, 11, 12, 24, 7, 1234),
+            datetime(3005, 5, 11, 12, 24, 7, 12345),
+            datetime(3005, 5, 11, 12, 24, 7, 123456),
+            datetime(2023, 12, 8, tzinfo=timezone(-timedelta(hours=7))),
+            datetime(2023, 12, 8, tzinfo=timezone(-timedelta(hours=8))),
+        ]
+
+        # Act / Assert
+        content_settings = ContentSettings(
+            content_language='spanish',
+            content_disposition='inline')
+        for date1, date2 in zip(date_times[::2], date_times[1::2]):
+            await file_client.set_http_headers(
+                content_settings=content_settings,
+                file_creation_time=date1,
+                file_last_write_time=date2
+            )
+
     @FileSharePreparer()
     @recorded_by_proxy_async
     async def test_set_file_properties_trailing_dot(self, **kwargs):