Skip to content

Commit c64ffb6

Browse files
authored
[EH} Remove await from create_producer in async (#34060)
* remove await from create_producer in async * add async to test * update utcnow to use datetime aware method
1 parent 5ee1d7a commit c64ffb6

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

sdk/eventhub/azure-eventhub/tests/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ def resource_group():
122122
resource_client = ResourceManagementClient(EnvironmentCredential(), SUBSCRIPTION_ID, base_url=base_url, credential_scopes=credential_scopes)
123123
resource_group_name = RES_GROUP_PREFIX + str(uuid.uuid4())
124124
parameters = {"location": LOCATION}
125-
expiry = datetime.datetime.utcnow() + datetime.timedelta(days=1)
125+
expiry = datetime.datetime.now(datetime.timezone.utc) + datetime.timedelta(days=1)
126126
parameters['tags'] = {'DeleteAfter': expiry.replace(microsecond=0).isoformat()}
127127
try:
128128
rg = resource_client.resource_groups.create_or_update(

sdk/eventhub/azure-eventhub/tests/livetest/asynctests/test_send_async.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -543,7 +543,7 @@ async def on_success(events, pid):
543543
@pytest.mark.parametrize("keep_alive", [None, 30, 60])
544544
@pytest.mark.liveTest
545545
@pytest.mark.asyncio
546-
def test_send_with_keep_alive_async(connstr_receivers, keep_alive, uamqp_transport):
546+
async def test_send_with_keep_alive_async(connstr_receivers, keep_alive, uamqp_transport):
547547
connection_str, receivers = connstr_receivers
548548
client = EventHubProducerClient.from_connection_string(connection_str, keep_alive=keep_alive, uamqp_transport=uamqp_transport)
549549
assert client._producers["all-partitions"]._keep_alive == keep_alive
@@ -561,7 +561,7 @@ async def test_send_long_wait_idle_timeout(connstr_receivers, keep_alive, uamqp_
561561
retry_total = 0
562562
connection_str, receivers = connstr_receivers
563563
client = EventHubProducerClient.from_connection_string(connection_str, keep_alive=keep_alive, idle_timeout=10, retry_total=retry_total, uamqp_transport=uamqp_transport)
564-
sender = await client._create_producer(partition_id="0")
564+
sender = client._create_producer(partition_id="0")
565565
async with sender:
566566
await sender._open_with_retry()
567567
ed = EventData('data')

0 commit comments

Comments
 (0)