Skip to content

Commit c8ecff2

Browse files
committed
make the sdl parameter always present
1 parent c3730ea commit c8ecff2

File tree

1 file changed

+20
-21
lines changed

1 file changed

+20
-21
lines changed

eng/pipelines/templates/stages/archetype-sdk-client.yml

Lines changed: 20 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -89,28 +89,27 @@ extends:
8989
${{ else }}:
9090
template: v1/1ES.Unofficial.PipelineTemplate.yml@1ESPipelineTemplates
9191
parameters:
92-
${{ if eq(variables['System.TeamProject'], 'internal') }}:
93-
sdl:
94-
sourceAnalysisPool:
95-
name: azsdk-pool-mms-win-2022-1es-pt
96-
image: azsdk-pool-mms-win-2022-1espt
97-
os: windows
98-
eslint:
92+
sdl:
93+
sourceAnalysisPool:
94+
name: azsdk-pool-mms-win-2022-1es-pt
95+
image: azsdk-pool-mms-win-2022-1espt
96+
os: windows
97+
eslint:
98+
enabled: false
99+
justificationForDisabling: "ESLint injected task has failures because it uses an old version of mkdirp. We should not fail for tools not controlled by the repo. See: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3499746&"
100+
codeql:
101+
compiled:
99102
enabled: false
100-
justificationForDisabling: "ESLint injected task has failures because it uses an old version of mkdirp. We should not fail for tools not controlled by the repo. See: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3499746&"
101-
codeql:
102-
compiled:
103-
enabled: false
104-
justificationForDisabling: "CodeQL times our pipelines out by running for 2+ hours before being force canceled."
105-
psscriptanalyzer:
106-
enabled: true
107-
break: true
108-
policy: M365
109-
credscan:
110-
suppressionsFile: '$(Build.SourcesDirectory)/eng/CredScanSuppression.json'
111-
scanFolder: '$(Build.SourcesDirectory)/credscan.tsv'
112-
toolVersion: '2.3.12.23'
113-
baselineFiles: $(Build.SourcesDirectory)/eng/python.gdnbaselines
103+
justificationForDisabling: "CodeQL times our pipelines out by running for 2+ hours before being force canceled."
104+
psscriptanalyzer:
105+
enabled: true
106+
break: true
107+
policy: M365
108+
credscan:
109+
suppressionsFile: '$(Build.SourcesDirectory)/eng/CredScanSuppression.json'
110+
scanFolder: '$(Build.SourcesDirectory)/credscan.tsv'
111+
toolVersion: '2.3.12.23'
112+
baselineFiles: $(Build.SourcesDirectory)/eng/python.gdnbaselines
114113
stages:
115114
- stage: Build
116115
jobs:

0 commit comments

Comments
 (0)