Skip to content

Commit ca6b8ff

Browse files
authored
fixing workspace arm template (issue: 28980) (#35746)
* fixing sweep job service response parsing issue * fixing sweep job service response parsing issue * raising a work around for cmd job and spark job name lowering case * fixing black issue * fixing serialization issue in sweep job * include black fix * found and fix the issue in compute validation * fixing a corrupt wokspace arm template * removing unrelated changes * deleting blank line * adding a default tag to allow application insight as none
1 parent 2565a94 commit ca6b8ff

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

sdk/ml/azure-ai-ml/azure/ai/ml/_arm_deployments/arm_templates/workspace_base.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -795,9 +795,8 @@
795795
"description": "[parameters('description')]",
796796
"storageAccount": "[variables('storageAccount')]",
797797
"keyVault": "[variables('keyVault')]",
798-
"applicationInsights": "[variables('applicationInsights')]",
799798
"containerRegistry": "[if(not(equals(parameters('containerRegistryOption'), 'none')), variables('containerRegistry'), json('null'))]",
800-
"applicationInsights": "[if(not(equals(parameters('applicationInsightsOption'), 'none')), variables('containerRegistry'), json('null'))]",
799+
"applicationInsights": "[if(not(equals(parameters('applicationInsightsOption'), 'none')), variables('applicationInsights'), json('null'))]",
801800
"hbiWorkspace": "[parameters('confidential_data')]",
802801
"imageBuildCompute": "[parameters('imageBuildCompute')]",
803802
"publicNetworkAccess": "[parameters('publicNetworkAccess')]",

sdk/ml/azure-ai-ml/azure/ai/ml/operations/_workspace_operations_base.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,8 @@ def begin_create(
148148
workspace.tags = {}
149149
if workspace.tags.get("createdByToolkit") is None:
150150
workspace.tags["createdByToolkit"] = "sdk-v2-{}".format(VERSION)
151+
if workspace.tags.get("AttachAppInsightsToWorkspace") is None:
152+
workspace.tags["AttachAppInsightsToWorkspace"] = "false"
151153

152154
workspace.resource_group = resource_group
153155
(

0 commit comments

Comments
 (0)