[Storage] Blob Typing Final Revision (#35606)

Author: vincenttran-msft

sdk/storage/azure-storage-blob/azure/__init__.py

@@ -1 +1 @@
-__path__ = __import__('pkgutil').extend_path(__path__, __name__)  # type: str
+__path__ = __import__('pkgutil').extend_path(__path__, __name__)  # type: ignore

sdk/storage/azure-storage-blob/azure/storage/__init__.py

@@ -1 +1 @@
-__path__ = __import__('pkgutil').extend_path(__path__, __name__)  # type: str
+__path__ = __import__('pkgutil').extend_path(__path__, __name__)  # type: ignore

sdk/storage/azure-storage-blob/azure/storage/blob/__init__.py

@@ -7,7 +7,7 @@
 
 import os
 
-from typing import Union, Iterable, AnyStr, IO, Any, Dict  # pylint: disable=unused-import
+from typing import Any, AnyStr, cast, Dict, IO, Iterable, Optional, Union, TYPE_CHECKING
 from ._version import VERSION
 from ._blob_client import BlobClient
 from ._container_client import ContainerClient
@@ -18,17 +18,15 @@
 from ._shared_access_signature import generate_account_sas, generate_container_sas, generate_blob_sas
 from ._shared.policies import ExponentialRetry, LinearRetry
 from ._shared.response_handlers import PartialBatchErrorException
-from ._shared.models import(
+from ._shared.models import (
     LocationMode,
     ResourceTypes,
     AccountSasPermissions,
     StorageErrorCode,
     UserDelegationKey,
     Services
 )
-from ._generated.models import (
-    RehydratePriority,
-)
+from ._generated.models import RehydratePriority
 from ._models import (
     BlobType,
     BlockState,
@@ -67,15 +65,18 @@
 )
 from ._list_blobs_helper import BlobPrefix
 
+if TYPE_CHECKING:
+    from azure.core.credentials import AzureNamedKeyCredential, AzureSasCredential, TokenCredential
+
 __version__ = VERSION
 
 
 def upload_blob_to_url(
-        blob_url,  # type: str
-        data,  # type: Union[Iterable[AnyStr], IO[AnyStr]]
-        credential=None,  # type: Optional[Union[str, Dict[str, str], AzureNamedKeyCredential, AzureSasCredential, "TokenCredential"]] # pylint: disable=line-too-long
-        **kwargs):
-    # type: (...) -> Dict[str, Any]
+    blob_url: str,
+    data: Union[Iterable[AnyStr], IO[AnyStr]],
+    credential: Optional[Union[str, Dict[str, str], "AzureNamedKeyCredential", "AzureSasCredential", "TokenCredential"]] = None,  # pylint: disable=line-too-long
+    **kwargs: Any
+) -> Dict[str, Any]:
     """Upload data to a given URL
 
     The data will be uploaded as a block blob.
@@ -125,10 +126,10 @@ def upload_blob_to_url(
     :rtype: dict(str, Any)
     """
     with BlobClient.from_blob_url(blob_url, credential=credential) as client:
-        return client.upload_blob(data=data, blob_type=BlobType.BlockBlob, **kwargs)
+        return cast(BlobClient, client).upload_blob(data=data, blob_type=BlobType.BLOCKBLOB, **kwargs)
 
 
-def _download_to_stream(client, handle, **kwargs):
+def _download_to_stream(client: BlobClient, handle: IO[bytes], **kwargs: Any) -> None:
     """
     Download data to specified open file-handle.
 
@@ -140,11 +141,11 @@ def _download_to_stream(client, handle, **kwargs):
 
 
 def download_blob_from_url(
-        blob_url,  # type: str
-        output,  # type: str
-        credential=None,  # type: Optional[Union[str, Dict[str, str], AzureNamedKeyCredential, AzureSasCredential, "TokenCredential"]] # pylint: disable=line-too-long
-        **kwargs):
-    # type: (...) -> None
+    blob_url: str,
+    output: Union[str, IO[bytes]],
+    credential: Optional[Union[str, Dict[str, str], "AzureNamedKeyCredential", "AzureSasCredential", "TokenCredential"]] = None,  # pylint: disable=line-too-long
+    **kwargs: Any
+) -> None:
     """Download the contents of a blob to a local file or stream.
 
     :param str blob_url:
@@ -194,7 +195,7 @@ def download_blob_from_url(
     overwrite = kwargs.pop('overwrite', False)
     with BlobClient.from_blob_url(blob_url, credential=credential) as client:
         if hasattr(output, 'write'):
-            _download_to_stream(client, output, **kwargs)
+            _download_to_stream(client, cast(IO[bytes], output), **kwargs)
         else:
             if not overwrite and os.path.isfile(output):
                 raise ValueError(f"The file '{output}' already exists.")