Skip to content

Commit ce5fed0

Browse files
authored
Sync eng/common directory with azure-sdk-tools for PR 7988 (#35038)
* Pass valid original artifact file name in request to APIView
1 parent 78dac20 commit ce5fed0

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

eng/common/scripts/Create-APIReview.ps1

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -89,9 +89,13 @@ function Upload-SourceArtifact($filePath, $apiLabel, $releaseStatus, $packageVer
8989
return $StatusCode
9090
}
9191

92-
function Upload-ReviewTokenFile($packageName, $apiLabel, $releaseStatus, $reviewFileName, $packageVersion)
92+
function Upload-ReviewTokenFile($packageName, $apiLabel, $releaseStatus, $reviewFileName, $packageVersion, $filePath)
9393
{
94-
$params = "buildId=${BuildId}&artifactName=${ArtifactName}&originalFilePath=${packageName}&reviewFilePath=${reviewFileName}"
94+
Write-Host "Original File path: $filePath"
95+
$fileName = Split-Path -Leaf $filePath
96+
Write-Host "OriginalFile name: $fileName"
97+
98+
$params = "buildId=${BuildId}&artifactName=${ArtifactName}&originalFilePath=${fileName}&reviewFilePath=${reviewFileName}"
9599
$params += "&label=${apiLabel}&repoName=${RepoName}&packageName=${packageName}&project=internal&packageVersion=${packageVersion}"
96100
if($MarkPackageAsShipped) {
97101
$params += "&setReleaseTag=true"
@@ -135,17 +139,17 @@ function Get-APITokenFileName($packageName)
135139
}
136140
}
137141

138-
function Submit-APIReview($packageInfo, $packagePath)
142+
function Submit-APIReview($packageInfo, $packagePath, $packageArtifactName)
139143
{
140144
$packageName = $packageInfo.Name
141145
$apiLabel = "Source Branch:${SourceBranch}"
142146

143147
# Get generated review token file if present
144148
# APIView processes request using different API if token file is already generated
145-
$reviewTokenFileName = Get-APITokenFileName $packageName
149+
$reviewTokenFileName = Get-APITokenFileName $packageArtifactName
146150
if ($reviewTokenFileName) {
147151
Write-Host "Uploading review token file $reviewTokenFileName to APIView."
148-
return Upload-ReviewTokenFile $packageName $apiLabel $packageInfo.ReleaseStatus $reviewTokenFileName $packageInfo.Version
152+
return Upload-ReviewTokenFile $packageName $apiLabel $packageInfo.ReleaseStatus $reviewTokenFileName $packageInfo.Version $packagePath
149153
}
150154
else {
151155
Write-Host "Uploading $packagePath to APIView."
@@ -205,7 +209,7 @@ function ProcessPackage($packageName)
205209
if ( ($SourceBranch -eq $DefaultBranch) -or (-not $version.IsPrerelease) -or $MarkPackageAsShipped)
206210
{
207211
Write-Host "Submitting API Review request for package $($pkg), File path: $($pkgPath)"
208-
$respCode = Submit-APIReview $pkgInfo $pkgPath
212+
$respCode = Submit-APIReview $pkgInfo $pkgPath $packageName
209213
Write-Host "HTTP Response code: $($respCode)"
210214

211215
# no need to check API review status when marking a package as shipped

0 commit comments

Comments
 (0)