Skip to content

Commit d678ef6

Browse files
authored
disable model flatten in non-GAed service (#33823)
* disable model flatten in non-GAed service * fix * fix * fix
1 parent 33608ac commit d678ef6

File tree

2 files changed

+23
-1
lines changed

2 files changed

+23
-1
lines changed

scripts/auto_release/main.py

Lines changed: 22 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
from typing import List, Any, Dict
1111
from packaging.version import Version
1212
from ghapi.all import GhApi
13+
from github import Github
1314
from azure.storage.blob import BlobServiceClient, ContainerClient
1415
from datetime import datetime, timedelta
1516

@@ -237,10 +238,14 @@ def edit_sdk_readme(content: List[str]):
237238

238239
modify_file(sdk_readme, edit_sdk_readme)
239240

241+
@property
242+
def readme_python_md_path(self)-> Path:
243+
return Path(self.spec_repo) / "specification" / self.spec_readme.split("specification/")[-1].replace("readme.md", "readme.python.md")
244+
240245
# Use the template to update readme and setup by packaging_tools
241246
@return_origin_path
242247
def check_file_with_packaging_tool(self):
243-
python_md = Path(self.spec_repo) / "specification" / self.spec_readme.split("specification/")[-1].replace("readme.md", "readme.python.md")
248+
python_md = self.readme_python_md_path
244249
title = ""
245250
if python_md.exists():
246251
with open(python_md, "r") as file_in:
@@ -398,6 +403,21 @@ def check_package_size(self):
398403
if os.path.getsize(package) > 2 * 1024 * 1024:
399404
self.check_package_size_result.append(f'ERROR: Package size is over 2MBytes: {Path(package).name}!!!')
400405

406+
def check_model_flatten(self):
407+
last_version = self.get_last_release_version()
408+
if last_version == "" or last_version.startswith("1.0.0b"):
409+
with open(self.readme_python_md_path, 'r') as file_in:
410+
content = file_in.read()
411+
412+
if "flatten-models: false" not in content and self.issue_link:
413+
api = Github(self.bot_token).get_repo("Azure/sdk-release-request")
414+
issue_number = int(self.issue_link.split('/')[-1])
415+
issue = api.get_issue(issue_number)
416+
assignee = issue.assignee.login if issue.assignee else ""
417+
message = "please set `flatten-models: false` in readme.python.md"
418+
issue.create_comment(f'@{assignee}, {message}')
419+
raise Exception(message)
420+
401421
def check_file(self):
402422
self.check_file_with_packaging_tool()
403423
self.check_pprint_name()
@@ -406,6 +426,7 @@ def check_file(self):
406426
self.check_changelog_file()
407427
self.check_dev_requirement()
408428
self.check_package_size()
429+
self.check_model_flatten()
409430

410431
def sdk_code_path(self) -> str:
411432
return str(Path(f'sdk/{self.sdk_folder}/azure-mgmt-{self.package_name}'))

scripts/auto_release/requirement.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
azure-identity
22
python-dotenv==0.15.0
33
ghapi==0.1.19
4+
PyGithub==1.55
45
packaging==23.1
56
pytest==6.2.5
67
azure-storage-blob==12.9.0

0 commit comments

Comments
 (0)