Skip to content

Commit dd01793

Browse files
authored
[Core] Fix for Mypy-Next Errors (#34507)
* add definition for response * type ignore opentelemetry error * fix mypy issues * black * black formatting
1 parent 03dc6b8 commit dd01793

File tree

8 files changed

+23
-15
lines changed

8 files changed

+23
-15
lines changed

sdk/core/azure-core-tracing-opentelemetry/samples/sample_custom_span_processor.py

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -57,15 +57,16 @@ def on_end(self, span: ReadableSpan) -> None:
5757
for regex in self.EXCLUDED_SPAN_NAMES:
5858
if re.match(regex, span.name):
5959
return
60-
if "url.full" in span.attributes:
61-
for regex in self.EXCLUDED_SPAN_URLS:
62-
if re.match(regex, span.attributes["url.full"]):
63-
return
64-
# Check for the older attribute name as well.
65-
if "http.url" in span.attributes:
66-
for regex in self.EXCLUDED_SPAN_URLS:
67-
if re.match(regex, span.attributes["http.url"]):
68-
return
60+
if span.attributes:
61+
if "url.full" in span.attributes:
62+
for regex in self.EXCLUDED_SPAN_URLS:
63+
if isinstance(span.attributes["url.full"], str) and re.match(regex, span.attributes["url.full"]):
64+
return
65+
# Check for the older attribute name as well.
66+
if "http.url" in span.attributes:
67+
for regex in self.EXCLUDED_SPAN_URLS:
68+
if isinstance(span.attributes["http.url"], str) and re.match(regex, span.attributes["http.url"]):
69+
return
6970
super().on_end(span)
7071

7172

sdk/core/azure-core-tracing-opentelemetry/samples/sample_eventgrid.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,8 @@
3636

3737
trace.set_tracer_provider(TracerProvider())
3838
tracer = trace.get_tracer(__name__)
39-
trace.get_tracer_provider().add_span_processor(SimpleSpanProcessor(exporter))
39+
# see issue https://github.com/open-telemetry/opentelemetry-python/issues/3713
40+
trace.get_tracer_provider().add_span_processor(SimpleSpanProcessor(exporter)) # type: ignore
4041

4142
# Example with Eventgrid SDKs
4243
import os

sdk/core/azure-core-tracing-opentelemetry/samples/sample_eventhubs.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,8 @@
3434

3535
trace.set_tracer_provider(TracerProvider())
3636
tracer = trace.get_tracer(__name__)
37-
trace.get_tracer_provider().add_span_processor(SimpleSpanProcessor(exporter))
37+
# see issue https://github.com/open-telemetry/opentelemetry-python/issues/3713
38+
trace.get_tracer_provider().add_span_processor(SimpleSpanProcessor(exporter)) # type: ignore
3839

3940
from azure.eventhub import EventHubProducerClient, EventData
4041
import os

sdk/core/azure-core-tracing-opentelemetry/samples/sample_receive_eh.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@
3535

3636
trace.set_tracer_provider(TracerProvider())
3737
tracer = trace.get_tracer(__name__)
38-
trace.get_tracer_provider().add_span_processor(SimpleSpanProcessor(exporter))
38+
# see issue https://github.com/open-telemetry/opentelemetry-python/issues/3713
39+
trace.get_tracer_provider().add_span_processor(SimpleSpanProcessor(exporter)) # type: ignore
3940

4041
from azure.eventhub import EventHubProducerClient, EventData, EventHubConsumerClient
4142
import os

sdk/core/azure-core-tracing-opentelemetry/samples/sample_receive_sb.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@
4040
# Simple console exporter
4141
exporter = ConsoleSpanExporter()
4242
span_processor = SimpleSpanProcessor(exporter)
43-
trace.get_tracer_provider().add_span_processor(span_processor)
43+
# see issue https://github.com/open-telemetry/opentelemetry-python/issues/3713
44+
trace.get_tracer_provider().add_span_processor(span_processor) # type: ignore
4445

4546
# Example with Servicebus SDKs
4647
from azure.servicebus import ServiceBusClient, ServiceBusMessage

sdk/core/azure-core-tracing-opentelemetry/samples/sample_servicebus.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@
3535

3636
trace.set_tracer_provider(TracerProvider())
3737
tracer = trace.get_tracer(__name__)
38-
trace.get_tracer_provider().add_span_processor(SimpleSpanProcessor(exporter))
38+
# see issue https://github.com/open-telemetry/opentelemetry-python/issues/3713
39+
trace.get_tracer_provider().add_span_processor(SimpleSpanProcessor(exporter)) # type: ignore
3940

4041
# Example with Servicebus SDKs
4142

sdk/core/azure-core-tracing-opentelemetry/samples/sample_storage.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@
3535

3636
trace.set_tracer_provider(TracerProvider())
3737
tracer = trace.get_tracer(__name__)
38-
trace.get_tracer_provider().add_span_processor(SimpleSpanProcessor(exporter))
38+
# see issue https://github.com/open-telemetry/opentelemetry-python/issues/3713
39+
trace.get_tracer_provider().add_span_processor(SimpleSpanProcessor(exporter)) # type: ignore
3940

4041
# Example with Storage SDKs
4142
import os

sdk/core/azure-core/azure/core/pipeline/policies/_authentication_async.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ async def send(
9696
:rtype: ~azure.core.pipeline.PipelineResponse
9797
"""
9898
await await_result(self.on_request, request)
99+
response: PipelineResponse[HTTPRequestType, AsyncHTTPResponseType]
99100
try:
100101
response = await self.next.send(request)
101102
except Exception: # pylint:disable=broad-except

0 commit comments

Comments
 (0)